From: Yangtao Li <frank.li@vivo.com> To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, "Rafael J. Wysocki" <rafael@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>, Alim Akhtar <alim.akhtar@samsung.com> Cc: "Yangtao Li" <frank.li@vivo.com>, "Thomas Gleixner" <tglx@linutronix.de>, "Krzysztof Kozlowski" <krzk@kernel.org>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Jonathan Cameron" <Jonathan.Cameron@Huawei.com>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 10/21] thermal/drivers/exynos: convert to use devm_request*_irq_probe() Date: Mon, 10 Jul 2023 17:59:14 +0800 [thread overview] Message-ID: <20230710095926.15614-10-frank.li@vivo.com> (raw) In-Reply-To: <20230710095926.15614-1-frank.li@vivo.com> There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Cc: Jonathan Cameron <Jonathan.Cameron@Huawei.com> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Signed-off-by: Yangtao Li <frank.li@vivo.com> --- drivers/thermal/samsung/exynos_tmu.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 45e5c840d130..697d2fbdb1bf 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -1100,12 +1100,11 @@ static int exynos_tmu_probe(struct platform_device *pdev) goto err_sclk; } - ret = devm_request_irq(&pdev->dev, data->irq, exynos_tmu_irq, - IRQF_TRIGGER_RISING | IRQF_SHARED, dev_name(&pdev->dev), data); - if (ret) { - dev_err(&pdev->dev, "Failed to request irq: %d\n", data->irq); + ret = devm_request_irq_probe(&pdev->dev, data->irq, exynos_tmu_irq, + IRQF_TRIGGER_RISING | IRQF_SHARED, + dev_name(&pdev->dev), data, NULL); + if (ret) goto err_sclk; - } exynos_tmu_control(pdev, true); return 0; -- 2.39.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Yangtao Li <frank.li@vivo.com> To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, "Rafael J. Wysocki" <rafael@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>, Alim Akhtar <alim.akhtar@samsung.com> Cc: "Yangtao Li" <frank.li@vivo.com>, "Thomas Gleixner" <tglx@linutronix.de>, "Krzysztof Kozlowski" <krzk@kernel.org>, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>, "Jonathan Cameron" <Jonathan.Cameron@Huawei.com>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@collabora.com>, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 10/21] thermal/drivers/exynos: convert to use devm_request*_irq_probe() Date: Mon, 10 Jul 2023 17:59:14 +0800 [thread overview] Message-ID: <20230710095926.15614-10-frank.li@vivo.com> (raw) In-Reply-To: <20230710095926.15614-1-frank.li@vivo.com> There are more than 700 calls to devm_request_threaded_irq method and more than 1000 calls to devm_request_irq method. Most drivers only request one interrupt resource, and these error messages are basically the same. If error messages are printed everywhere, more than 2000 lines of code can be saved by removing the msg in the driver. And tglx point out that: If we actually look at the call sites of devm_request_threaded_irq() then the vast majority of them print more or less lousy error messages. A quick grep/sed/awk/sort/uniq revealed 519 messages total (there are probably more) 352 unique messages 323 unique messages after lower casing Those 323 are mostly just variants of the same patterns with slight modifications in formatting and information provided. 186 of these messages do not deliver any useful information, e.g. "no irq", " The most useful one of all is: "could request wakeup irq: %d" So there is certainly an argument to be made that this particular function should print a well formatted and informative error message. It's not a general allocator like kmalloc(). It's specialized and in the vast majority of cases failing to request the interrupt causes the device probe to fail. So having proper and consistent information why the device cannot be used _is_ useful. So convert to use devm_request*_irq_probe() API, which ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Cc: Jonathan Cameron <Jonathan.Cameron@Huawei.com> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Signed-off-by: Yangtao Li <frank.li@vivo.com> --- drivers/thermal/samsung/exynos_tmu.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 45e5c840d130..697d2fbdb1bf 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -1100,12 +1100,11 @@ static int exynos_tmu_probe(struct platform_device *pdev) goto err_sclk; } - ret = devm_request_irq(&pdev->dev, data->irq, exynos_tmu_irq, - IRQF_TRIGGER_RISING | IRQF_SHARED, dev_name(&pdev->dev), data); - if (ret) { - dev_err(&pdev->dev, "Failed to request irq: %d\n", data->irq); + ret = devm_request_irq_probe(&pdev->dev, data->irq, exynos_tmu_irq, + IRQF_TRIGGER_RISING | IRQF_SHARED, + dev_name(&pdev->dev), data, NULL); + if (ret) goto err_sclk; - } exynos_tmu_control(pdev, true); return 0; -- 2.39.0
next prev parent reply other threads:[~2023-07-10 10:00 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-10 9:59 [PATCH v4 01/21] genirq/devres: Add devm_request_threaded_irq_probe() and devm_request_irq_probe() Yangtao Li 2023-07-10 9:59 ` [PATCH v4 02/21] thermal/drivers/sun8i: convert to use devm_request*_irq_probe() Yangtao Li 2023-07-10 9:59 ` Yangtao Li 2023-07-11 17:57 ` Jernej Škrabec 2023-07-11 17:57 ` Jernej Škrabec 2023-07-10 9:59 ` [PATCH v4 03/21] thermal/drivers/armada: " Yangtao Li 2023-07-10 9:59 ` [PATCH v4 04/21] thermal/drivers/broadcom: " Yangtao Li 2023-07-10 9:59 ` Yangtao Li 2023-07-10 9:59 ` [PATCH v4 05/21] thermal/drivers/tegra: " Yangtao Li 2023-07-10 13:16 ` Thierry Reding 2023-07-10 13:55 ` Krzysztof Kozlowski 2023-07-10 9:59 ` [PATCH v4 06/21] thermal/drivers/db8500: " Yangtao Li 2023-07-10 11:25 ` Dmitry Baryshkov 2023-07-10 11:30 ` Yangtao Li 2023-07-10 11:40 ` Dmitry Baryshkov 2023-07-10 9:59 ` [PATCH v4 07/21] thermal/drivers/rcar: " Yangtao Li 2023-07-10 12:27 ` Geert Uytterhoeven 2023-07-10 9:59 ` [PATCH v4 08/21] thermal/drivers/qcom/temp-alarm: " Yangtao Li 2023-07-10 11:26 ` Dmitry Baryshkov 2023-07-10 9:59 ` [PATCH v4 09/21] thermal: intel: int340x: processor_thermal: " Yangtao Li 2023-07-10 17:28 ` Rafael J. Wysocki 2023-07-10 9:59 ` Yangtao Li [this message] 2023-07-10 9:59 ` [PATCH v4 10/21] thermal/drivers/exynos: " Yangtao Li 2023-07-10 10:14 ` Krzysztof Kozlowski 2023-07-10 10:14 ` Krzysztof Kozlowski 2023-07-10 9:59 ` [PATCH v4 11/21] thermal/drivers/hisi: " Yangtao Li 2023-07-10 9:59 ` [PATCH v4 12/21] thermal/drivers/rockchip: " Yangtao Li 2023-07-10 9:59 ` Yangtao Li 2023-07-10 9:59 ` Yangtao Li 2023-07-10 11:05 ` Heiko Stuebner 2023-07-10 11:05 ` Heiko Stuebner 2023-07-10 11:05 ` Heiko Stuebner 2023-07-10 9:59 ` [PATCH v4 13/21] drivers/thermal/rcar_gen3_thermal: " Yangtao Li 2023-07-10 12:27 ` Geert Uytterhoeven 2023-07-10 9:59 ` [PATCH v4 14/21] thermal/drivers/mediatek/lvts_thermal: " Yangtao Li 2023-07-10 9:59 ` Yangtao Li 2023-07-11 8:04 ` AngeloGioacchino Del Regno 2023-07-11 8:04 ` AngeloGioacchino Del Regno 2023-07-10 9:59 ` [PATCH v4 15/21] thermal: max77620: " Yangtao Li 2023-07-10 9:59 ` [PATCH v4 16/21] thermal/drivers/intel/bxt_pmic: " Yangtao Li 2023-07-10 9:59 ` [PATCH v4 17/21] thermal/drivers/stm: " Yangtao Li 2023-07-10 9:59 ` Yangtao Li 2023-07-10 9:59 ` [PATCH v4 18/21] thermal/drivers/qcom/tsens-v0_1: " Yangtao Li 2023-07-10 11:26 ` Dmitry Baryshkov 2023-07-10 9:59 ` [PATCH v4 19/21] thermal: qcom-spmi-adc-tm5: " Yangtao Li 2023-07-10 11:27 ` Dmitry Baryshkov 2023-07-10 9:59 ` [PATCH v4 20/21] thermal/drivers/uniphier: " Yangtao Li 2023-07-10 9:59 ` Yangtao Li 2023-07-10 9:59 ` [PATCH v4 21/21] thermal/drivers/imx: " Yangtao Li 2023-07-10 9:59 ` Yangtao Li 2023-07-10 12:25 ` [PATCH v4 01/21] genirq/devres: Add devm_request_threaded_irq_probe() and devm_request_irq_probe() Geert Uytterhoeven 2023-07-10 12:41 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230710095926.15614-10-frank.li@vivo.com \ --to=frank.li@vivo.com \ --cc=Jonathan.Cameron@Huawei.com \ --cc=alim.akhtar@samsung.com \ --cc=amitk@kernel.org \ --cc=angelogioacchino.delregno@collabora.com \ --cc=bzolnier@gmail.com \ --cc=daniel.lezcano@linaro.org \ --cc=krzk@kernel.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=rafael@kernel.org \ --cc=rui.zhang@intel.com \ --cc=tglx@linutronix.de \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.