From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, Shuah Khan <shuah@kernel.org>,
Kees Cook <keescook@chromium.org>,
"David S. Miller" <davem@davemloft.net>,
Paul Blakey <paulb@mellanox.com>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
mptcp@lists.linux.dev
Cc: Pedro Tammela <pctammela@mojatatu.com>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Matthieu Baerts <matthieu.baerts@tessares.net>,
stable@vger.kernel.org
Subject: [PATCH net 1/3] selftests: tc: set timeout to 15 minutes
Date: Thu, 13 Jul 2023 23:16:44 +0200 [thread overview]
Message-ID: <20230713-tc-selftests-lkft-v1-1-1eb4fd3a96e7@tessares.net> (raw)
In-Reply-To: <20230713-tc-selftests-lkft-v1-0-1eb4fd3a96e7@tessares.net>
When looking for something else in LKFT reports [1], I noticed that the
TC selftest ended with a timeout error:
not ok 1 selftests: tc-testing: tdc.sh # TIMEOUT 45 seconds
The timeout had been introduced 3 years ago, see the Fixes commit below.
This timeout is only in place when executing the selftests via the
kselftests runner scripts. I guess this is not what most TC devs are
using and nobody noticed the issue before.
The new timeout is set to 15 minutes as suggested by Pedro [2]. It looks
like it is plenty more time than what it takes in "normal" conditions.
Fixes: 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second timeout per test")
Cc: stable@vger.kernel.org
Link: https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20230711/testrun/18267241/suite/kselftest-tc-testing/test/tc-testing_tdc_sh/log [1]
Link: https://lore.kernel.org/netdev/0e061d4a-9a23-9f58-3b35-d8919de332d7@tessares.net/T/ [2]
Suggested-by: Pedro Tammela <pctammela@mojatatu.com>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
---
tools/testing/selftests/tc-testing/settings | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/tc-testing/settings b/tools/testing/selftests/tc-testing/settings
new file mode 100644
index 000000000000..e2206265f67c
--- /dev/null
+++ b/tools/testing/selftests/tc-testing/settings
@@ -0,0 +1 @@
+timeout=900
--
2.40.1
next prev parent reply other threads:[~2023-07-13 21:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 21:16 [PATCH net 0/3] selftests: tc: increase timeout and add missing kconfig Matthieu Baerts
2023-07-13 21:16 ` Matthieu Baerts [this message]
2023-07-14 2:25 ` [PATCH net 1/3] selftests: tc: set timeout to 15 minutes shaozhengchao
2023-07-14 17:49 ` Pedro Tammela
2023-07-17 8:32 ` Matthieu Baerts
2023-07-18 1:43 ` shaozhengchao
2023-07-13 21:16 ` [PATCH net 2/3] selftests: tc: add 'ct' action kconfig dep Matthieu Baerts
2023-07-14 2:56 ` shaozhengchao
2023-07-13 21:16 ` [PATCH net 3/3] selftests: tc: add ConnTrack procfs kconfig Matthieu Baerts
2023-07-13 23:54 ` selftests: tc: add ConnTrack procfs kconfig: Tests Results MPTCP CI
2023-07-14 3:25 ` [PATCH net 3/3] selftests: tc: add ConnTrack procfs kconfig shaozhengchao
2023-07-14 4:26 ` selftests: tc: add ConnTrack procfs kconfig: Tests Results MPTCP CI
2023-07-18 3:03 ` MPTCP CI
2023-07-13 22:41 ` [PATCH net 0/3] selftests: tc: increase timeout and add missing kconfig Jamal Hadi Salim
2023-07-18 8:46 ` Matthieu Baerts
2023-07-19 0:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230713-tc-selftests-lkft-v1-1-1eb4fd3a96e7@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=paulb@mellanox.com \
--cc=pctammela@mojatatu.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.