All of lore.kernel.org
 help / color / mirror / Atom feed
From: Biju Das <biju.das.jz@bp.renesas.com>
To: Peter Rosin <peda@axentia.se>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
	Michael Hennerich <michael.hennerich@analog.com>,
	linux-i2c@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	linux-renesas-soc@vger.kernel.org
Subject: [PATCH v2 2/2] i2c: mux: ltc4306: Drop enum ltc_type and split chips[]
Date: Mon, 17 Jul 2023 14:48:07 +0100	[thread overview]
Message-ID: <20230717134807.265302-3-biju.das.jz@bp.renesas.com> (raw)
In-Reply-To: <20230717134807.265302-1-biju.das.jz@bp.renesas.com>

Drop enum ltc_type and split the array chips[] as individual
variables, and make lines shorter by referring to e.g. &ltc_4305_chip
instead of &chips[ltc_4305].

Suggested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v2:
 * New patch
---
 drivers/i2c/muxes/i2c-mux-ltc4306.c | 28 +++++++++++-----------------
 1 file changed, 11 insertions(+), 17 deletions(-)

diff --git a/drivers/i2c/muxes/i2c-mux-ltc4306.c b/drivers/i2c/muxes/i2c-mux-ltc4306.c
index c7dfd5eba413..c4f090e8d6db 100644
--- a/drivers/i2c/muxes/i2c-mux-ltc4306.c
+++ b/drivers/i2c/muxes/i2c-mux-ltc4306.c
@@ -34,11 +34,6 @@
 #define LTC_GPIO_ALL_INPUT	0xC0
 #define LTC_SWITCH_MASK		0xF0
 
-enum ltc_type {
-	ltc_4305,
-	ltc_4306,
-};
-
 struct chip_desc {
 	u8 nchans;
 	u8 num_gpios;
@@ -50,14 +45,13 @@ struct ltc4306 {
 	const struct chip_desc *chip;
 };
 
-static const struct chip_desc chips[] = {
-	[ltc_4305] = {
-		.nchans = LTC4305_MAX_NCHANS,
-	},
-	[ltc_4306] = {
-		.nchans = LTC4306_MAX_NCHANS,
-		.num_gpios = 2,
-	},
+static const struct chip_desc ltc_4305_chip = {
+	.nchans = LTC4305_MAX_NCHANS
+};
+
+static const struct chip_desc ltc_4306_chip = {
+	.nchans = LTC4306_MAX_NCHANS,
+	.num_gpios = 2
 };
 
 static bool ltc4306_is_volatile_reg(struct device *dev, unsigned int reg)
@@ -192,15 +186,15 @@ static int ltc4306_deselect_mux(struct i2c_mux_core *muxc, u32 chan)
 }
 
 static const struct i2c_device_id ltc4306_id[] = {
-	{ "ltc4305", .driver_data = (kernel_ulong_t)&chips[ltc_4305] },
-	{ "ltc4306", .driver_data = (kernel_ulong_t)&chips[ltc_4306] },
+	{ "ltc4305", .driver_data = (kernel_ulong_t)&ltc_4305_chip },
+	{ "ltc4306", .driver_data = (kernel_ulong_t)&ltc_4306_chip },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, ltc4306_id);
 
 static const struct of_device_id ltc4306_of_match[] = {
-	{ .compatible = "lltc,ltc4305", .data = &chips[ltc_4305] },
-	{ .compatible = "lltc,ltc4306", .data = &chips[ltc_4306] },
+	{ .compatible = "lltc,ltc4305", .data = &ltc_4305_chip },
+	{ .compatible = "lltc,ltc4306", .data = &ltc_4306_chip },
 	{ }
 };
 MODULE_DEVICE_TABLE(of, ltc4306_of_match);
-- 
2.25.1


  parent reply	other threads:[~2023-07-17 13:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-17 13:48 [PATCH v2 0/2] ltc4306 driver enhancements Biju Das
2023-07-17 13:48 ` [PATCH v2 1/2] i2c: mux: ltc4306: Simplify probe() Biju Das
2023-07-17 13:48 ` Biju Das [this message]
2023-08-05 13:12   ` [PATCH v2 2/2] i2c: mux: ltc4306: Drop enum ltc_type and split chips[] Andi Shyti
2023-08-05 14:13   ` Peter Rosin
2023-08-05 14:25     ` Biju Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230717134807.265302-3-biju.das.jz@bp.renesas.com \
    --to=biju.das.jz@bp.renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=peda@axentia.se \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.