All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Willy Tarreau <w@1wt.eu>
Cc: "Zhangjin Wu" <falcon@tinylab.org>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	"Thomas Weißschuh" <linux@weissschuh.net>
Subject: [PATCH RFC 2/7] selftests/nolibc: use unsigned indices for testcases
Date: Wed, 19 Jul 2023 00:00:40 +0200	[thread overview]
Message-ID: <20230719-nolibc-ktap-tmp-v1-2-930bd0c52ff1@weissschuh.net> (raw)
In-Reply-To: <20230719-nolibc-ktap-tmp-v1-0-930bd0c52ff1@weissschuh.net>

They should never be negative.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 tools/testing/selftests/nolibc/nolibc-test.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
index 698af242d3e4..1bd99e0fab4d 100644
--- a/tools/testing/selftests/nolibc/nolibc-test.c
+++ b/tools/testing/selftests/nolibc/nolibc-test.c
@@ -62,7 +62,7 @@ static const char *argv0;
 /* definition of a series of tests */
 struct test {
 	const char *name;              /* test name */
-	int (*func)(int min, int max); /* handler */
+	int (*func)(unsigned int min, unsigned int max); /* handler */
 };
 
 #ifndef _NOLIBC_STDLIB_H
@@ -570,7 +570,7 @@ static int expect_strne(const char *expr, int llen, const char *cmp)
 #define CASE_TEST(name) \
 	case __LINE__: llen += printf("%d %s", test, #name);
 
-int run_startup(int min, int max)
+int run_startup(unsigned int min, unsigned int max)
 {
 	int test;
 	int ret = 0;
@@ -773,7 +773,7 @@ int test_mmap_munmap(void)
 /* Run syscall tests between IDs <min> and <max>.
  * Return 0 on success, non-zero on failure.
  */
-int run_syscall(int min, int max)
+int run_syscall(unsigned int min, unsigned int max)
 {
 	struct timeval tv;
 	struct timezone tz;
@@ -884,7 +884,7 @@ int run_syscall(int min, int max)
 	return ret;
 }
 
-int run_stdlib(int min, int max)
+int run_stdlib(unsigned int min, unsigned int max)
 {
 	int test;
 	int tmp;
@@ -1027,7 +1027,7 @@ static int expect_vfprintf(int llen, size_t c, const char *expected, const char
 	return ret;
 }
 
-static int run_vfprintf(int min, int max)
+static int run_vfprintf(unsigned int min, unsigned int max)
 {
 	int test;
 	int tmp;
@@ -1070,7 +1070,7 @@ static int smash_stack(void)
 	return 1;
 }
 
-static int run_protection(int min, int max)
+static int run_protection(unsigned int min, unsigned int max)
 {
 	pid_t pid;
 	int llen = 0, status;

-- 
2.41.0


  parent reply	other threads:[~2023-07-18 22:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-18 22:00 [PATCH RFC 0/7] selftests/nolibc: KTAP output Thomas Weißschuh
2023-07-18 22:00 ` [PATCH RFC 1/7] selftests/nolibc: statically calculate number of testsuites Thomas Weißschuh
2023-07-18 22:00 ` Thomas Weißschuh [this message]
2023-07-18 22:00 ` [PATCH RFC 3/7] selftests/nolibc: replace repetitive test structure with macro Thomas Weißschuh
2023-07-18 22:00 ` [PATCH RFC 4/7] selftests/nolibc: count subtests Thomas Weißschuh
2023-07-18 22:00 ` [PATCH RFC 5/7] kselftest: support KTAP format Thomas Weißschuh
2023-07-18 22:00 ` [PATCH RFC 6/7] kselftest: support skipping tests with testname Thomas Weißschuh
2023-07-18 22:00 ` [PATCH RFC 7/7] selftests/nolibc: proof of concept for TAP output Thomas Weißschuh
2023-07-20 15:29   ` Zhangjin Wu
2023-07-21 13:06     ` Thomas Weißschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230719-nolibc-ktap-tmp-v1-2-930bd0c52ff1@weissschuh.net \
    --to=linux@weissschuh.net \
    --cc=falcon@tinylab.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.