All of lore.kernel.org
 help / color / mirror / Atom feed
From: "sandeep.cs" <sandeep.cs@samsung.com>
To: Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: junwan.cho@samsung.com, jitender.s21@samsung.com,
	suhyun_.kim@samsung.com, ih0923.kim@samsung.com,
	gaudium.lee@samsung.com, sandeep.cs@samsung.com,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [HID Patchsets v1 2/2] HID: Removed USB Validation check
Date: Mon, 24 Jul 2023 14:17:51 +0530	[thread overview]
Message-ID: <20230724084752.371245-3-sandeep.cs@samsung.com> (raw)
In-Reply-To: <20230724084752.371245-1-sandeep.cs@samsung.com>

Earlier Samsung driver only handles USB HID devices and returns an error if it encounters a Bluetooth type of HID device.
By removing this USB validation check, we allow the driver to handle other types of HID devices including Bluetooth HID devices, which were previously excluded.

This change improves driver compatibility and extends its support for a wide range of devices.

Signed-off-by: Sandeep C S<sandeep.cs@samsung.com>
Signed-off-by: Junwan Cho <junwan.cho@samsung.com>
Signed-off-by: Jitender Sajwan <jitender.s21@samsung.com>
---
 drivers/hid/hid-samsung.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/hid/hid-samsung.c b/drivers/hid/hid-samsung.c
index 33e963303d11..3cafbf4d9dc6 100644
--- a/drivers/hid/hid-samsung.c
+++ b/drivers/hid/hid-samsung.c
@@ -517,9 +517,6 @@ static int samsung_probe(struct hid_device *hdev,
 	int ret;
 	unsigned int cmask = HID_CONNECT_DEFAULT;
 
-	if (!hid_is_usb(hdev))
-		return -EINVAL;
-
 	ret = hid_parse(hdev);
 	if (ret) {
 		hid_err(hdev, "parse failed\n");
-- 
2.25.1


  parent reply	other threads:[~2023-07-24  8:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230724084829epcas5p1686507367b11db0ff5d17c3e6cb1ff7c@epcas5p1.samsung.com>
2023-07-24  8:47 ` [HID Patchsets v1 0/2] HID Patchsets for Samsung driver sandeep.cs
     [not found]   ` <CGME20230724084836epcas5p3c6044b8e4b7824c3d1b2e221aa531a00@epcas5p3.samsung.com>
2023-07-24  8:47     ` [HID Patchsets v1 1/2] HID: Add support for Samsung Bluetooth hid devices sandeep.cs
2023-07-24 10:13       ` Benjamin Tissoires
     [not found]   ` <CGME20230724084841epcas5p16f6df46aaffb860813412d19e2e8abb5@epcas5p1.samsung.com>
2023-07-24  8:47     ` sandeep.cs [this message]
2023-07-24 10:10       ` [HID Patchsets v1 2/2] HID: Removed USB Validation check Benjamin Tissoires
2023-07-31 11:13         ` sandeep.cs
2023-08-16  9:46         ` sandeep.cs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230724084752.371245-3-sandeep.cs@samsung.com \
    --to=sandeep.cs@samsung.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=gaudium.lee@samsung.com \
    --cc=ih0923.kim@samsung.com \
    --cc=jikos@kernel.org \
    --cc=jitender.s21@samsung.com \
    --cc=junwan.cho@samsung.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suhyun_.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.