All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rae Moar <rmoar@google.com>
To: shuah@kernel.org, davidgow@google.com, dlatypov@google.com,
	brendan.higgins@linux.dev
Cc: linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
	linux-kernel@vger.kernel.org, keescook@chromium.org,
	linux-hardening@vger.kernel.org, jstultz@google.com,
	tglx@linutronix.de, sboyd@kernel.org, Rae Moar <rmoar@google.com>
Subject: [PATCH v3 7/9] kunit: time: Mark test as slow using test attributes
Date: Tue, 25 Jul 2023 21:25:18 +0000	[thread overview]
Message-ID: <20230725212522.1622716-8-rmoar@google.com> (raw)
In-Reply-To: <20230725212522.1622716-1-rmoar@google.com>

Mark the time KUnit test, time64_to_tm_test_date_range, as slow using test
attributes.

This test ran relatively much slower than most other KUnit tests.

By marking this test as slow, the test can now be filtered using the KUnit
test attribute filtering feature. Example: --filter "speed>slow". This will
run only the tests that have speeds faster than slow. The slow attribute
will also be outputted in KTAP.

Reviewed-by: David Gow <davidgow@google.com>
Signed-off-by: Rae Moar <rmoar@google.com>
---

Changes since v2:
- No changes.
Changes since v1:
- No changes.
Changes since RFC v2:
- No changes.
Changes since RFC v1:
- No changes.

 kernel/time/time_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/time_test.c b/kernel/time/time_test.c
index 831e8e779ace..ca058c8af6ba 100644
--- a/kernel/time/time_test.c
+++ b/kernel/time/time_test.c
@@ -86,7 +86,7 @@ static void time64_to_tm_test_date_range(struct kunit *test)
 }
 
 static struct kunit_case time_test_cases[] = {
-	KUNIT_CASE(time64_to_tm_test_date_range),
+	KUNIT_CASE_SLOW(time64_to_tm_test_date_range),
 	{}
 };
 
-- 
2.41.0.487.g6d72f3e995-goog


  parent reply	other threads:[~2023-07-25 21:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-25 21:25 [PATCH v3 0/9] kunit: Add test attributes API Rae Moar
2023-07-25 21:25 ` [PATCH v3 1/9] kunit: Add test attributes API structure Rae Moar
2023-07-25 21:25 ` [PATCH v3 2/9] kunit: Add speed attribute Rae Moar
2023-07-25 21:25 ` [PATCH v3 3/9] kunit: Add module attribute Rae Moar
2023-07-25 21:25 ` [PATCH v3 4/9] kunit: Add ability to filter attributes Rae Moar
2023-07-27  5:12   ` Dan Carpenter
2023-07-27 21:50     ` Rae Moar
2023-08-29 22:46   ` Guenter Roeck
2023-08-30  0:24     ` David Gow
2023-08-30  1:48       ` Guenter Roeck
2023-07-25 21:25 ` [PATCH v3 5/9] kunit: tool: Add command line interface to filter and report attributes Rae Moar
2023-07-25 21:25 ` [PATCH v3 6/9] kunit: memcpy: Mark tests as slow using test attributes Rae Moar
2023-07-25 21:25 ` Rae Moar [this message]
2023-07-25 21:25 ` [PATCH v3 8/9] kunit: add tests for filtering attributes Rae Moar
2023-07-25 21:25 ` [PATCH v3 9/9] kunit: Add documentation of KUnit test attributes Rae Moar
2023-07-26 14:56 ` [PATCH v3 0/9] kunit: Add test attributes API Arthur Grillo Queiroz Cabral
2023-07-26 14:57 ` Arthur Grillo Queiroz Cabral
2023-07-28 10:38 ` Guenter Roeck
2023-07-29  7:53   ` David Gow
2023-07-29 13:55     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230725212522.1622716-8-rmoar@google.com \
    --to=rmoar@google.com \
    --cc=brendan.higgins@linux.dev \
    --cc=davidgow@google.com \
    --cc=dlatypov@google.com \
    --cc=jstultz@google.com \
    --cc=keescook@chromium.org \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=sboyd@kernel.org \
    --cc=shuah@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.