All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yangtao Li <frank.li@vivo.com>
To: Jaehoon Chung <jh80.chung@samsung.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Alim Akhtar <alim.akhtar@samsung.com>
Cc: "Yangtao Li" <frank.li@vivo.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 14/61] mmc: dw_mmc: exynos: Convert to platform remove callback returning void
Date: Wed, 26 Jul 2023 11:59:54 +0800	[thread overview]
Message-ID: <20230726040041.26267-14-frank.li@vivo.com> (raw)
In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com>

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 drivers/mmc/host/dw_mmc-exynos.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
index 9f20ac524c8b..698408e8bad0 100644
--- a/drivers/mmc/host/dw_mmc-exynos.c
+++ b/drivers/mmc/host/dw_mmc-exynos.c
@@ -664,15 +664,13 @@ static int dw_mci_exynos_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int dw_mci_exynos_remove(struct platform_device *pdev)
+static void dw_mci_exynos_remove(struct platform_device *pdev)
 {
 	pm_runtime_disable(&pdev->dev);
 	pm_runtime_set_suspended(&pdev->dev);
 	pm_runtime_put_noidle(&pdev->dev);
 
 	dw_mci_pltfm_remove(pdev);
-
-	return 0;
 }
 
 static const struct dev_pm_ops dw_mci_exynos_pmops = {
@@ -685,7 +683,7 @@ static const struct dev_pm_ops dw_mci_exynos_pmops = {
 
 static struct platform_driver dw_mci_exynos_pltfm_driver = {
 	.probe		= dw_mci_exynos_probe,
-	.remove		= dw_mci_exynos_remove,
+	.remove_new	= dw_mci_exynos_remove,
 	.driver		= {
 		.name		= "dwmmc_exynos",
 		.probe_type	= PROBE_PREFER_ASYNCHRONOUS,
-- 
2.39.0


  parent reply	other threads:[~2023-07-26  4:03 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26  3:59 [PATCH v2 01/61] mmc: sunxi: Convert to platform remove callback returning void Yangtao Li
2023-07-26  3:59 ` [PATCH v2 02/61] mmc: bcm2835: " Yangtao Li
2023-07-26  3:59 ` [PATCH v2 03/61] mmc: jz4740: " Yangtao Li
2023-07-26  3:59 ` [PATCH v2 04/61] mmc: litex_mmc: " Yangtao Li
2023-07-26  3:59 ` [PATCH v2 05/61] mmc: mtk-sd: " Yangtao Li
2023-07-26  8:26   ` AngeloGioacchino Del Regno
2023-07-26  3:59 ` [PATCH v2 06/61] mmc: cb710: " Yangtao Li
2023-07-26  3:59 ` [PATCH v2 07/61] mmc: davinci_mmc: " Yangtao Li
2023-07-26  3:59 ` [PATCH v2 08/61] mmc: dw_mmc: hi3798cv200: " Yangtao Li
2023-07-26  3:59 ` [PATCH v2 09/61] mmc: sdhci-pic32: " Yangtao Li
2023-07-26  6:20   ` Adrian Hunter
2023-07-26  6:40     ` Yangtao Li
2023-07-26  3:59 ` [PATCH v2 10/61] mmc: sdhci: milbeaut: " Yangtao Li
2023-07-26  3:59 ` [PATCH v2 11/61] mmc: omap_hsmmc: " Yangtao Li
2023-07-26  3:59 ` [PATCH v2 12/61] mmc: sdhci-of-at91: " Yangtao Li
2023-07-27  5:40   ` claudiu beznea
2023-07-27  5:40     ` claudiu beznea
2023-07-26  3:59 ` [PATCH v2 13/61] mmc: omap: " Yangtao Li
2023-07-26  3:59 ` Yangtao Li [this message]
2023-07-26  3:59 ` [PATCH v2 15/61] mmc: sdhci-pxav3: " Yangtao Li
2023-07-26  3:59 ` [PATCH v2 16/61] mmc: rtsx_pci: Drop if block with always false condition Yangtao Li
2023-07-26  6:47   ` Uwe Kleine-König
2023-07-26  3:59 ` [PATCH v2 17/61] mmc: rtsx_pci: Convert to platform remove callback returning void Yangtao Li
2023-07-26  3:59 ` [PATCH v2 18/61] mmc: sh_mmcif: " Yangtao Li
2023-07-26  3:59 ` [PATCH v2 19/61] mmc: meson-gx: " Yangtao Li
2023-07-26  3:59   ` Yangtao Li
2023-07-26  4:00 ` [PATCH v2 20/61] mmc: xenon: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 21/61] mmc: sdhci-s3c: " Yangtao Li
2023-07-27  0:51   ` Andi Shyti
2023-07-26  4:00 ` [PATCH v2 22/61] mmc: meson-mx-sdhc: " Yangtao Li
2023-07-26  4:00   ` Yangtao Li
2023-07-26  4:00 ` [PATCH v2 23/61] mmc: rtsx_usb_sdmmc: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 24/61] mmc: mxs-mmc: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 25/61] mmc: f-sdh30: " Yangtao Li
2023-07-26  6:39   ` Adrian Hunter
2023-07-26  6:53   ` Uwe Kleine-König
2023-07-26  4:00 ` [PATCH v2 26/61] mmc: sdhci-of-arasan: " Yangtao Li
2023-07-27  6:25   ` Michal Simek
2023-07-27  6:25     ` Michal Simek
2023-07-26  4:00 ` [PATCH v2 27/61] mmc: sdhci-of-dwcmshc: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 28/61] mmc: au1xmmc: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 29/61] mmc: cavium-octeon: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 30/61] mmc: pxamci: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 31/61] mmc: moxart: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 32/61] mmc: sdhci-omap: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 33/61] mmc: sdhci-of-aspeed: remove unneeded variables Yangtao Li
2023-07-26  6:45   ` Adrian Hunter
2023-07-26  6:45     ` Adrian Hunter
2023-07-26  6:57   ` Uwe Kleine-König
2023-07-26  6:57     ` Uwe Kleine-König
2023-07-26  4:00 ` [PATCH v2 34/61] mmc: sdhci-of-aspeed: Convert to platform remove Yangtao Li
2023-07-26  6:54   ` Adrian Hunter
2023-07-26  6:54     ` Adrian Hunter
2023-07-26  4:00 ` [PATCH v2 35/61] mmc: meson-mx-sdio: Convert to platform remove callback returning void Yangtao Li
2023-07-26  4:00   ` Yangtao Li
2023-07-26  4:00 ` [PATCH v2 36/61] mmc: sdhci-sprd: " Yangtao Li
2023-07-26  6:00   ` Chunyan Zhang
2023-07-26  4:00 ` [PATCH v2 37/61] mmc: sdhci-tegra: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 38/61] mmc: sdhci-acpi: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 39/61] mmc: sdhci-esdhc-imx: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 40/61] mmc: sdhci-msm: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 41/61] mmc: alcor: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 42/61] mmc: dw_mmc: rockchip: " Yangtao Li
2023-07-26  4:00   ` Yangtao Li
2023-07-26  4:00 ` [PATCH v2 43/61] mmc: owl: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 44/61] mmc: wbsd: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 45/61] mmc: usdhi60rol0: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 46/61] mmc: atmel-mci: " Yangtao Li
2023-07-27  5:41   ` claudiu beznea
2023-07-27  5:41     ` claudiu beznea
2023-07-26  4:00 ` [PATCH v2 47/61] mmc: sdhci-st: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 48/61] mmc: wmt-sdmmc: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 49/61] mmc: sdhci-esdhc-mcf: " Yangtao Li
2023-07-26  6:14   ` Angelo Dureghello
2023-07-26  4:00 ` [PATCH v2 50/61] mmc: sunplus-mmc: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 51/61] mmc: sdhci-spear: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 52/61] mmc: mxcmmc: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 53/61] mmc: mvsdio: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 54/61] mmc: pwrseq_simple: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 55/61] mmc: pwrseq: sd8787: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 56/61] mmc: pwrseq: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 57/61] mmc: renesas_sdhi: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 58/61] mmc: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 59/61] mmc: uniphier-sd: " Yangtao Li
2023-07-26  4:00 ` [PATCH v2 60/61] mmc: sdhci_am654: Properly handle failures in .remove() Yangtao Li
2023-07-26  7:02   ` Uwe Kleine-König
2023-07-26  4:00 ` [PATCH v2 61/61] mmc: sdhci_am654: Convert to platform remove callback returning void Yangtao Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230726040041.26267-14-frank.li@vivo.com \
    --to=frank.li@vivo.com \
    --cc=alim.akhtar@samsung.com \
    --cc=jh80.chung@samsung.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.