From: Maxime Ripard <mripard@kernel.org> To: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Thomas Zimmermann <tzimmermann@suse.de>, Emma Anholt <emma@anholt.net> Cc: "Maíra Canal" <mairacanal@riseup.net>, "Javier Martinez Canillas" <javierm@redhat.com>, dri-devel@lists.freedesktop.org, "David Gow" <davidgow@google.com>, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, "Maxime Ripard" <mripard@kernel.org>, "Brendan Higgins" <brendan.higgins@linux.dev> Subject: [PATCH v3 04/11] drm/tests: probe-helper: Remove call to drm_kunit_helper_free_device() Date: Fri, 28 Jul 2023 11:06:17 +0200 [thread overview] Message-ID: <20230728-kms-kunit-actions-rework-v3-4-952565ccccfe@kernel.org> (raw) In-Reply-To: <20230728-kms-kunit-actions-rework-v3-0-952565ccccfe@kernel.org> Calling drm_kunit_helper_free_device() to clean up the resources allocated by drm_kunit_helper_alloc_device() is now optional and not needed in most cases. Remove it. Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Maíra Canal <mairacanal@riseup.net> Signed-off-by: Maxime Ripard <mripard@kernel.org> --- drivers/gpu/drm/tests/drm_probe_helper_test.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/tests/drm_probe_helper_test.c b/drivers/gpu/drm/tests/drm_probe_helper_test.c index 0ee65828623e..1a2044070a6c 100644 --- a/drivers/gpu/drm/tests/drm_probe_helper_test.c +++ b/drivers/gpu/drm/tests/drm_probe_helper_test.c @@ -60,13 +60,6 @@ static int drm_probe_helper_test_init(struct kunit *test) return 0; } -static void drm_probe_helper_test_exit(struct kunit *test) -{ - struct drm_probe_helper_test_priv *priv = test->priv; - - drm_kunit_helper_free_device(test, priv->dev); -} - typedef struct drm_display_mode *(*expected_mode_func_t)(struct drm_device *); struct drm_connector_helper_tv_get_modes_test { @@ -208,7 +201,6 @@ static struct kunit_case drm_test_connector_helper_tv_get_modes_tests[] = { static struct kunit_suite drm_test_connector_helper_tv_get_modes_suite = { .name = "drm_connector_helper_tv_get_modes", .init = drm_probe_helper_test_init, - .exit = drm_probe_helper_test_exit, .test_cases = drm_test_connector_helper_tv_get_modes_tests, }; -- 2.41.0
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <mripard@kernel.org> To: David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Thomas Zimmermann <tzimmermann@suse.de>, Emma Anholt <emma@anholt.net> Cc: linux-kselftest@vger.kernel.org, "Brendan Higgins" <brendan.higgins@linux.dev>, "Javier Martinez Canillas" <javierm@redhat.com>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Maíra Canal" <mairacanal@riseup.net>, "Maxime Ripard" <mripard@kernel.org>, "David Gow" <davidgow@google.com>, kunit-dev@googlegroups.com Subject: [PATCH v3 04/11] drm/tests: probe-helper: Remove call to drm_kunit_helper_free_device() Date: Fri, 28 Jul 2023 11:06:17 +0200 [thread overview] Message-ID: <20230728-kms-kunit-actions-rework-v3-4-952565ccccfe@kernel.org> (raw) In-Reply-To: <20230728-kms-kunit-actions-rework-v3-0-952565ccccfe@kernel.org> Calling drm_kunit_helper_free_device() to clean up the resources allocated by drm_kunit_helper_alloc_device() is now optional and not needed in most cases. Remove it. Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Maíra Canal <mairacanal@riseup.net> Signed-off-by: Maxime Ripard <mripard@kernel.org> --- drivers/gpu/drm/tests/drm_probe_helper_test.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/tests/drm_probe_helper_test.c b/drivers/gpu/drm/tests/drm_probe_helper_test.c index 0ee65828623e..1a2044070a6c 100644 --- a/drivers/gpu/drm/tests/drm_probe_helper_test.c +++ b/drivers/gpu/drm/tests/drm_probe_helper_test.c @@ -60,13 +60,6 @@ static int drm_probe_helper_test_init(struct kunit *test) return 0; } -static void drm_probe_helper_test_exit(struct kunit *test) -{ - struct drm_probe_helper_test_priv *priv = test->priv; - - drm_kunit_helper_free_device(test, priv->dev); -} - typedef struct drm_display_mode *(*expected_mode_func_t)(struct drm_device *); struct drm_connector_helper_tv_get_modes_test { @@ -208,7 +201,6 @@ static struct kunit_case drm_test_connector_helper_tv_get_modes_tests[] = { static struct kunit_suite drm_test_connector_helper_tv_get_modes_suite = { .name = "drm_connector_helper_tv_get_modes", .init = drm_probe_helper_test_init, - .exit = drm_probe_helper_test_exit, .test_cases = drm_test_connector_helper_tv_get_modes_tests, }; -- 2.41.0
next prev parent reply other threads:[~2023-07-28 9:07 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-07-28 9:06 [PATCH v3 00/11] drm: kunit: Switch to kunit actions Maxime Ripard 2023-07-28 9:06 ` Maxime Ripard 2023-07-28 9:06 ` [PATCH v3 01/11] drm/tests: helpers: " Maxime Ripard 2023-07-28 9:06 ` Maxime Ripard 2023-07-28 9:06 ` [PATCH v3 02/11] drm/tests: client-modeset: Remove call to drm_kunit_helper_free_device() Maxime Ripard 2023-07-28 9:06 ` Maxime Ripard 2023-07-28 9:06 ` [PATCH v3 03/11] drm/tests: modes: " Maxime Ripard 2023-07-28 9:06 ` Maxime Ripard 2023-07-28 9:06 ` Maxime Ripard [this message] 2023-07-28 9:06 ` [PATCH v3 04/11] drm/tests: probe-helper: " Maxime Ripard 2023-07-28 9:06 ` [PATCH v3 05/11] drm/tests: helpers: Create a helper to allocate a locking ctx Maxime Ripard 2023-07-28 9:06 ` Maxime Ripard 2023-07-28 9:06 ` [PATCH v3 06/11] drm/tests: helpers: Create a helper to allocate an atomic state Maxime Ripard 2023-07-28 9:06 ` Maxime Ripard 2023-07-28 9:06 ` [PATCH v3 07/11] drm/vc4: tests: pv-muxing: Remove call to drm_kunit_helper_free_device() Maxime Ripard 2023-07-28 9:06 ` Maxime Ripard 2023-07-28 9:06 ` [PATCH v3 08/11] drm/vc4: tests: mock: Use a kunit action to unregister DRM device Maxime Ripard 2023-07-28 9:06 ` Maxime Ripard 2023-07-28 9:06 ` [PATCH v3 09/11] drm/vc4: tests: pv-muxing: Switch to managed locking init Maxime Ripard 2023-07-28 9:06 ` Maxime Ripard 2023-07-28 9:06 ` [PATCH v3 10/11] drm/vc4: tests: Switch to atomic state allocation helper Maxime Ripard 2023-07-28 9:06 ` Maxime Ripard 2023-07-28 9:06 ` [PATCH v3 11/11] drm/vc4: tests: pv-muxing: Document test scenario Maxime Ripard 2023-07-28 9:06 ` Maxime Ripard 2023-07-31 12:23 ` [PATCH v3 00/11] drm: kunit: Switch to kunit actions Maxime Ripard 2023-07-31 12:23 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230728-kms-kunit-actions-rework-v3-4-952565ccccfe@kernel.org \ --to=mripard@kernel.org \ --cc=airlied@gmail.com \ --cc=brendan.higgins@linux.dev \ --cc=daniel@ffwll.ch \ --cc=davidgow@google.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=emma@anholt.net \ --cc=javierm@redhat.com \ --cc=kunit-dev@googlegroups.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mairacanal@riseup.net \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.