All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ayush Jain <ayush.jain3@amd.com>
To: <akpm@linux-foundation.org>, <shuah@kernel.org>,
	<pasha.tatashin@soleen.com>, <zhansayabagdaulet@gmail.com>,
	<tyhicks@linux.microsoft.com>, <shr@devkernel.io>,
	<raghavendra.kt@amd.com>
Cc: <linux-mm@kvack.org>, <linux-kselftest@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <Narasimhan.V@amd.com>,
	<Santosh.Shukla@amd.com>, Ayush Jain <ayush.jain3@amd.com>,
	David Hildenbrand <david@redhat.com>
Subject: [PATCH v2 1/2] selftests: mm: ksm: Fix incorrect evaluation of parameter
Date: Fri, 28 Jul 2023 22:09:51 +0530	[thread overview]
Message-ID: <20230728163952.4634-1-ayush.jain3@amd.com> (raw)

A missing break in kms_tests leads to kselftest hang when the
parameter -s is used.
In current code flow because of missing break in -s, -t parses
args spilled from -s and as -t accepts only valid values as 0,1
so any arg in -s >1 or <0, gets in ksm_test failure

This went undetected since, before the addition of option -t,
the next case -M would immediately break out of the switch
statement but that is no longer the case

Add the missing break statement.

----Before----
./ksm_tests -H -s 100
Invalid merge type

----After----
./ksm_tests -H -s 100
Number of normal pages:    0
Number of huge pages:    50
Total size:    100 MiB
Total time:    0.401732682 s
Average speed:  248.922 MiB/s

Fixes: 07115fcc15b4 ("selftests/mm: add new selftests for KSM")

Signed-off-by: Ayush Jain <ayush.jain3@amd.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
---
v1 -> v2
collect Reviewed-by from David
Updated Fixes tag from commit 9e7cb94ca218 to 07115fcc15b4

 tools/testing/selftests/mm/ksm_tests.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/mm/ksm_tests.c b/tools/testing/selftests/mm/ksm_tests.c
index 435acebdc325..380b691d3eb9 100644
--- a/tools/testing/selftests/mm/ksm_tests.c
+++ b/tools/testing/selftests/mm/ksm_tests.c
@@ -831,6 +831,7 @@ int main(int argc, char *argv[])
 				printf("Size must be greater than 0\n");
 				return KSFT_FAIL;
 			}
+			break;
 		case 't':
 			{
 				int tmp = atoi(optarg);
-- 
2.34.1


             reply	other threads:[~2023-07-28 16:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-28 16:39 Ayush Jain [this message]
2023-07-28 17:19 ` [PATCH v2 2/2] selftests: mm: add KSM_MERGE_TIME tests Ayush Jain
2023-08-08 17:31 ` [PATCH v2 1/2] selftests: mm: ksm: Fix incorrect evaluation of parameter Stefan Roesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230728163952.4634-1-ayush.jain3@amd.com \
    --to=ayush.jain3@amd.com \
    --cc=Narasimhan.V@amd.com \
    --cc=Santosh.Shukla@amd.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=raghavendra.kt@amd.com \
    --cc=shr@devkernel.io \
    --cc=shuah@kernel.org \
    --cc=tyhicks@linux.microsoft.com \
    --cc=zhansayabagdaulet@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.