All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Jiahao <chenjiahao16@huawei.com>
To: <rafael@kernel.org>, <daniel.lezcano@linaro.org>,
	<amitk@kernel.org>, <rui.zhang@intel.com>,
	<matthias.bgg@gmail.com>,
	<angelogioacchino.delregno@collabora.com>,
	<aouledameur@baylibre.com>, <void0red@hust.edu.cn>,
	<robh@kernel.org>, <daniel@makrotopia.org>,
	<linux-pm@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>
Cc: <chenjiahao16@huawei.com>
Subject: [PATCH -next] thermal/drivers/mediatek: Remove repeating warn msg after devm_thermal_add_hwmon_sysfs()
Date: Thu, 3 Aug 2023 09:23:41 +0800	[thread overview]
Message-ID: <20230803012341.2388831-1-chenjiahao16@huawei.com> (raw)

Referring to commit 8416ecfb32923 ("thermal/hwmon: Add error
information printing for devm_thermal_add_hwmon_sysfs()"),
return value has already been checked if ret != 0 in
devm_thermal_add_hwmon_sysfs(). Error handling has also been
performed in this case, including print warning message for
debugging.

Removing dev_warn() following devm_thermal_add_hwmon_sysfs()
to clean up redundant warning message.

Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>
---
 drivers/thermal/mediatek/auxadc_thermal.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/thermal/mediatek/auxadc_thermal.c b/drivers/thermal/mediatek/auxadc_thermal.c
index c537aed71017..7f8450c66646 100644
--- a/drivers/thermal/mediatek/auxadc_thermal.c
+++ b/drivers/thermal/mediatek/auxadc_thermal.c
@@ -1289,9 +1289,7 @@ static int mtk_thermal_probe(struct platform_device *pdev)
 	if (IS_ERR(tzdev))
 		return PTR_ERR(tzdev);
 
-	ret = devm_thermal_add_hwmon_sysfs(&pdev->dev, tzdev);
-	if (ret)
-		dev_warn(&pdev->dev, "error in thermal_add_hwmon_sysfs");
+	devm_thermal_add_hwmon_sysfs(&pdev->dev, tzdev);
 
 	return 0;
 }
-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Chen Jiahao <chenjiahao16@huawei.com>
To: <rafael@kernel.org>, <daniel.lezcano@linaro.org>,
	<amitk@kernel.org>, <rui.zhang@intel.com>,
	<matthias.bgg@gmail.com>,
	<angelogioacchino.delregno@collabora.com>,
	<aouledameur@baylibre.com>, <void0red@hust.edu.cn>,
	<robh@kernel.org>, <daniel@makrotopia.org>,
	<linux-pm@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>
Cc: <chenjiahao16@huawei.com>
Subject: [PATCH -next] thermal/drivers/mediatek: Remove repeating warn msg after devm_thermal_add_hwmon_sysfs()
Date: Thu, 3 Aug 2023 09:23:41 +0800	[thread overview]
Message-ID: <20230803012341.2388831-1-chenjiahao16@huawei.com> (raw)

Referring to commit 8416ecfb32923 ("thermal/hwmon: Add error
information printing for devm_thermal_add_hwmon_sysfs()"),
return value has already been checked if ret != 0 in
devm_thermal_add_hwmon_sysfs(). Error handling has also been
performed in this case, including print warning message for
debugging.

Removing dev_warn() following devm_thermal_add_hwmon_sysfs()
to clean up redundant warning message.

Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>
---
 drivers/thermal/mediatek/auxadc_thermal.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/thermal/mediatek/auxadc_thermal.c b/drivers/thermal/mediatek/auxadc_thermal.c
index c537aed71017..7f8450c66646 100644
--- a/drivers/thermal/mediatek/auxadc_thermal.c
+++ b/drivers/thermal/mediatek/auxadc_thermal.c
@@ -1289,9 +1289,7 @@ static int mtk_thermal_probe(struct platform_device *pdev)
 	if (IS_ERR(tzdev))
 		return PTR_ERR(tzdev);
 
-	ret = devm_thermal_add_hwmon_sysfs(&pdev->dev, tzdev);
-	if (ret)
-		dev_warn(&pdev->dev, "error in thermal_add_hwmon_sysfs");
+	devm_thermal_add_hwmon_sysfs(&pdev->dev, tzdev);
 
 	return 0;
 }
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2023-08-03  1:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-03  1:23 Chen Jiahao [this message]
2023-08-03  1:23 ` [PATCH -next] thermal/drivers/mediatek: Remove repeating warn msg after devm_thermal_add_hwmon_sysfs() Chen Jiahao
2023-08-04  4:22 ` Chen-Yu Tsai
2023-08-04  4:22   ` Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230803012341.2388831-1-chenjiahao16@huawei.com \
    --to=chenjiahao16@huawei.com \
    --cc=amitk@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=aouledameur@baylibre.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=daniel@makrotopia.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=void0red@hust.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.