All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ruan Jinjie <ruanjinjie@huawei.com>
To: <sylvester.nawrocki@gmail.com>, <mchehab@kernel.org>,
	<ezequiel@vanguardiasur.com.ar>, <p.zabel@pengutronix.de>,
	<linux-media@vger.kernel.org>,
	<linux-samsung-soc@vger.kernel.org>,
	<linux-rockchip@lists.infradead.org>
Cc: <ruanjinjie@huawei.com>
Subject: [PATCH -next 1/2] media: camif-core: Do not check for 0 return after calling platform_get_irq()
Date: Thu, 3 Aug 2023 10:46:44 +0800	[thread overview]
Message-ID: <20230803024645.2716057-2-ruanjinjie@huawei.com> (raw)
In-Reply-To: <20230803024645.2716057-1-ruanjinjie@huawei.com>

It is not possible for platform_get_irq() to return 0. Use the
return value from platform_get_irq().

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
---
 drivers/media/platform/samsung/s3c-camif/camif-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/samsung/s3c-camif/camif-core.c b/drivers/media/platform/samsung/s3c-camif/camif-core.c
index afe1fcc37354..e4529f666e20 100644
--- a/drivers/media/platform/samsung/s3c-camif/camif-core.c
+++ b/drivers/media/platform/samsung/s3c-camif/camif-core.c
@@ -381,8 +381,8 @@ static int camif_request_irqs(struct platform_device *pdev,
 		init_waitqueue_head(&vp->irq_queue);
 
 		irq = platform_get_irq(pdev, i);
-		if (irq <= 0)
-			return -ENXIO;
+		if (irq < 0)
+			return irq;
 
 		ret = devm_request_irq(&pdev->dev, irq, s3c_camif_irq_handler,
 				       0, dev_name(&pdev->dev), vp);
-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Ruan Jinjie <ruanjinjie@huawei.com>
To: <sylvester.nawrocki@gmail.com>, <mchehab@kernel.org>,
	<ezequiel@vanguardiasur.com.ar>, <p.zabel@pengutronix.de>,
	<linux-media@vger.kernel.org>,
	<linux-samsung-soc@vger.kernel.org>,
	<linux-rockchip@lists.infradead.org>
Cc: <ruanjinjie@huawei.com>
Subject: [PATCH -next 1/2] media: camif-core: Do not check for 0 return after calling platform_get_irq()
Date: Thu, 3 Aug 2023 10:46:44 +0800	[thread overview]
Message-ID: <20230803024645.2716057-2-ruanjinjie@huawei.com> (raw)
In-Reply-To: <20230803024645.2716057-1-ruanjinjie@huawei.com>

It is not possible for platform_get_irq() to return 0. Use the
return value from platform_get_irq().

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
---
 drivers/media/platform/samsung/s3c-camif/camif-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/samsung/s3c-camif/camif-core.c b/drivers/media/platform/samsung/s3c-camif/camif-core.c
index afe1fcc37354..e4529f666e20 100644
--- a/drivers/media/platform/samsung/s3c-camif/camif-core.c
+++ b/drivers/media/platform/samsung/s3c-camif/camif-core.c
@@ -381,8 +381,8 @@ static int camif_request_irqs(struct platform_device *pdev,
 		init_waitqueue_head(&vp->irq_queue);
 
 		irq = platform_get_irq(pdev, i);
-		if (irq <= 0)
-			return -ENXIO;
+		if (irq < 0)
+			return irq;
 
 		ret = devm_request_irq(&pdev->dev, irq, s3c_camif_irq_handler,
 				       0, dev_name(&pdev->dev), vp);
-- 
2.34.1


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2023-08-03  2:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-03  2:46 [PATCH -next 0/2] media: platform: Do not check for 0 return after calling platform_get_irq() Ruan Jinjie
2023-08-03  2:46 ` Ruan Jinjie
2023-08-03  2:46 ` Ruan Jinjie [this message]
2023-08-03  2:46   ` [PATCH -next 1/2] media: camif-core: " Ruan Jinjie
2023-08-03  6:39   ` Andrzej Pietrasiewicz
2023-08-03  6:39     ` Andrzej Pietrasiewicz
2023-08-05 21:40   ` Andi Shyti
2023-08-05 21:40     ` Andi Shyti
2023-08-03  2:46 ` [PATCH -next 2/2] media: verisilicon: " Ruan Jinjie
2023-08-03  2:46   ` Ruan Jinjie
2023-08-03  6:38   ` Andrzej Pietrasiewicz
2023-08-03  6:38     ` Andrzej Pietrasiewicz
2023-08-05 21:42   ` Andi Shyti
2023-08-05 21:42     ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230803024645.2716057-2-ruanjinjie@huawei.com \
    --to=ruanjinjie@huawei.com \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=sylvester.nawrocki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.