From: "Christian Göttsche" <cgzones@googlemail.com>
To: selinux@vger.kernel.org
Cc: Paul Moore <paul@paul-moore.com>,
Stephen Smalley <stephen.smalley.work@gmail.com>,
Eric Paris <eparis@parisplace.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2] selinux: optimize ebitmap_and()
Date: Thu, 3 Aug 2023 19:11:58 +0200 [thread overview]
Message-ID: <20230803171158.486111-1-cgzones@googlemail.com> (raw)
Iterate on nodes instead of single bits to save node resolution for each
single bit.
Similar to userspace patch efcd00814879 ("libsepol: optimize
ebitmap_and").
Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
---
v2:
fix array size computation
---
security/selinux/ss/ebitmap.c | 48 ++++++++++++++++++++++++++++++-----
1 file changed, 41 insertions(+), 7 deletions(-)
diff --git a/security/selinux/ss/ebitmap.c b/security/selinux/ss/ebitmap.c
index 77875ad355f7..653de257d70d 100644
--- a/security/selinux/ss/ebitmap.c
+++ b/security/selinux/ss/ebitmap.c
@@ -81,18 +81,52 @@ int ebitmap_cpy(struct ebitmap *dst, const struct ebitmap *src)
int ebitmap_and(struct ebitmap *dst, const struct ebitmap *e1, const struct ebitmap *e2)
{
- struct ebitmap_node *n;
- int bit, rc;
+ const struct ebitmap_node *n1, *n2;
+ struct ebitmap_node *new = NULL, **prev;
ebitmap_init(dst);
- ebitmap_for_each_positive_bit(e1, n, bit) {
- if (ebitmap_get_bit(e2, bit)) {
- rc = ebitmap_set_bit(dst, bit, 1);
- if (rc < 0)
- return rc;
+ prev = &dst->node;
+ n1 = e1->node;
+ n2 = e2->node;
+ while (n1 && n2) {
+ if (n1->startbit == n2->startbit) {
+ unsigned long testmap[EBITMAP_UNIT_NUMS];
+ unsigned int i;
+ bool match = false;
+
+ for (i = 0; i < ARRAY_SIZE(testmap); i++) {
+ testmap[i] = n1->maps[i] & n2->maps[i];
+ if (testmap[i] != 0)
+ match = true;
+ }
+
+ if (match) {
+ new = kmem_cache_zalloc(ebitmap_node_cachep, GFP_ATOMIC);
+ if (!new) {
+ ebitmap_destroy(dst);
+ return -ENOMEM;
+ }
+ new->startbit = n1->startbit;
+ memcpy(new->maps, testmap, EBITMAP_SIZE / 8);
+ new->next = NULL;
+
+ *prev = new;
+ prev = &(new->next);
+ }
+
+ n1 = n1->next;
+ n2 = n2->next;
+ } else if (n1->startbit > n2->startbit) {
+ n2 = n2->next;
+ } else {
+ n1 = n1->next;
}
}
+
+ if (new)
+ dst->highbit = new->startbit + EBITMAP_SIZE;
+
return 0;
}
--
2.40.1
reply other threads:[~2023-08-03 17:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230803171158.486111-1-cgzones@googlemail.com \
--to=cgzones@googlemail.com \
--cc=eparis@parisplace.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.