All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiu Jianfeng <xiujianfeng@huaweicloud.com>
To: paul@paul-moore.com, stephen.smalley.work@gmail.com,
	eparis@parisplace.org
Cc: selinux@vger.kernel.org, xiujianfeng@huawei.com
Subject: [PATCH -next] selinux: update comment on selinux_hooks[]
Date: Fri,  4 Aug 2023 03:46:52 +0000	[thread overview]
Message-ID: <20230804034652.281266-1-xiujianfeng@huaweicloud.com> (raw)

From: Xiu Jianfeng <xiujianfeng@huawei.com>

After commit f22f9aaf6c3d ("selinux: remove the runtime disable
functionality"), the comment on selinux_hooks[] is out-of-date,
remove the last paragraph about runtime disable functionality.

Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
---
 security/selinux/hooks.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 2906fdaf7371..d0da19add17e 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -6961,10 +6961,6 @@ static int selinux_uring_cmd(struct io_uring_cmd *ioucmd)
  *    hooks ("allocating" hooks).
  *
  * Please follow block comment delimiters in the list to keep this order.
- *
- * This ordering is needed for SELinux runtime disable to work at least somewhat
- * safely. Breaking the ordering rules above might lead to NULL pointer derefs
- * when disabling SELinux at runtime.
  */
 static struct security_hook_list selinux_hooks[] __ro_after_init = {
 	LSM_HOOK_INIT(binder_set_context_mgr, selinux_binder_set_context_mgr),
-- 
2.34.1


             reply	other threads:[~2023-08-04  3:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-04  3:46 Xiu Jianfeng [this message]
2023-08-08 17:28 ` [PATCH] selinux: update comment on selinux_hooks[] Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230804034652.281266-1-xiujianfeng@huaweicloud.com \
    --to=xiujianfeng@huaweicloud.com \
    --cc=eparis@parisplace.org \
    --cc=paul@paul-moore.com \
    --cc=selinux@vger.kernel.org \
    --cc=stephen.smalley.work@gmail.com \
    --cc=xiujianfeng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.