From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Tomasz Figa <tomasz.figa@gmail.com>, Chanwoo Choi <cw00.choi@samsung.com>, Alim Akhtar <alim.akhtar@samsung.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 02/11] clk: samsung: exynos4: do not define number of clocks in bindings Date: Tue, 8 Aug 2023 10:27:29 +0200 [thread overview] Message-ID: <20230808082738.122804-3-krzysztof.kozlowski@linaro.org> (raw) In-Reply-To: <20230808082738.122804-1-krzysztof.kozlowski@linaro.org> Number of clocks supported by Linux drivers might vary - sometimes we add new clocks, not exposed previously. Therefore this number of clocks should not be in the bindings, because otherwise we should not change it. Define number of clocks per each clock controller inside the driver directly. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/clk/samsung/clk-exynos4.c | 5 ++++- drivers/clk/samsung/clk-exynos4412-isp.c | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/clk/samsung/clk-exynos4.c b/drivers/clk/samsung/clk-exynos4.c index 43207257a9cc..4ec41221e68f 100644 --- a/drivers/clk/samsung/clk-exynos4.c +++ b/drivers/clk/samsung/clk-exynos4.c @@ -135,6 +135,9 @@ #define PWR_CTRL1_USE_CORE1_WFI (1 << 1) #define PWR_CTRL1_USE_CORE0_WFI (1 << 0) +/* NOTE: Must be equal to the last clock ID increased by one */ +#define CLKS_NR (CLK_DIV_CORE2 + 1) + /* the exynos4 soc type */ enum exynos4_soc { EXYNOS4210, @@ -1275,7 +1278,7 @@ static void __init exynos4_clk_init(struct device_node *np, if (!reg_base) panic("%s: failed to map registers\n", __func__); - ctx = samsung_clk_init(NULL, reg_base, CLK_NR_CLKS); + ctx = samsung_clk_init(NULL, reg_base, CLKS_NR); hws = ctx->clk_data.hws; samsung_clk_of_register_fixed_ext(ctx, exynos4_fixed_rate_ext_clks, diff --git a/drivers/clk/samsung/clk-exynos4412-isp.c b/drivers/clk/samsung/clk-exynos4412-isp.c index 1470c15e95da..a70c2b06a61a 100644 --- a/drivers/clk/samsung/clk-exynos4412-isp.c +++ b/drivers/clk/samsung/clk-exynos4412-isp.c @@ -22,6 +22,9 @@ #define E4X12_GATE_ISP0 0x0800 #define E4X12_GATE_ISP1 0x0804 +/* NOTE: Must be equal to the last clock ID increased by one */ +#define CLKS_NR_ISP (CLK_ISP_DIV_MCUISP1 + 1) + /* * Support for CMU save/restore across system suspends */ @@ -121,7 +124,7 @@ static int __init exynos4x12_isp_clk_probe(struct platform_device *pdev) if (!exynos4x12_save_isp) return -ENOMEM; - ctx = samsung_clk_init(dev, reg_base, CLK_NR_ISP_CLKS); + ctx = samsung_clk_init(dev, reg_base, CLKS_NR_ISP); platform_set_drvdata(pdev, ctx); -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Tomasz Figa <tomasz.figa@gmail.com>, Chanwoo Choi <cw00.choi@samsung.com>, Alim Akhtar <alim.akhtar@samsung.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 02/11] clk: samsung: exynos4: do not define number of clocks in bindings Date: Tue, 8 Aug 2023 10:27:29 +0200 [thread overview] Message-ID: <20230808082738.122804-3-krzysztof.kozlowski@linaro.org> (raw) In-Reply-To: <20230808082738.122804-1-krzysztof.kozlowski@linaro.org> Number of clocks supported by Linux drivers might vary - sometimes we add new clocks, not exposed previously. Therefore this number of clocks should not be in the bindings, because otherwise we should not change it. Define number of clocks per each clock controller inside the driver directly. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/clk/samsung/clk-exynos4.c | 5 ++++- drivers/clk/samsung/clk-exynos4412-isp.c | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/clk/samsung/clk-exynos4.c b/drivers/clk/samsung/clk-exynos4.c index 43207257a9cc..4ec41221e68f 100644 --- a/drivers/clk/samsung/clk-exynos4.c +++ b/drivers/clk/samsung/clk-exynos4.c @@ -135,6 +135,9 @@ #define PWR_CTRL1_USE_CORE1_WFI (1 << 1) #define PWR_CTRL1_USE_CORE0_WFI (1 << 0) +/* NOTE: Must be equal to the last clock ID increased by one */ +#define CLKS_NR (CLK_DIV_CORE2 + 1) + /* the exynos4 soc type */ enum exynos4_soc { EXYNOS4210, @@ -1275,7 +1278,7 @@ static void __init exynos4_clk_init(struct device_node *np, if (!reg_base) panic("%s: failed to map registers\n", __func__); - ctx = samsung_clk_init(NULL, reg_base, CLK_NR_CLKS); + ctx = samsung_clk_init(NULL, reg_base, CLKS_NR); hws = ctx->clk_data.hws; samsung_clk_of_register_fixed_ext(ctx, exynos4_fixed_rate_ext_clks, diff --git a/drivers/clk/samsung/clk-exynos4412-isp.c b/drivers/clk/samsung/clk-exynos4412-isp.c index 1470c15e95da..a70c2b06a61a 100644 --- a/drivers/clk/samsung/clk-exynos4412-isp.c +++ b/drivers/clk/samsung/clk-exynos4412-isp.c @@ -22,6 +22,9 @@ #define E4X12_GATE_ISP0 0x0800 #define E4X12_GATE_ISP1 0x0804 +/* NOTE: Must be equal to the last clock ID increased by one */ +#define CLKS_NR_ISP (CLK_ISP_DIV_MCUISP1 + 1) + /* * Support for CMU save/restore across system suspends */ @@ -121,7 +124,7 @@ static int __init exynos4x12_isp_clk_probe(struct platform_device *pdev) if (!exynos4x12_save_isp) return -ENOMEM; - ctx = samsung_clk_init(dev, reg_base, CLK_NR_ISP_CLKS); + ctx = samsung_clk_init(dev, reg_base, CLKS_NR_ISP); platform_set_drvdata(pdev, ctx); -- 2.34.1
next prev parent reply other threads:[~2023-08-08 8:28 UTC|newest] Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-08 8:27 [PATCH 00/11] clk: samsung: remove number of clocks from bindings Krzysztof Kozlowski 2023-08-08 8:27 ` Krzysztof Kozlowski 2023-08-08 8:27 ` [PATCH 01/11] clk: samsung: exynos3250: do not define number of clocks in bindings Krzysztof Kozlowski 2023-08-08 8:27 ` Krzysztof Kozlowski 2023-08-10 11:06 ` Alim Akhtar 2023-08-10 11:06 ` Alim Akhtar 2023-08-08 8:27 ` Krzysztof Kozlowski [this message] 2023-08-08 8:27 ` [PATCH 02/11] clk: samsung: exynos4: " Krzysztof Kozlowski 2023-08-10 11:19 ` Alim Akhtar 2023-08-10 11:19 ` Alim Akhtar 2023-08-08 8:27 ` [PATCH 03/11] clk: samsung: exynos5250: " Krzysztof Kozlowski 2023-08-08 8:27 ` Krzysztof Kozlowski 2023-08-10 11:22 ` Alim Akhtar 2023-08-10 11:22 ` Alim Akhtar 2023-08-08 8:27 ` [PATCH 04/11] clk: samsung: exynos5260: " Krzysztof Kozlowski 2023-08-08 8:27 ` Krzysztof Kozlowski 2023-08-10 11:26 ` Alim Akhtar 2023-08-10 11:26 ` Alim Akhtar 2023-08-08 8:27 ` [PATCH 05/11] clk: samsung: exynos5410: " Krzysztof Kozlowski 2023-08-08 8:27 ` Krzysztof Kozlowski 2023-08-10 11:27 ` Alim Akhtar 2023-08-10 11:27 ` Alim Akhtar 2023-08-08 8:27 ` [PATCH 06/11] clk: samsung: exynos5420: " Krzysztof Kozlowski 2023-08-08 8:27 ` Krzysztof Kozlowski 2023-08-10 11:27 ` Alim Akhtar 2023-08-10 11:27 ` Alim Akhtar 2023-08-08 8:27 ` [PATCH 07/11] clk: samsung: exynos5433: " Krzysztof Kozlowski 2023-08-08 8:27 ` Krzysztof Kozlowski 2023-08-10 11:32 ` Alim Akhtar 2023-08-10 11:32 ` Alim Akhtar 2023-08-08 8:27 ` [PATCH 08/11] clk: samsung: exynos7885: " Krzysztof Kozlowski 2023-08-08 8:27 ` Krzysztof Kozlowski 2023-08-10 11:34 ` Alim Akhtar 2023-08-10 11:34 ` Alim Akhtar 2023-08-08 8:27 ` [PATCH 09/11] clk: samsung: exynos850: " Krzysztof Kozlowski 2023-08-08 8:27 ` Krzysztof Kozlowski 2023-08-08 17:15 ` Sam Protsenko 2023-08-08 17:15 ` Sam Protsenko 2023-08-10 11:36 ` Alim Akhtar 2023-08-10 11:36 ` Alim Akhtar 2023-08-08 8:27 ` [PATCH 10/11] clk: samsung: exynoautov9: " Krzysztof Kozlowski 2023-08-08 8:27 ` Krzysztof Kozlowski 2023-08-10 11:37 ` Alim Akhtar 2023-08-10 11:37 ` Alim Akhtar 2023-08-08 8:27 ` [PATCH 11/11] dt-bindings: clock: samsung: remove define with number of clocks Krzysztof Kozlowski 2023-08-08 8:27 ` Krzysztof Kozlowski 2023-08-08 10:53 ` Conor Dooley 2023-08-08 10:53 ` Conor Dooley 2023-08-08 10:56 ` Krzysztof Kozlowski 2023-08-08 10:56 ` Krzysztof Kozlowski 2023-08-08 17:17 ` Sam Protsenko 2023-08-08 17:17 ` Sam Protsenko 2023-08-10 11:39 ` Alim Akhtar 2023-08-10 11:39 ` Alim Akhtar 2023-08-10 13:38 ` [PATCH 00/11] clk: samsung: remove number of clocks from bindings Chanwoo Choi 2023-08-10 13:38 ` Chanwoo Choi 2023-08-15 5:52 ` Krzysztof Kozlowski 2023-08-15 5:52 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230808082738.122804-3-krzysztof.kozlowski@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=alim.akhtar@samsung.com \ --cc=conor+dt@kernel.org \ --cc=cw00.choi@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=robh+dt@kernel.org \ --cc=s.nawrocki@samsung.com \ --cc=sboyd@kernel.org \ --cc=tomasz.figa@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.