All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
	linux-nvme@lists.infradead.org,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org
Cc: linux-block@vger.kernel.org, Wen Xiong <wenxiong@linux.ibm.com>,
	Keith Busch <kbusch@kernel.org>, Ming Lei <ming.lei@redhat.com>
Subject: [PATCH V3 02/14] nvme-pci: use blk_mq_max_nr_hw_queues() to calculate io queues
Date: Tue,  8 Aug 2023 18:42:27 +0800	[thread overview]
Message-ID: <20230808104239.146085-3-ming.lei@redhat.com> (raw)
In-Reply-To: <20230808104239.146085-1-ming.lei@redhat.com>

Take blk-mq's knowledge into account for calculating io queues.

Fix wrong queue mapping in case of kdump kernel.

On arm and ppc64, 'maxcpus=1' is passed to kdump command line, see
`Documentation/admin-guide/kdump/kdump.rst`, so num_possible_cpus()
still returns all CPUs because 'maxcpus=1' just bring up one single
cpu core during booting.

blk-mq sees single queue in kdump kernel, and in driver's viewpoint
there are still multiple queues, this inconsistency causes driver to apply
wrong queue mapping for handling IO, and IO timeout is triggered.

Meantime, single queue makes much less resource utilization, and reduce
risk of kernel failure.

Reported-by: Wen Xiong <wenxiong@linux.ibm.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
 drivers/nvme/host/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index baf69af7ea78..a1227ae7eb39 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2251,7 +2251,7 @@ static unsigned int nvme_max_io_queues(struct nvme_dev *dev)
 	 */
 	if (dev->ctrl.quirks & NVME_QUIRK_SHARED_TAGS)
 		return 1;
-	return num_possible_cpus() + dev->nr_write_queues + dev->nr_poll_queues;
+	return blk_mq_max_nr_hw_queues() + dev->nr_write_queues + dev->nr_poll_queues;
 }
 
 static int nvme_setup_io_queues(struct nvme_dev *dev)
-- 
2.40.1


  parent reply	other threads:[~2023-08-08 16:11 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 10:42 [PATCH V3 0/14] blk-mq: fix wrong queue mapping for kdump kernel Ming Lei
2023-08-08 10:42 ` [PATCH V3 01/14] blk-mq: add blk_mq_max_nr_hw_queues() Ming Lei
2023-08-09 13:44   ` Christoph Hellwig
2023-08-10  0:09     ` Ming Lei
2023-08-10  0:09       ` Ming Lei
2023-08-10  0:09       ` Ming Lei
2023-08-10  1:18       ` Baoquan He
2023-08-10  1:18         ` Baoquan He
2023-08-10  1:18         ` Baoquan He
2023-08-10  2:06         ` Ming Lei
2023-08-10  2:06           ` Ming Lei
2023-08-10  2:06           ` Ming Lei
2023-08-10  3:01           ` Baoquan He
2023-08-10  3:01             ` Baoquan He
2023-08-10  3:01             ` Baoquan He
2023-08-11  7:53             ` Hari Bathini
2023-08-11  7:53               ` Hari Bathini
2023-08-11  7:53               ` Hari Bathini
2023-09-05  5:03               ` Baoquan He
2023-09-05  5:03                 ` Baoquan He
2023-09-05  5:03                 ` Baoquan He
2023-08-11 13:10       ` Christoph Hellwig
2023-08-11 13:10         ` Christoph Hellwig
2023-08-11 13:10         ` Christoph Hellwig
2023-08-08 10:42 ` Ming Lei [this message]
2023-08-08 10:42 ` [PATCH V3 03/14] ublk: limit max allowed nr_hw_queues Ming Lei
2023-08-08 10:42 ` [PATCH V3 04/14] virtio-blk: limit max allowed submit queues Ming Lei
2023-08-08 10:42   ` Ming Lei
2023-08-10 19:23   ` Michael S. Tsirkin
2023-08-10 19:23     ` Michael S. Tsirkin
2023-08-08 10:42 ` [PATCH V3 05/14] scsi: core: add helper of scsi_max_nr_hw_queues() Ming Lei
2023-08-08 10:42 ` [PATCH V3 06/14] scsi: lpfc: use blk_mq_max_nr_hw_queues() to calculate io vectors Ming Lei
2023-08-08 10:42 ` [PATCH V3 07/14] scsi: mpi3mr: take blk_mq_max_nr_hw_queues() into account for calculating " Ming Lei
2023-08-08 10:42 ` [PATCH V3 08/14] scsi: megaraid: " Ming Lei
2023-08-08 10:42 ` [PATCH V3 09/14] scsi: mpt3sas: " Ming Lei
2023-08-08 10:42 ` [PATCH V3 10/14] scsi: pm8001: " Ming Lei
2023-08-08 10:42 ` [PATCH V3 11/14] scsi: hisi: " Ming Lei
2023-08-08 10:42 ` [PATCH V3 12/14] scsi: ufs: limit max allowed nr_hw_queues Ming Lei
2023-08-08 10:42 ` [PATCH V3 13/14] scsi: storvsc: " Ming Lei
2023-08-08 10:42 ` [PATCH V3 14/14] blk-mq: add helpers for treating kdump kernel Ming Lei
2023-08-10  8:00   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230808104239.146085-3-ming.lei@redhat.com \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=wenxiong@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.