All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: <brendan.higgins@linux.dev>, <davidgow@google.com>, <rmoar@google.com>
Cc: <linux-kselftest@vger.kernel.org>, <kunit-dev@googlegroups.com>,
	<linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>,
	Richard Fitzgerald <rf@opensource.cirrus.com>
Subject: [PATCH v2 5/6] kunit: kunit-test: Add test of logging only a newline
Date: Tue, 8 Aug 2023 13:35:28 +0100	[thread overview]
Message-ID: <20230808123529.4725-6-rf@opensource.cirrus.com> (raw)
In-Reply-To: <20230808123529.4725-1-rf@opensource.cirrus.com>

Add a test that logging a string containing only a newline appends
one newline to the log.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
---
 lib/kunit/kunit-test.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/lib/kunit/kunit-test.c b/lib/kunit/kunit-test.c
index 621acdb5385e..ce80fb42128c 100644
--- a/lib/kunit/kunit-test.c
+++ b/lib/kunit/kunit-test.c
@@ -613,6 +613,12 @@ static void kunit_log_newline_test(struct kunit *test)
 		kunit_init_log_frag(frag);
 		list_add_tail(&frag->list, suite.log);
 
+		/* Log only a newline */
+		kunit_log_append(suite.log, "\n");
+		KUNIT_EXPECT_TRUE(test, list_is_singular(suite.log));
+		KUNIT_EXPECT_STREQ(test, frag->buf, "\n");
+		frag->buf[0] = '\0';
+
 		/* String that exactly fills fragment leaving no room for \n */
 		memset(frag->buf, 0, sizeof(frag->buf));
 		memset(frag->buf, 'x', sizeof(frag->buf) - 9);
-- 
2.30.2


  parent reply	other threads:[~2023-08-08 16:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 12:35 [PATCH v2 0/6] kunit: Add dynamically-extending log Richard Fitzgerald
2023-08-08 12:35 ` [PATCH v2 1/6] kunit: Replace fixed-size log with dynamically-extending buffer Richard Fitzgerald
2023-08-09 12:11   ` David Gow
2023-08-09 14:37     ` Richard Fitzgerald
2023-08-08 12:35 ` [PATCH v2 2/6] kunit: kunit-test: Add test cases for extending log buffer Richard Fitzgerald
2023-08-08 21:16   ` Rae Moar
2023-08-09  9:39     ` Richard Fitzgerald
2023-08-09 12:11       ` David Gow
2023-08-09 12:14         ` Richard Fitzgerald
2023-08-08 12:35 ` [PATCH v2 3/6] kunit: Handle logging of lines longer than the fragment buffer size Richard Fitzgerald
2023-08-08 12:35 ` [PATCH v2 4/6] kunit: kunit-test: Add test cases for logging very long lines Richard Fitzgerald
2023-08-08 12:35 ` Richard Fitzgerald [this message]
2023-08-08 12:35 ` [PATCH v2 6/6] kunit: Don't waste first attempt to format string in kunit_log_append() Richard Fitzgerald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230808123529.4725-6-rf@opensource.cirrus.com \
    --to=rf@opensource.cirrus.com \
    --cc=brendan.higgins@linux.dev \
    --cc=davidgow@google.com \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=rmoar@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.