[PATCH 03/16] mmc: sdhci-brcmstb: Use sdhci_pltfm_remove()

From: Adrian Hunter <adrian.hunter@intel.com>
To: "Ulf Hansson" <ulf.hansson@linaro.org>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Yangtao Li" <frank.li@vivo.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
	Al Cooper <alcooperx@gmail.com>, Li Zetao <lizetao1@huawei.com>,
	Brad Larson <blarson@amd.com>,
	Swati Agarwal <swati.agarwal@amd.com>,
	linux-kernel@vger.kernel.org,
	Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>,
	Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Steen Hegelund <Steen.Hegelund@microchip.com>,
	Brian Norris <briannorris@chromium.org>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	linux-arm-kernel@lists.infradead.org,
	Ye Xingchen <ye.xingchen@zte.com.cn>,
	Patrice Chotard <patrice.chotard@foss.st.com>,
	Kamal Dasu <kamal.dasu@broadcom.com>,
	Doug Brown <doug@schmorgal.com>,
	Daniel Machon <daniel.machon@microchip.com>,
	Ray Jui <rjui@broadcom.com>,
	Eugen Hristev <eugen.hristev@collabora.com>,
	Jassi Brar <jaswinder.singh@linaro.org>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Georgii Kruglov <georgy.kruglov@yandex.ru>,
	Michal Simek <michal.simek@amd.com>,
	Lars Povlsen <lars.povlsen@microchip.com>,
	Andy Tang <andy.tang@nxp.com>,
	Scott Branden <sbranden@broadcom.com>,
	linux-mmc@vger.kernel.org, UNGLinuxDriver@microchip.com,
	Claudiu Beznea <claudiu.beznea@microchip.com>
Subject: [PATCH 03/16] mmc: sdhci-brcmstb: Use sdhci_pltfm_remove()
Date: Fri, 11 Aug 2023 16:03:38 +0300	[thread overview]
Message-ID: <20230811130351.7038-4-adrian.hunter@intel.com> (raw)
In-Reply-To: <20230811130351.7038-1-adrian.hunter@intel.com>

Use sdhci_pltfm_remove() instead of sdhci_pltfm_unregister() so that
devm_clk_get_optional_enabled() can be used for pltfm_host->clk.

This has the side effect that the order of operations on the error path
and remove path is not the same as it was before, but should be safe
nevertheless.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
 drivers/mmc/host/sdhci-brcmstb.c | 18 +++++-------------
 1 file changed, 5 insertions(+), 13 deletions(-)

diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
index a2b6d8f2eeb6..c23251bb95f3 100644
--- a/drivers/mmc/host/sdhci-brcmstb.c
+++ b/drivers/mmc/host/sdhci-brcmstb.c
@@ -264,23 +264,17 @@ static int sdhci_brcmstb_probe(struct platform_device *pdev)
 
 	dev_dbg(&pdev->dev, "Probe found match for %s\n",  match->compatible);
 
-	clk = devm_clk_get_optional(&pdev->dev, NULL);
+	clk = devm_clk_get_optional_enabled(&pdev->dev, NULL);
 	if (IS_ERR(clk))
 		return dev_err_probe(&pdev->dev, PTR_ERR(clk),
-				     "Failed to get clock from Device Tree\n");
-
-	res = clk_prepare_enable(clk);
-	if (res)
-		return res;
+				     "Failed to get and enable clock from Device Tree\n");
 
 	memset(&brcmstb_pdata, 0, sizeof(brcmstb_pdata));
 	brcmstb_pdata.ops = match_priv->ops;
 	host = sdhci_pltfm_init(pdev, &brcmstb_pdata,
 				sizeof(struct sdhci_brcmstb_priv));
-	if (IS_ERR(host)) {
-		res = PTR_ERR(host);
-		goto err_clk;
-	}
+	if (IS_ERR(host))
+		return PTR_ERR(host);
 
 	pltfm_host = sdhci_priv(host);
 	priv = sdhci_pltfm_priv(pltfm_host);
@@ -369,9 +363,7 @@ static int sdhci_brcmstb_probe(struct platform_device *pdev)
 
 err:
 	sdhci_pltfm_free(pdev);
-err_clk:
 	clk_disable_unprepare(base_clk);
-	clk_disable_unprepare(clk);
 	return res;
 }
 
@@ -430,7 +422,7 @@ static struct platform_driver sdhci_brcmstb_driver = {
 		.of_match_table = of_match_ptr(sdhci_brcm_of_match),
 	},
 	.probe		= sdhci_brcmstb_probe,
-	.remove_new	= sdhci_pltfm_unregister,
+	.remove_new	= sdhci_pltfm_remove,
 	.shutdown	= sdhci_brcmstb_shutdown,
 };
 
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
