All of lore.kernel.org
 help / color / mirror / Atom feed
From: Biju Das <biju.das.jz@bp.renesas.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>, David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>
Cc: "Biju Das" <biju.das.jz@bp.renesas.com>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Jonas Karlman" <jonas@kwiboo.se>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>,
	"Javier Martinez Canillas" <javierm@redhat.com>,
	"Ahmad Fatoum" <a.fatoum@pengutronix.de>,
	"Rob Herring" <robh@kernel.org>,
	"Bogdan Togorean" <bogdan.togorean@analog.com>,
	"Adam Ford" <aford173@gmail.com>,
	dri-devel@lists.freedesktop.org,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	linux-renesas-soc@vger.kernel.org
Subject: [PATCH 6/7] drm: adv7511: Add link_config feature bit to struct adv7511_chip_info
Date: Sun, 13 Aug 2023 19:05:11 +0100	[thread overview]
Message-ID: <20230813180512.307418-7-biju.das.jz@bp.renesas.com> (raw)
In-Reply-To: <20230813180512.307418-1-biju.das.jz@bp.renesas.com>

The ADV7511 needs link configuration whereas ADV75{33,35} does not need
it. Add a feature bit link_config to struct adv7511_chip_info to handle
this difference.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/gpu/drm/bridge/adv7511/adv7511.h     | 1 +
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 7 ++++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h b/drivers/gpu/drm/bridge/adv7511/adv7511.h
index 2a017bb31a14..627531f48f84 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511.h
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h
@@ -340,6 +340,7 @@ struct adv7511_chip_info {
 	const char * const *supply_names;
 	unsigned int num_supplies;
 	unsigned has_dsi:1;
+	unsigned link_config:1;
 };
 
 struct adv7511 {
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index 66b3f8fcf67d..6974c267b1d5 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -1208,7 +1208,7 @@ static int adv7511_probe(struct i2c_client *i2c)
 
 	memset(&link_config, 0, sizeof(link_config));
 
-	if (adv7511->info->type == ADV7511)
+	if (info->link_config)
 		ret = adv7511_parse_dt(dev->of_node, &link_config);
 	else
 		ret = adv7533_parse_dt(dev->of_node, adv7511);
@@ -1297,7 +1297,7 @@ static int adv7511_probe(struct i2c_client *i2c)
 
 	i2c_set_clientdata(i2c, adv7511);
 
-	if (info->type == ADV7511)
+	if (info->link_config)
 		adv7511_set_link_config(adv7511, &link_config);
 
 	ret = adv7511_cec_init(dev, adv7511);
@@ -1362,7 +1362,8 @@ static void adv7511_remove(struct i2c_client *i2c)
 static const struct adv7511_chip_info adv7511_chip_info = {
 	.type = ADV7511,
 	.supply_names = adv7511_supply_names,
-	.num_supplies = ARRAY_SIZE(adv7511_supply_names)
+	.num_supplies = ARRAY_SIZE(adv7511_supply_names),
+	.link_config = 1
 };
 
 static const struct adv7511_chip_info adv7533_chip_info = {
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Biju Das <biju.das.jz@bp.renesas.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>, David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>
Cc: "Ahmad Fatoum" <a.fatoum@pengutronix.de>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Jonas Karlman" <jonas@kwiboo.se>,
	dri-devel@lists.freedesktop.org,
	"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Javier Martinez Canillas" <javierm@redhat.com>,
	linux-renesas-soc@vger.kernel.org,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Biju Das" <biju.das.jz@bp.renesas.com>,
	"Adam Ford" <aford173@gmail.com>,
	"Bogdan Togorean" <bogdan.togorean@analog.com>
Subject: [PATCH 6/7] drm: adv7511: Add link_config feature bit to struct adv7511_chip_info
Date: Sun, 13 Aug 2023 19:05:11 +0100	[thread overview]
Message-ID: <20230813180512.307418-7-biju.das.jz@bp.renesas.com> (raw)
In-Reply-To: <20230813180512.307418-1-biju.das.jz@bp.renesas.com>

The ADV7511 needs link configuration whereas ADV75{33,35} does not need
it. Add a feature bit link_config to struct adv7511_chip_info to handle
this difference.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/gpu/drm/bridge/adv7511/adv7511.h     | 1 +
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 7 ++++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h b/drivers/gpu/drm/bridge/adv7511/adv7511.h
index 2a017bb31a14..627531f48f84 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511.h
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h
@@ -340,6 +340,7 @@ struct adv7511_chip_info {
 	const char * const *supply_names;
 	unsigned int num_supplies;
 	unsigned has_dsi:1;
+	unsigned link_config:1;
 };
 
 struct adv7511 {
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index 66b3f8fcf67d..6974c267b1d5 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -1208,7 +1208,7 @@ static int adv7511_probe(struct i2c_client *i2c)
 
 	memset(&link_config, 0, sizeof(link_config));
 
-	if (adv7511->info->type == ADV7511)
+	if (info->link_config)
 		ret = adv7511_parse_dt(dev->of_node, &link_config);
 	else
 		ret = adv7533_parse_dt(dev->of_node, adv7511);
@@ -1297,7 +1297,7 @@ static int adv7511_probe(struct i2c_client *i2c)
 
 	i2c_set_clientdata(i2c, adv7511);
 
-	if (info->type == ADV7511)
+	if (info->link_config)
 		adv7511_set_link_config(adv7511, &link_config);
 
 	ret = adv7511_cec_init(dev, adv7511);
@@ -1362,7 +1362,8 @@ static void adv7511_remove(struct i2c_client *i2c)
 static const struct adv7511_chip_info adv7511_chip_info = {
 	.type = ADV7511,
 	.supply_names = adv7511_supply_names,
-	.num_supplies = ARRAY_SIZE(adv7511_supply_names)
+	.num_supplies = ARRAY_SIZE(adv7511_supply_names),
+	.link_config = 1
 };
 
 static const struct adv7511_chip_info adv7533_chip_info = {
-- 
2.25.1


  parent reply	other threads:[~2023-08-13 18:06 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-13 18:05 [PATCH 0/7] ADV7511 driver enhancements Biju Das
2023-08-13 18:05 ` Biju Das
2023-08-13 18:05 ` [PATCH 1/7] drm: adv7511: Add struct adv7511_chip_info and use i2c_get_match_data() Biju Das
2023-08-13 18:05   ` Biju Das
2023-08-18 14:49   ` Adam Ford
2023-08-18 14:49     ` Adam Ford
2023-08-29  7:22   ` Laurent Pinchart
2023-08-29  7:22     ` Laurent Pinchart
2023-08-29 14:00     ` Biju Das
2023-08-29 14:00       ` Biju Das
2023-08-13 18:05 ` [PATCH 2/7] drm: adv7511: Add max_mode_clock variable to struct adv7511_chip_info Biju Das
2023-08-13 18:05   ` Biju Das
2023-08-28 22:36   ` Adam Ford
2023-08-28 22:36     ` Adam Ford
2023-08-29  7:23   ` Laurent Pinchart
2023-08-29  7:23     ` Laurent Pinchart
2023-08-29 14:01     ` Biju Das
2023-08-29 14:01       ` Biju Das
2023-08-13 18:05 ` [PATCH 3/7] drm: adv7511: Add max_lane_freq " Biju Das
2023-08-13 18:05   ` Biju Das
2023-08-29  7:25   ` Laurent Pinchart
2023-08-29  7:25     ` Laurent Pinchart
2023-08-29 14:05     ` Biju Das
2023-08-29 14:05       ` Biju Das
2023-08-13 18:05 ` [PATCH 4/7] drm: adv7511: Add supply_names and num_supplies variables " Biju Das
2023-08-13 18:05   ` Biju Das
2023-08-29  7:26   ` Laurent Pinchart
2023-08-29  7:26     ` Laurent Pinchart
2023-08-29 14:06     ` Biju Das
2023-08-29 14:06       ` Biju Das
2023-08-13 18:05 ` [PATCH 5/7] drm: adv7511: Add has_dsi feature bit " Biju Das
2023-08-13 18:05   ` Biju Das
2023-08-29  7:30   ` Laurent Pinchart
2023-08-29  7:30     ` Laurent Pinchart
2023-08-29 14:19     ` Biju Das
2023-08-29 14:19       ` Biju Das
2023-08-29 15:35       ` Laurent Pinchart
2023-08-29 15:35         ` Laurent Pinchart
2023-08-29 15:42         ` Biju Das
2023-08-29 15:42           ` Biju Das
2023-08-30  8:22           ` Laurent Pinchart
2023-08-30  8:22             ` Laurent Pinchart
2023-08-13 18:05 ` Biju Das [this message]
2023-08-13 18:05   ` [PATCH 6/7] drm: adv7511: Add link_config " Biju Das
2023-08-29  7:34   ` Laurent Pinchart
2023-08-29  7:34     ` Laurent Pinchart
2023-08-29 14:20     ` Biju Das
2023-08-29 14:20       ` Biju Das
2023-08-13 18:05 ` [PATCH 7/7] drm: adv7511: Add hpd_override_enable " Biju Das
2023-08-13 18:05   ` Biju Das
2023-08-18 12:41   ` Adam Ford
2023-08-18 12:41     ` Adam Ford
2023-08-18 13:34     ` Biju Das
2023-08-18 13:34       ` Biju Das
2023-08-18 13:37       ` Adam Ford
2023-08-18 13:37         ` Adam Ford
2023-08-18 13:44         ` Biju Das
2023-08-18 13:44           ` Biju Das
2023-08-29  7:36     ` Laurent Pinchart
2023-08-29  7:36       ` Laurent Pinchart
2023-08-29 14:22       ` Biju Das
2023-08-29 14:22         ` Biju Das
2023-08-18 13:56 ` [PATCH 0/7] ADV7511 driver enhancements Fabio Estevam
2023-08-18 13:56   ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230813180512.307418-7-biju.das.jz@bp.renesas.com \
    --to=biju.das.jz@bp.renesas.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=aford173@gmail.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=bogdan.togorean@analog.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert+renesas@glider.be \
    --cc=javierm@redhat.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.