From: Nathan Chancellor <nathan@kernel.org> To: a.zummo@towertech.it, alexandre.belloni@bootlin.com Cc: mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, arnd@arndb.de, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, patches@lists.linux.dev, Nathan Chancellor <nathan@kernel.org> Subject: [PATCH] rtc: stm32: Use NOIRQ_SYSTEM_SLEEP_PM_OPS() Date: Tue, 15 Aug 2023 15:16:41 -0700 [thread overview] Message-ID: <20230815-rtc-stm32-unused-pm-funcs-v1-1-82eb8e02d903@kernel.org> (raw) After the switch to SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() and a subsequent fix, stm32_rtc_{suspend,resume}() are unused when CONFIG_PM_SLEEP is not set because SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() is a no-op in that configuration: drivers/rtc/rtc-stm32.c:904:12: error: 'stm32_rtc_resume' defined but not used [-Werror=unused-function] 904 | static int stm32_rtc_resume(struct device *dev) | ^~~~~~~~~~~~~~~~ drivers/rtc/rtc-stm32.c:894:12: error: 'stm32_rtc_suspend' defined but not used [-Werror=unused-function] 894 | static int stm32_rtc_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors The non-"SET_" version of this macro, NOIRQ_SYSTEM_SLEEP_PM_OPS(), is designed to handle this situation by only assigning the callbacks when CONFIG_PM_SLEEP is set while allowing the functions to appear used to the compiler. Switch to that macro to resolve the warnings. There is no functional change with this, as SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() is defined using NOIRQ_SYSTEM_SLEEP_PM_OPS() when CONFIG_PM_SLEEP is set. Signed-off-by: Nathan Chancellor <nathan@kernel.org> --- I am not sure what to do about a Fixes: tag for this change. I am not sure how Arnd triggered the error/warning in commit a69c610e13e2 ("rtc: stm32: remove incorrect #ifdef check"), since from what I can tell, SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() is only defined in terms of NOIRQ_SYSTEM_SLEEP_PM_OPS() when CONFIG_PM_SLEEP is set, so I am not sure how those functions could be absent in the source file but used in NOIRQ_SYSTEM_SLEEP_PM_OPS() when CONFIG_PM_SLEEP is unset... I could be missing something though. However, I think this change should have been done as part of commit fb9a7e5360dc ("rtc: stm32: change PM callbacks to "_noirq()"") because the "SET_" macros are deprecated and that would have made Arnd's change necessary so... assign an appropriate Fixes: tag based on that information as you will :) --- drivers/rtc/rtc-stm32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-stm32.c b/drivers/rtc/rtc-stm32.c index 3ce4b3d08155..76753c71d92e 100644 --- a/drivers/rtc/rtc-stm32.c +++ b/drivers/rtc/rtc-stm32.c @@ -923,7 +923,7 @@ static int stm32_rtc_resume(struct device *dev) } static const struct dev_pm_ops stm32_rtc_pm_ops = { - SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(stm32_rtc_suspend, stm32_rtc_resume) + NOIRQ_SYSTEM_SLEEP_PM_OPS(stm32_rtc_suspend, stm32_rtc_resume) }; static struct platform_driver stm32_rtc_driver = { --- base-commit: 4f3688dca15053555ade31a785a9c75837a64fb8 change-id: 20230815-rtc-stm32-unused-pm-funcs-90d84bc2c016 Best regards, -- Nathan Chancellor <nathan@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org> To: a.zummo@towertech.it, alexandre.belloni@bootlin.com Cc: mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, arnd@arndb.de, linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, patches@lists.linux.dev, Nathan Chancellor <nathan@kernel.org> Subject: [PATCH] rtc: stm32: Use NOIRQ_SYSTEM_SLEEP_PM_OPS() Date: Tue, 15 Aug 2023 15:16:41 -0700 [thread overview] Message-ID: <20230815-rtc-stm32-unused-pm-funcs-v1-1-82eb8e02d903@kernel.org> (raw) After the switch to SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() and a subsequent fix, stm32_rtc_{suspend,resume}() are unused when CONFIG_PM_SLEEP is not set because SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() is a no-op in that configuration: drivers/rtc/rtc-stm32.c:904:12: error: 'stm32_rtc_resume' defined but not used [-Werror=unused-function] 904 | static int stm32_rtc_resume(struct device *dev) | ^~~~~~~~~~~~~~~~ drivers/rtc/rtc-stm32.c:894:12: error: 'stm32_rtc_suspend' defined but not used [-Werror=unused-function] 894 | static int stm32_rtc_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors The non-"SET_" version of this macro, NOIRQ_SYSTEM_SLEEP_PM_OPS(), is designed to handle this situation by only assigning the callbacks when CONFIG_PM_SLEEP is set while allowing the functions to appear used to the compiler. Switch to that macro to resolve the warnings. There is no functional change with this, as SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() is defined using NOIRQ_SYSTEM_SLEEP_PM_OPS() when CONFIG_PM_SLEEP is set. Signed-off-by: Nathan Chancellor <nathan@kernel.org> --- I am not sure what to do about a Fixes: tag for this change. I am not sure how Arnd triggered the error/warning in commit a69c610e13e2 ("rtc: stm32: remove incorrect #ifdef check"), since from what I can tell, SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() is only defined in terms of NOIRQ_SYSTEM_SLEEP_PM_OPS() when CONFIG_PM_SLEEP is set, so I am not sure how those functions could be absent in the source file but used in NOIRQ_SYSTEM_SLEEP_PM_OPS() when CONFIG_PM_SLEEP is unset... I could be missing something though. However, I think this change should have been done as part of commit fb9a7e5360dc ("rtc: stm32: change PM callbacks to "_noirq()"") because the "SET_" macros are deprecated and that would have made Arnd's change necessary so... assign an appropriate Fixes: tag based on that information as you will :) --- drivers/rtc/rtc-stm32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-stm32.c b/drivers/rtc/rtc-stm32.c index 3ce4b3d08155..76753c71d92e 100644 --- a/drivers/rtc/rtc-stm32.c +++ b/drivers/rtc/rtc-stm32.c @@ -923,7 +923,7 @@ static int stm32_rtc_resume(struct device *dev) } static const struct dev_pm_ops stm32_rtc_pm_ops = { - SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(stm32_rtc_suspend, stm32_rtc_resume) + NOIRQ_SYSTEM_SLEEP_PM_OPS(stm32_rtc_suspend, stm32_rtc_resume) }; static struct platform_driver stm32_rtc_driver = { --- base-commit: 4f3688dca15053555ade31a785a9c75837a64fb8 change-id: 20230815-rtc-stm32-unused-pm-funcs-90d84bc2c016 Best regards, -- Nathan Chancellor <nathan@kernel.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2023-08-15 22:16 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-15 22:16 Nathan Chancellor [this message] 2023-08-15 22:16 ` [PATCH] rtc: stm32: Use NOIRQ_SYSTEM_SLEEP_PM_OPS() Nathan Chancellor 2023-08-16 13:53 ` Arnd Bergmann 2023-08-16 13:53 ` Arnd Bergmann 2023-08-16 22:53 ` Alexandre Belloni 2023-08-16 22:53 ` Alexandre Belloni 2023-08-16 11:33 Geert Uytterhoeven 2023-08-16 11:33 ` Geert Uytterhoeven 2023-08-16 13:10 ` Arnd Bergmann 2023-08-16 13:10 ` Arnd Bergmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230815-rtc-stm32-unused-pm-funcs-v1-1-82eb8e02d903@kernel.org \ --to=nathan@kernel.org \ --cc=a.zummo@towertech.it \ --cc=alexandre.belloni@bootlin.com \ --cc=alexandre.torgue@foss.st.com \ --cc=arnd@arndb.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-rtc@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=patches@lists.linux.dev \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.