All of lore.kernel.org
 help / color / mirror / Atom feed
From: Biju Das <biju.das.jz@bp.renesas.com>
To: cip-dev@lists.cip-project.org,
	Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
	Pavel Machek <pavel@denx.de>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
	Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: [PATCH 5.10.y-cip 11/14] rtc: isl1208: Add support for the built-in RTC on the PMIC RAA215300
Date: Fri, 18 Aug 2023 10:28:04 +0100	[thread overview]
Message-ID: <20230818092807.159112-12-biju.das.jz@bp.renesas.com> (raw)
In-Reply-To: <20230818092807.159112-1-biju.das.jz@bp.renesas.com>

commit fdd63f65ac25d0851dade4c7ba94a7a882b8d9c2 upstream.

The built-in RTC found on PMIC RAA215300 is the same as ISL1208.
However, the external oscillator bit is inverted on PMIC version
0x11. The PMIC driver detects PMIC version and instantiates the
RTC device based on i2c_device_id.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Link: https://lore.kernel.org/r/20230623140948.384762-11-biju.das.jz@bp.renesas.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/rtc/rtc-isl1208.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c
index 726bc257c0fc..f6101ee74cd6 100644
--- a/drivers/rtc/rtc-isl1208.c
+++ b/drivers/rtc/rtc-isl1208.c
@@ -74,6 +74,7 @@ struct isl1208_config {
 	unsigned int	nvmem_length;
 	unsigned	has_tamper:1;
 	unsigned	has_timestamp:1;
+	unsigned	has_inverted_osc_bit:1;
 };
 
 static const struct isl1208_config config_isl1208 = {
@@ -100,11 +101,19 @@ static const struct isl1208_config config_isl1219 = {
 	.has_timestamp = true
 };
 
+static const struct isl1208_config config_raa215300_a0 = {
+	.nvmem_length = 2,
+	.has_tamper = false,
+	.has_timestamp = false,
+	.has_inverted_osc_bit = true
+};
+
 static const struct i2c_device_id isl1208_id[] = {
 	{ "isl1208", .driver_data = (kernel_ulong_t)&config_isl1208 },
 	{ "isl1209", .driver_data = (kernel_ulong_t)&config_isl1209 },
 	{ "isl1218", .driver_data = (kernel_ulong_t)&config_isl1218 },
 	{ "isl1219", .driver_data = (kernel_ulong_t)&config_isl1219 },
+	{ "raa215300_a0", .driver_data = (kernel_ulong_t)&config_raa215300_a0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, isl1208_id);
@@ -893,6 +902,9 @@ isl1208_probe(struct i2c_client *client, const struct i2c_device_id *id)
 		return sr;
 	}
 
+	if (isl1208->config->has_inverted_osc_bit)
+		xtosb_val = !xtosb_val;
+
 	rc = isl1208_set_xtoscb(client, sr, xtosb_val);
 	if (rc)
 		return rc;
-- 
2.25.1



  parent reply	other threads:[~2023-08-18  9:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18  9:27 [PATCH 5.10.y-cip 00/14] Add Renesas PMIC RAA215300 driver and builtin RTC support Biju Das
2023-08-18  9:27 ` [PATCH 5.10.y-cip 01/14] regulator: dt-bindings: Add Renesas RAA215300 PMIC bindings Biju Das
2023-08-18  9:27 ` [PATCH 5.10.y-cip 02/14] regulator: Add Renesas PMIC RAA215300 driver Biju Das
2023-08-18  9:27 ` [PATCH 5.10.y-cip 03/14] regulator: raa215300: Add build dependency with COMMON_CLK Biju Das
2023-08-18  9:27 ` [PATCH 5.10.y-cip 04/14] rtc: isl1208: quiet maybe-unused variable warning Biju Das
2023-08-18  9:27 ` [PATCH 5.10.y-cip 05/14] dt-bindings: rtc: isl1208: Convert to json-schema Biju Das
2023-08-18  9:27 ` [PATCH 5.10.y-cip 06/14] dt-bindings: rtc: isil,isl1208: Document clock and clock-names properties Biju Das
2023-08-18  9:28 ` [PATCH 5.10.y-cip 07/14] rtc: isl1208: Drop name variable Biju Das
2023-08-18  9:28 ` [PATCH 5.10.y-cip 08/14] rtc: isl1208: Make similar I2C and DT-based matching table Biju Das
2023-08-18  9:28 ` [PATCH 5.10.y-cip 09/14] rtc: isl1208: Drop enum isl1208_id and split isl1208_configs[] Biju Das
2023-08-18  9:28 ` [PATCH 5.10.y-cip 10/14] rtc: isl1208: Add isl1208_set_xtoscb() Biju Das
2023-08-18  9:28 ` Biju Das [this message]
2023-08-18  9:28 ` [PATCH 5.10.y-cip 12/14] arm64: defconfig: Enable PMIC RAA215300 and RTC ISL 1208 configs Biju Das
2023-08-18  9:28 ` [PATCH 5.10.y-cip 13/14] arm64: dts: renesas: rzg2l-smarc-som: Enable PMIC and built-in RTC Biju Das
2023-08-18  9:28 ` [PATCH 5.10.y-cip 14/14] arm64: dts: renesas: rzg2lc-smarc-som: " Biju Das
2023-08-19 17:17 ` [PATCH 5.10.y-cip 00/14] Add Renesas PMIC RAA215300 driver and builtin RTC support Pavel Machek
2023-08-22  8:20   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230818092807.159112-12-biju.das.jz@bp.renesas.com \
    --to=biju.das.jz@bp.renesas.com \
    --cc=cip-dev@lists.cip-project.org \
    --cc=claudiu.beznea.uj@bp.renesas.com \
    --cc=nobuhiro1.iwamatsu@toshiba.co.jp \
    --cc=pavel@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.