All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yu Kuai <yukuai1@huaweicloud.com>
To: agk@redhat.com, snitzer@kernel.org, dm-devel@redhat.com,
	song@kernel.org, xni@redhat.com
Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
	yukuai3@huawei.com, yukuai1@huaweicloud.com, yi.zhang@huawei.com,
	yangerkun@huawei.com
Subject: [PATCH -next v2 4/7] md-bitmap: remove the checking of 'pers->quiesce' from location_store()
Date: Fri, 25 Aug 2023 11:09:53 +0800	[thread overview]
Message-ID: <20230825030956.1527023-5-yukuai1@huaweicloud.com> (raw)
In-Reply-To: <20230825030956.1527023-1-yukuai1@huaweicloud.com>

From: Yu Kuai <yukuai3@huawei.com>

After commit 4d27e927344a ("md: don't quiesce in mddev_suspend()"),
there is no need to check 'pers->quiesce' before calling
mddev_suspend().

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
 drivers/md/md-bitmap.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c
index 6f9ff14971f9..f38c7f3156cb 100644
--- a/drivers/md/md-bitmap.c
+++ b/drivers/md/md-bitmap.c
@@ -2352,10 +2352,6 @@ location_store(struct mddev *mddev, const char *buf, size_t len)
 	if (rv)
 		return rv;
 	if (mddev->pers) {
-		if (!mddev->pers->quiesce) {
-			rv = -EBUSY;
-			goto out;
-		}
 		if (mddev->recovery || mddev->sync_thread) {
 			rv = -EBUSY;
 			goto out;
-- 
2.39.2


WARNING: multiple messages have this Message-ID (diff)
From: Yu Kuai <yukuai1@huaweicloud.com>
To: agk@redhat.com, snitzer@kernel.org, dm-devel@redhat.com,
	song@kernel.org, xni@redhat.com
Cc: yi.zhang@huawei.com, yangerkun@huawei.com,
	linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
	yukuai1@huaweicloud.com, yukuai3@huawei.com
Subject: [dm-devel] [PATCH -next v2 4/7] md-bitmap: remove the checking of 'pers->quiesce' from location_store()
Date: Fri, 25 Aug 2023 11:09:53 +0800	[thread overview]
Message-ID: <20230825030956.1527023-5-yukuai1@huaweicloud.com> (raw)
In-Reply-To: <20230825030956.1527023-1-yukuai1@huaweicloud.com>

From: Yu Kuai <yukuai3@huawei.com>

After commit 4d27e927344a ("md: don't quiesce in mddev_suspend()"),
there is no need to check 'pers->quiesce' before calling
mddev_suspend().

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
 drivers/md/md-bitmap.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c
index 6f9ff14971f9..f38c7f3156cb 100644
--- a/drivers/md/md-bitmap.c
+++ b/drivers/md/md-bitmap.c
@@ -2352,10 +2352,6 @@ location_store(struct mddev *mddev, const char *buf, size_t len)
 	if (rv)
 		return rv;
 	if (mddev->pers) {
-		if (!mddev->pers->quiesce) {
-			rv = -EBUSY;
-			goto out;
-		}
 		if (mddev->recovery || mddev->sync_thread) {
 			rv = -EBUSY;
 			goto out;
-- 
2.39.2

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


  parent reply	other threads:[~2023-08-25  3:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-25  3:09 [dm-devel] [PATCH -next v2 0/7] md: initialize 'active_io' while allocating mddev Yu Kuai
2023-08-25  3:09 ` Yu Kuai
2023-08-25  3:09 ` [dm-devel] [PATCH -next v2 1/7] " Yu Kuai
2023-08-25  3:09   ` Yu Kuai
2023-08-25  3:09 ` [dm-devel] [PATCH -next v2 2/7] md: initialize 'writes_pending' " Yu Kuai
2023-08-25  3:09   ` Yu Kuai
2023-08-25  3:09 ` [PATCH -next v2 3/7] md: don't rely on 'mddev->pers' to be set in mddev_suspend() Yu Kuai
2023-08-25  3:09   ` [dm-devel] " Yu Kuai
2023-08-25  3:09 ` Yu Kuai [this message]
2023-08-25  3:09   ` [dm-devel] [PATCH -next v2 4/7] md-bitmap: remove the checking of 'pers->quiesce' from location_store() Yu Kuai
2023-08-25  3:09 ` [dm-devel] [PATCH -next v2 5/7] md-bitmap: suspend array earlier in location_store() Yu Kuai
2023-08-25  3:09   ` Yu Kuai
2023-08-25  3:09 ` [PATCH -next v2 6/7] md: don't check 'mddev->pers' from suspend_hi_store() Yu Kuai
2023-08-25  3:09   ` [dm-devel] " Yu Kuai
2023-08-25  3:09 ` [dm-devel] [PATCH -next v2 7/7] md: don't check 'mddev->pers' and 'pers->quiesce' from suspend_lo_store() Yu Kuai
2023-08-25  3:09   ` Yu Kuai
2023-08-25  6:40 ` [PATCH -next v2 0/7] md: initialize 'active_io' while allocating mddev Song Liu
2023-08-25  6:40   ` [dm-devel] " Song Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230825030956.1527023-5-yukuai1@huaweicloud.com \
    --to=yukuai1@huaweicloud.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=snitzer@kernel.org \
    --cc=song@kernel.org \
    --cc=xni@redhat.com \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.