All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mikhail Kobuk <m.kobuk@ispras.ru>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Cc: Mikhail Kobuk <m.kobuk@ispras.ru>,
	Linus Walleij <linus.walleij@linaro.org>,
	openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org,
	Alexey Khoroshilov <khoroshilov@ispras.ru>
Subject: [PATCH] pinctrl: nuvoton: wpcm450: fix out of bounds write
Date: Fri, 25 Aug 2023 13:15:28 +0300	[thread overview]
Message-ID: <20230825101532.6624-1-m.kobuk@ispras.ru> (raw)

Write into 'pctrl->gpio_bank' happens before the check for GPIO index
validity, so out of bounds write may happen.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: a1d1e0e3d80a ("pinctrl: nuvoton: Add driver for WPCM450")
Signed-off-by: Mikhail Kobuk <m.kobuk@ispras.ru>
Reviewed-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
 drivers/pinctrl/nuvoton/pinctrl-wpcm450.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
index 2d1c1652cfd9..8a9961ac8712 100644
--- a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
+++ b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
@@ -1062,13 +1062,13 @@ static int wpcm450_gpio_register(struct platform_device *pdev,
 		if (ret < 0)
 			return ret;
 
-		gpio = &pctrl->gpio_bank[reg];
-		gpio->pctrl = pctrl;
-
 		if (reg >= WPCM450_NUM_BANKS)
 			return dev_err_probe(dev, -EINVAL,
 					     "GPIO index %d out of range!\n", reg);
 
+		gpio = &pctrl->gpio_bank[reg];
+		gpio->pctrl = pctrl;
+
 		bank = &wpcm450_banks[reg];
 		gpio->bank = bank;
 
-- 
2.42.0


WARNING: multiple messages have this Message-ID (diff)
From: Mikhail Kobuk <m.kobuk@ispras.ru>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Cc: lvc-project@linuxtesting.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Mikhail Kobuk <m.kobuk@ispras.ru>,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	openbmc@lists.ozlabs.org,
	Alexey Khoroshilov <khoroshilov@ispras.ru>
Subject: [PATCH] pinctrl: nuvoton: wpcm450: fix out of bounds write
Date: Fri, 25 Aug 2023 13:15:28 +0300	[thread overview]
Message-ID: <20230825101532.6624-1-m.kobuk@ispras.ru> (raw)

Write into 'pctrl->gpio_bank' happens before the check for GPIO index
validity, so out of bounds write may happen.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: a1d1e0e3d80a ("pinctrl: nuvoton: Add driver for WPCM450")
Signed-off-by: Mikhail Kobuk <m.kobuk@ispras.ru>
Reviewed-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
 drivers/pinctrl/nuvoton/pinctrl-wpcm450.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
index 2d1c1652cfd9..8a9961ac8712 100644
--- a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
+++ b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
@@ -1062,13 +1062,13 @@ static int wpcm450_gpio_register(struct platform_device *pdev,
 		if (ret < 0)
 			return ret;
 
-		gpio = &pctrl->gpio_bank[reg];
-		gpio->pctrl = pctrl;
-
 		if (reg >= WPCM450_NUM_BANKS)
 			return dev_err_probe(dev, -EINVAL,
 					     "GPIO index %d out of range!\n", reg);
 
+		gpio = &pctrl->gpio_bank[reg];
+		gpio->pctrl = pctrl;
+
 		bank = &wpcm450_banks[reg];
 		gpio->bank = bank;
 
-- 
2.42.0


             reply	other threads:[~2023-08-25 10:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-25 10:15 Mikhail Kobuk [this message]
2023-08-25 10:15 ` [PATCH] pinctrl: nuvoton: wpcm450: fix out of bounds write Mikhail Kobuk
2023-08-27 18:46 ` Jonathan Neuschäfer
2023-08-27 18:46   ` Jonathan Neuschäfer
2023-09-12  7:04 ` Linus Walleij
2023-09-12  7:04   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230825101532.6624-1-m.kobuk@ispras.ru \
    --to=m.kobuk@ispras.ru \
    --cc=j.neuschaefer@gmx.net \
    --cc=khoroshilov@ispras.ru \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.