All of lore.kernel.org
 help / color / mirror / Atom feed
From: coolrrsh@gmail.com
To: broonie@kernel.org, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
	Rajeshwar R Shinde <coolrrsh@gmail.com>
Subject: [PATCH v2] spi: spi-mpc512x-psc: Fix an unsigned comparison that can never be negative
Date: Sun,  3 Sep 2023 21:07:20 +0530	[thread overview]
Message-ID: <20230903153720.3801-1-coolrrsh@gmail.com> (raw)

From: Rajeshwar R Shinde <coolrrsh@gmail.com>

In struct mpc512x_psc_spi, the variable 'irq' is declared as an
unsigned int. The comparison of variable 'irq'  with signed int
operand is incorrect. Also, the return value from the call to
platform_get_irq(pdev,0) is int and it is assigned to an unsigned
int variable 'irq', thus redeclaring the type of variable 'irq'
to signed int.

This fixes warning such as:
drivers/spi/spi-mpc512x-psc.c:493:5-13:
WARNING: Unsigned expression compared with zero: mps -> irq < 0

Signed-off-by: Rajeshwar R Shinde <coolrrsh@gmail.com>

---
v1->v2
changed the commit message

---
 drivers/spi/spi-mpc512x-psc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-mpc512x-psc.c b/drivers/spi/spi-mpc512x-psc.c
index 99aeef28a..5cecca1be 100644
--- a/drivers/spi/spi-mpc512x-psc.c
+++ b/drivers/spi/spi-mpc512x-psc.c
@@ -53,7 +53,7 @@ struct mpc512x_psc_spi {
 	int type;
 	void __iomem *psc;
 	struct mpc512x_psc_fifo __iomem *fifo;
-	unsigned int irq;
+	int irq;
 	u8 bits_per_word;
 	u32 mclk_rate;
 
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: coolrrsh@gmail.com
To: broonie@kernel.org, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: linux-kernel-mentees@lists.linuxfoundation.org
Subject: [PATCH v2] spi: spi-mpc512x-psc: Fix an unsigned comparison that can never be negative
Date: Sun,  3 Sep 2023 21:07:20 +0530	[thread overview]
Message-ID: <20230903153720.3801-1-coolrrsh@gmail.com> (raw)

From: Rajeshwar R Shinde <coolrrsh@gmail.com>

In struct mpc512x_psc_spi, the variable 'irq' is declared as an
unsigned int. The comparison of variable 'irq'  with signed int
operand is incorrect. Also, the return value from the call to
platform_get_irq(pdev,0) is int and it is assigned to an unsigned
int variable 'irq', thus redeclaring the type of variable 'irq'
to signed int.

This fixes warning such as:
drivers/spi/spi-mpc512x-psc.c:493:5-13:
WARNING: Unsigned expression compared with zero: mps -> irq < 0

Signed-off-by: Rajeshwar R Shinde <coolrrsh@gmail.com>

---
v1->v2
changed the commit message

---
 drivers/spi/spi-mpc512x-psc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-mpc512x-psc.c b/drivers/spi/spi-mpc512x-psc.c
index 99aeef28a..5cecca1be 100644
--- a/drivers/spi/spi-mpc512x-psc.c
+++ b/drivers/spi/spi-mpc512x-psc.c
@@ -53,7 +53,7 @@ struct mpc512x_psc_spi {
 	int type;
 	void __iomem *psc;
 	struct mpc512x_psc_fifo __iomem *fifo;
-	unsigned int irq;
+	int irq;
 	u8 bits_per_word;
 	u32 mclk_rate;
 
-- 
2.25.1

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

             reply	other threads:[~2023-09-03 15:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-03 15:37 coolrrsh [this message]
2023-09-03 15:37 ` [PATCH v2] spi: spi-mpc512x-psc: Fix an unsigned comparison that can never be negative coolrrsh
  -- strict thread matches above, loose matches on Subject: below --
2023-08-13 14:12 coolrrsh
2023-08-13 14:12 ` coolrrsh
2023-08-16  6:08 ` Rajeshwar Shinde
2023-08-16 11:32   ` Mark Brown
2023-08-16 11:32     ` Mark Brown
2023-09-03 14:42     ` Rajeshwar Shinde
2023-09-03 17:20       ` Mark Brown
2023-09-03 17:20         ` Mark Brown
     [not found]         ` <CA+VNjV3_JRvhjanLEdYRnxcTZv2pv307utD-bpmy_7QFT3Y+Pg@mail.gmail.com>
2023-12-04 12:14           ` Mark Brown
2023-08-07 14:49 coolrrsh
2023-08-07 14:49 ` coolrrsh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230903153720.3801-1-coolrrsh@gmail.com \
    --to=coolrrsh@gmail.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.