From: sunying@nj.iscas.ac.cn
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
pengpeng@iscas.ac.cn, Ying Sun <sunying@nj.iscas.ac.cn>
Subject: [PATCH] mm/shmem: remove dead code can not be satisfied by "(CONFIG_SHMEM)&&(!(CONFIG_SHMEM))"
Date: Wed, 6 Sep 2023 12:50:12 +0800 [thread overview]
Message-ID: <20230906045012.14999-1-sunying@nj.iscas.ac.cn> (raw)
From: Ying Sun <sunying@nj.iscas.ac.cn>
The value of “.fs_flags” in line 4608 is a dead code
which will never be implemented，because its conditions of
line 47 "#ifdef CONFIG_SHMEM" and line 4607 are mutually exclusive.
It is recommended to delete redundant code.
Suggested-by: Yanjie Ren <renyanjie01@gmail.com>
Signed-off-by: Ying Sun <sunying@nj.iscas.ac.cn>
---
mm/shmem.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index 13c27c343820..be050efe18cb 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -4602,11 +4602,7 @@ static struct file_system_type shmem_fs_type = {
.parameters = shmem_fs_parameters,
#endif
.kill_sb = kill_litter_super,
-#ifdef CONFIG_SHMEM
.fs_flags = FS_USERNS_MOUNT | FS_ALLOW_IDMAP | FS_MGTIME,
-#else
- .fs_flags = FS_USERNS_MOUNT,
-#endif
};
void __init shmem_init(void)
--
2.17.1
reply other threads:[~2023-09-06 4:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230906045012.14999-1-sunying@nj.iscas.ac.cn \
--to=sunying@nj.iscas.ac.cn \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pengpeng@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.