From: Douglas Anderson <dianders@chromium.org> To: Mark Rutland <mark.rutland@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Sumit Garg <sumit.garg@linaro.org>, Daniel Thompson <daniel.thompson@linaro.org>, Marc Zyngier <maz@kernel.org> Cc: linux-arm-kernel@lists.infradead.org, "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>, Lecopzer Chen <lecopzer.chen@mediatek.com>, Chen-Yu Tsai <wens@csie.org>, Tomohiro Misono <misono.tomohiro@fujitsu.com>, Peter Zijlstra <peterz@infradead.org>, Masayoshi Mizuma <msys.mizuma@gmail.com>, Stephane Eranian <eranian@google.com>, Ard Biesheuvel <ardb@kernel.org>, kgdb-bugreport@lists.sourceforge.net, Stephen Boyd <swboyd@chromium.org>, linux-perf-users@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>, ito-yuichi@fujitsu.com, Douglas Anderson <dianders@chromium.org>, Chen-Yu Tsai <wenst@chromium.org>, jpoimboe@kernel.org, linux-kernel@vger.kernel.org, scott@os.amperecomputing.com, vschneid@redhat.com Subject: [PATCH v13 7/7] arm64: smp: Mark IPI globals as __ro_after_init Date: Wed, 6 Sep 2023 09:03:02 -0700 [thread overview] Message-ID: <20230906090246.v13.7.I625d393afd71e1766ef73d3bfaac0b347a4afd19@changeid> (raw) In-Reply-To: <20230906160505.2431857-1-dianders@chromium.org> Mark the three IPI-related globals in smp.c as "__ro_after_init" since they are only ever set in set_smp_ipi_range(), which is marked "__init". This is a better and more secure marking than the old "__read_mostly". Suggested-by: Stephen Boyd <swboyd@chromium.org> Acked-by: Mark Rutland <mark.rutland@arm.com> Tested-by: Chen-Yu Tsai <wenst@chromium.org> Signed-off-by: Douglas Anderson <dianders@chromium.org> --- This patch is almost completely unrelated to the rest of the series other than the fact that it would cause a merge conflict with the series if sent separately. I tacked it on to this series in response to Stephen's feedback on v11 of this series [1]. If someone hates it (not sure why they would), it could be dropped. If someone loves it, it could be promoted to the start of the series and/or land on its own (resolving merge conflicts). [1] https://lore.kernel.org/r/CAE-0n52iVDgZa8XT8KTMj12c_ESSJt7f7A0fuZ_oAMMqpGcSzA@mail.gmail.com (no changes since v12) Changes in v12: - ("arm64: smp: Mark IPI globals as __ro_after_init") new for v12. arch/arm64/kernel/smp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c index 1a53e57c81d0..814d9aa93b21 100644 --- a/arch/arm64/kernel/smp.c +++ b/arch/arm64/kernel/smp.c @@ -84,9 +84,9 @@ enum ipi_msg_type { MAX_IPI }; -static int ipi_irq_base __read_mostly; -static int nr_ipi __read_mostly = NR_IPI; -static struct irq_desc *ipi_desc[MAX_IPI] __read_mostly; +static int ipi_irq_base __ro_after_init; +static int nr_ipi __ro_after_init = NR_IPI; +static struct irq_desc *ipi_desc[MAX_IPI] __ro_after_init; static void ipi_setup(int cpu); -- 2.42.0.283.g2d96d420d3-goog
WARNING: multiple messages have this Message-ID (diff)
From: Douglas Anderson <dianders@chromium.org> To: Mark Rutland <mark.rutland@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Sumit Garg <sumit.garg@linaro.org>, Daniel Thompson <daniel.thompson@linaro.org>, Marc Zyngier <maz@kernel.org> Cc: linux-arm-kernel@lists.infradead.org, "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>, Lecopzer Chen <lecopzer.chen@mediatek.com>, Chen-Yu Tsai <wens@csie.org>, Tomohiro Misono <misono.tomohiro@fujitsu.com>, Peter Zijlstra <peterz@infradead.org>, Masayoshi Mizuma <msys.mizuma@gmail.com>, Stephane Eranian <eranian@google.com>, Ard Biesheuvel <ardb@kernel.org>, kgdb-bugreport@lists.sourceforge.net, Stephen Boyd <swboyd@chromium.org>, linux-perf-users@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>, ito-yuichi@fujitsu.com, Douglas Anderson <dianders@chromium.org>, Chen-Yu Tsai <wenst@chromium.org>, jpoimboe@kernel.org, linux-kernel@vger.kernel.org, scott@os.amperecomputing.com, vschneid@redhat.com Subject: [PATCH v13 7/7] arm64: smp: Mark IPI globals as __ro_after_init Date: Wed, 6 Sep 2023 09:03:02 -0700 [thread overview] Message-ID: <20230906090246.v13.7.I625d393afd71e1766ef73d3bfaac0b347a4afd19@changeid> (raw) In-Reply-To: <20230906160505.2431857-1-dianders@chromium.org> Mark the three IPI-related globals in smp.c as "__ro_after_init" since they are only ever set in set_smp_ipi_range(), which is marked "__init". This is a better and more secure marking than the old "__read_mostly". Suggested-by: Stephen Boyd <swboyd@chromium.org> Acked-by: Mark Rutland <mark.rutland@arm.com> Tested-by: Chen-Yu Tsai <wenst@chromium.org> Signed-off-by: Douglas Anderson <dianders@chromium.org> --- This patch is almost completely unrelated to the rest of the series other than the fact that it would cause a merge conflict with the series if sent separately. I tacked it on to this series in response to Stephen's feedback on v11 of this series [1]. If someone hates it (not sure why they would), it could be dropped. If someone loves it, it could be promoted to the start of the series and/or land on its own (resolving merge conflicts). [1] https://lore.kernel.org/r/CAE-0n52iVDgZa8XT8KTMj12c_ESSJt7f7A0fuZ_oAMMqpGcSzA@mail.gmail.com (no changes since v12) Changes in v12: - ("arm64: smp: Mark IPI globals as __ro_after_init") new for v12. arch/arm64/kernel/smp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c index 1a53e57c81d0..814d9aa93b21 100644 --- a/arch/arm64/kernel/smp.c +++ b/arch/arm64/kernel/smp.c @@ -84,9 +84,9 @@ enum ipi_msg_type { MAX_IPI }; -static int ipi_irq_base __read_mostly; -static int nr_ipi __read_mostly = NR_IPI; -static struct irq_desc *ipi_desc[MAX_IPI] __read_mostly; +static int ipi_irq_base __ro_after_init; +static int nr_ipi __ro_after_init = NR_IPI; +static struct irq_desc *ipi_desc[MAX_IPI] __ro_after_init; static void ipi_setup(int cpu); -- 2.42.0.283.g2d96d420d3-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-06 16:06 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-06 16:02 [PATCH v13 0/7] arm64: Add IPI for backtraces / kgdb; try to use NMI for some IPIs Douglas Anderson 2023-09-06 16:02 ` Douglas Anderson 2023-09-06 16:02 ` [PATCH v13 1/7] irqchip/gic-v3: Enable support for SGIs to act as NMIs Douglas Anderson 2023-09-06 16:02 ` Douglas Anderson 2023-09-12 12:43 ` Marc Zyngier 2023-09-12 12:43 ` Marc Zyngier 2023-09-06 16:02 ` [PATCH v13 2/7] arm64: idle: Tag the arm64 idle functions as __cpuidle Douglas Anderson 2023-09-06 16:02 ` Douglas Anderson 2023-09-06 16:02 ` [PATCH v13 3/7] arm64: smp: Remove dedicated wakeup IPI Douglas Anderson 2023-09-06 16:02 ` Douglas Anderson 2023-09-26 0:39 ` Doug Anderson 2023-09-26 0:39 ` Doug Anderson 2023-10-02 16:48 ` Doug Anderson 2023-10-02 16:48 ` Doug Anderson 2023-09-06 16:02 ` [PATCH v13 4/7] arm64: smp: Add arch support for backtrace using pseudo-NMI Douglas Anderson 2023-09-06 16:02 ` Douglas Anderson 2023-09-06 16:03 ` [PATCH v13 5/7] arm64: smp: IPI_CPU_STOP and IPI_CPU_CRASH_STOP should try for NMI Douglas Anderson 2023-09-06 16:03 ` Douglas Anderson 2023-09-06 16:03 ` [PATCH v13 6/7] arm64: kgdb: Implement kgdb_roundup_cpus() to enable pseudo-NMI roundup Douglas Anderson 2023-09-06 16:03 ` Douglas Anderson 2023-09-06 16:03 ` Douglas Anderson [this message] 2023-09-06 16:03 ` [PATCH v13 7/7] arm64: smp: Mark IPI globals as __ro_after_init Douglas Anderson 2023-09-06 21:45 ` Stephen Boyd 2023-09-06 21:45 ` Stephen Boyd 2023-09-25 17:10 ` [PATCH v13 0/7] arm64: Add IPI for backtraces / kgdb; try to use NMI for some IPIs Catalin Marinas 2023-09-25 17:10 ` Catalin Marinas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230906090246.v13.7.I625d393afd71e1766ef73d3bfaac0b347a4afd19@changeid \ --to=dianders@chromium.org \ --cc=ardb@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=daniel.thompson@linaro.org \ --cc=eranian@google.com \ --cc=ito-yuichi@fujitsu.com \ --cc=jpoimboe@kernel.org \ --cc=kgdb-bugreport@lists.sourceforge.net \ --cc=lecopzer.chen@mediatek.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-perf-users@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=maz@kernel.org \ --cc=misono.tomohiro@fujitsu.com \ --cc=msys.mizuma@gmail.com \ --cc=peterz@infradead.org \ --cc=rafael.j.wysocki@intel.com \ --cc=scott@os.amperecomputing.com \ --cc=sumit.garg@linaro.org \ --cc=swboyd@chromium.org \ --cc=tglx@linutronix.de \ --cc=vschneid@redhat.com \ --cc=wens@csie.org \ --cc=wenst@chromium.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.