From: Xin Hao <haoxing990@gmail.com> To: hannes@cmpxchg.org Cc: mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, haoxing990@gmail.com Subject: [PATCH] mm: memcg: add THP swap out info for anonymous reclaim Date: Sat, 9 Sep 2023 23:52:41 +0800 [thread overview] Message-ID: <20230909155242.22767-1-vernhao@tencent.com> (raw) At present, we support per-memcg reclaim strategy, however we do not know the number of transparent huge pages being reclaimed, as we know the transparent huge pages need to be splited before reclaim them, and they will bring some performance bottleneck effect. for example, when two memcg (A & B) are doing reclaim for anonymous pages at same time, and 'A' memcg is reclaiming a large number of transparent huge pages, we can better analyze that the performance bottleneck will be caused by 'A' memcg. therefore, in order to better analyze such problems, there add THP swap out info for per-memcg. Signed-off-by: Xin Hao <vernhao@tencent.com> --- mm/memcontrol.c | 6 ++++++ mm/page_io.c | 4 +++- mm/vmscan.c | 2 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index ecc07b47e813..a644f601e2ca 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -752,6 +752,8 @@ static const unsigned int memcg_vm_event_stat[] = { #ifdef CONFIG_TRANSPARENT_HUGEPAGE THP_FAULT_ALLOC, THP_COLLAPSE_ALLOC, + THP_SWPOUT, + THP_SWPOUT_FALLBACK, #endif }; @@ -4131,6 +4133,10 @@ static const unsigned int memcg1_events[] = { PGPGOUT, PGFAULT, PGMAJFAULT, +#ifdef CONFIG_TRANSPARENT_HUGEPAGE + THP_SWPOUT, + THP_SWPOUT_FALLBACK, +#endif }; static void memcg1_stat_format(struct mem_cgroup *memcg, struct seq_buf *s) diff --git a/mm/page_io.c b/mm/page_io.c index fe4c21af23f2..008ada2e024a 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -208,8 +208,10 @@ int swap_writepage(struct page *page, struct writeback_control *wbc) static inline void count_swpout_vm_event(struct folio *folio) { #ifdef CONFIG_TRANSPARENT_HUGEPAGE - if (unlikely(folio_test_pmd_mappable(folio))) + if (unlikely(folio_test_pmd_mappable(folio))) { + count_memcg_events(folio_memcg(folio), THP_SWPOUT, 1); count_vm_event(THP_SWPOUT); + } #endif count_vm_events(PSWPOUT, folio_nr_pages(folio)); } diff --git a/mm/vmscan.c b/mm/vmscan.c index ea57a43ebd6b..29a82b72345a 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1928,6 +1928,8 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, folio_list)) goto activate_locked; #ifdef CONFIG_TRANSPARENT_HUGEPAGE + count_memcg_events(folio_memcg(folio), + THP_SWPOUT_FALLBACK, 1); count_vm_event(THP_SWPOUT_FALLBACK); #endif if (!add_to_swap(folio)) -- 2.42.0
WARNING: multiple messages have this Message-ID (diff)
From: Xin Hao <haoxing990-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org Cc: mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org, shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, haoxing990-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Subject: [PATCH] mm: memcg: add THP swap out info for anonymous reclaim Date: Sat, 9 Sep 2023 23:52:41 +0800 [thread overview] Message-ID: <20230909155242.22767-1-vernhao@tencent.com> (raw) At present, we support per-memcg reclaim strategy, however we do not know the number of transparent huge pages being reclaimed, as we know the transparent huge pages need to be splited before reclaim them, and they will bring some performance bottleneck effect. for example, when two memcg (A & B) are doing reclaim for anonymous pages at same time, and 'A' memcg is reclaiming a large number of transparent huge pages, we can better analyze that the performance bottleneck will be caused by 'A' memcg. therefore, in order to better analyze such problems, there add THP swap out info for per-memcg. Signed-off-by: Xin Hao <vernhao-1Nz4purKYjRBDgjK7y7TUQ@public.gmane.org> --- mm/memcontrol.c | 6 ++++++ mm/page_io.c | 4 +++- mm/vmscan.c | 2 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index ecc07b47e813..a644f601e2ca 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -752,6 +752,8 @@ static const unsigned int memcg_vm_event_stat[] = { #ifdef CONFIG_TRANSPARENT_HUGEPAGE THP_FAULT_ALLOC, THP_COLLAPSE_ALLOC, + THP_SWPOUT, + THP_SWPOUT_FALLBACK, #endif }; @@ -4131,6 +4133,10 @@ static const unsigned int memcg1_events[] = { PGPGOUT, PGFAULT, PGMAJFAULT, +#ifdef CONFIG_TRANSPARENT_HUGEPAGE + THP_SWPOUT, + THP_SWPOUT_FALLBACK, +#endif }; static void memcg1_stat_format(struct mem_cgroup *memcg, struct seq_buf *s) diff --git a/mm/page_io.c b/mm/page_io.c index fe4c21af23f2..008ada2e024a 100644 --- a/mm/page_io.c +++ b/mm/page_io.c @@ -208,8 +208,10 @@ int swap_writepage(struct page *page, struct writeback_control *wbc) static inline void count_swpout_vm_event(struct folio *folio) { #ifdef CONFIG_TRANSPARENT_HUGEPAGE - if (unlikely(folio_test_pmd_mappable(folio))) + if (unlikely(folio_test_pmd_mappable(folio))) { + count_memcg_events(folio_memcg(folio), THP_SWPOUT, 1); count_vm_event(THP_SWPOUT); + } #endif count_vm_events(PSWPOUT, folio_nr_pages(folio)); } diff --git a/mm/vmscan.c b/mm/vmscan.c index ea57a43ebd6b..29a82b72345a 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1928,6 +1928,8 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, folio_list)) goto activate_locked; #ifdef CONFIG_TRANSPARENT_HUGEPAGE + count_memcg_events(folio_memcg(folio), + THP_SWPOUT_FALLBACK, 1); count_vm_event(THP_SWPOUT_FALLBACK); #endif if (!add_to_swap(folio)) -- 2.42.0
next reply other threads:[~2023-09-09 16:27 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-09 15:52 Xin Hao [this message] 2023-09-09 15:52 ` [PATCH] mm: memcg: add THP swap out info for anonymous reclaim Xin Hao 2023-09-11 16:08 ` Johannes Weiner 2023-09-12 1:49 ` Vern Hao 2023-09-12 1:49 ` Vern Hao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230909155242.22767-1-vernhao@tencent.com \ --to=haoxing990@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=cgroups@vger.kernel.org \ --cc=hannes@cmpxchg.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@kernel.org \ --cc=roman.gushchin@linux.dev \ --cc=shakeelb@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.