All of lore.kernel.org
 help / color / mirror / Atom feed
From: Biju Das <biju.das.jz@bp.renesas.com>
To: cip-dev@lists.cip-project.org,
	Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
	Pavel Machek <pavel@denx.de>
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
	Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: [PATCH 5.10.y-cip 02/15] rtc: destroy mutex when releasing the device
Date: Mon, 11 Sep 2023 15:46:49 +0100	[thread overview]
Message-ID: <20230911144702.948246-3-biju.das.jz@bp.renesas.com> (raw)
In-Reply-To: <20230911144702.948246-1-biju.das.jz@bp.renesas.com>

From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

commit 0d6d7a390b32ef23d957960d3bb8586a49d6af7c upstream.

Not destroying mutexes doesn't lead to resource leak but it's the correct
thing to do for mutex debugging accounting.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20201110094205.8972-1-brgl@bgdev.pl
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/rtc/class.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/rtc/class.c b/drivers/rtc/class.c
index 625effe6cb65..f46160d76b65 100644
--- a/drivers/rtc/class.c
+++ b/drivers/rtc/class.c
@@ -37,6 +37,7 @@ static void rtc_device_release(struct device *dev)
 	cancel_work_sync(&rtc->irqwork);
 
 	ida_simple_remove(&rtc_ida, rtc->id);
+	mutex_destroy(&rtc->ops_lock);
 	kfree(rtc);
 }
 
-- 
2.25.1



  parent reply	other threads:[~2023-09-11 14:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-11 14:46 [PATCH 5.10.y-cip 00/15] Enable Renesas PMIC RAA215300 and RTC builtin support Biju Das
2023-09-11 14:46 ` [PATCH 5.10.y-cip 01/15] rtc: isl1208: Fix clock tick timed out message Biju Das
2023-09-11 14:46 ` Biju Das [this message]
2023-09-11 14:46 ` [PATCH 5.10.y-cip 03/15] clk: fixed-rate: add devm_clk_hw_register_fixed_rate Biju Das
2023-09-11 14:46 ` [PATCH 5.10.y-cip 04/15] i2c: Add i2c_get_match_data() Biju Das
2023-09-11 14:46 ` [PATCH 5.10.y-cip 05/15] regulator: raa215300: Update help description Biju Das
2023-09-11 14:46 ` [PATCH 5.10.y-cip 06/15] regulator: raa215300: Change the scope of the variables {clkin_name, xin_name} Biju Das
2023-09-11 14:46 ` [PATCH 5.10.y-cip 07/15] regulator: raa215300: Fix resource leak in case of error Biju Das
2023-09-11 14:46 ` [PATCH 5.10.y-cip 08/15] regulator: raa215300: Add const definition Biju Das
2023-09-11 14:46 ` [PATCH 5.10.y-cip 09/15] regulator: raa215300: Change rate from 32000->32768 Biju Das
2023-09-11 14:46 ` [PATCH 5.10.y-cip 10/15] regulator: raa215300: Add missing blank space Biju Das
2023-09-11 14:46 ` [PATCH 5.10.y-cip 11/15] rtc: isl1208: Simplify probe() Biju Das
2023-09-11 14:46 ` [PATCH 5.10.y-cip 12/15] rtc: isl1208: Fix incorrect logic in isl1208_set_xtoscb() Biju Das
2023-09-11 14:47 ` [PATCH 5.10.y-cip 13/15] arm64: defconfig: Enable PMIC RAA215300 and RTC ISL 1208 configs Biju Das
2023-09-11 14:47 ` [PATCH 5.10.y-cip 14/15] arm64: dts: renesas: rzg2l-smarc-som: Enable PMIC and built-in RTC Biju Das
2023-09-11 14:47 ` [PATCH 5.10.y-cip 15/15] arm64: dts: renesas: rzg2lc-smarc-som: " Biju Das
2023-09-12 21:09 ` [PATCH 5.10.y-cip 00/15] Enable Renesas PMIC RAA215300 and RTC builtin support Pavel Machek
2023-09-13  2:25   ` nobuhiro1.iwamatsu
2023-09-13 13:55     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230911144702.948246-3-biju.das.jz@bp.renesas.com \
    --to=biju.das.jz@bp.renesas.com \
    --cc=cip-dev@lists.cip-project.org \
    --cc=claudiu.beznea.uj@bp.renesas.com \
    --cc=nobuhiro1.iwamatsu@toshiba.co.jp \
    --cc=pavel@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.