All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, suraj.kandpal@intel.com,
	ankit.k.nautiyal@intel.com, swati2.sharma@intel.com
Subject: [PATCH 8/8] drm/i915/dsc: Allow DSC only with fractional bpp when forced from debugfs
Date: Wed, 13 Sep 2023 11:36:06 +0530	[thread overview]
Message-ID: <20230913060606.1105349-9-mitulkumar.ajitkumar.golani@intel.com> (raw)
In-Reply-To: <20230913060606.1105349-1-mitulkumar.ajitkumar.golani@intel.com>

From: Swati Sharma <swati2.sharma@intel.com>

If force_dsc_fractional_bpp_en is set through debugfs allow DSC iff
compressed bpp is fractional. Continue if the computed compressed bpp
turns out to be a integer.

v2:
-Use helpers for fractional, integral bits of bits_per_pixel. (Suraj)
-Fix comment (Suraj)

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index d6c29006b816..354d78593a5f 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1906,6 +1906,9 @@ xelpd_dsc_compute_link_config(struct intel_dp *intel_dp,
 	for (compressed_bppx16 = dsc_max_bpp;
 	     compressed_bppx16 >= dsc_min_bpp;
 	     compressed_bppx16 -= bppx16_step) {
+		if (intel_dp->force_dsc_fractional_bpp_en &&
+		    !intel_fractional_bpp_decimal(compressed_bppx16))
+			continue;
 		ret = dsc_compute_link_config(intel_dp,
 					      pipe_config,
 					      limits,
@@ -1913,6 +1916,10 @@ xelpd_dsc_compute_link_config(struct intel_dp *intel_dp,
 					      timeslots);
 		if (ret == 0) {
 			pipe_config->dsc.compressed_bpp_x16 = compressed_bppx16;
+			if (intel_dp->force_dsc_fractional_bpp_en &&
+			    intel_fractional_bpp_decimal(compressed_bppx16))
+				drm_dbg_kms(&i915->drm, "Forcing DSC fractional bpp\n");
+
 			return 0;
 		}
 	}
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [Intel-gfx] [PATCH 8/8] drm/i915/dsc: Allow DSC only with fractional bpp when forced from debugfs
Date: Wed, 13 Sep 2023 11:36:06 +0530	[thread overview]
Message-ID: <20230913060606.1105349-9-mitulkumar.ajitkumar.golani@intel.com> (raw)
In-Reply-To: <20230913060606.1105349-1-mitulkumar.ajitkumar.golani@intel.com>

From: Swati Sharma <swati2.sharma@intel.com>

If force_dsc_fractional_bpp_en is set through debugfs allow DSC iff
compressed bpp is fractional. Continue if the computed compressed bpp
turns out to be a integer.

v2:
-Use helpers for fractional, integral bits of bits_per_pixel. (Suraj)
-Fix comment (Suraj)

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index d6c29006b816..354d78593a5f 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1906,6 +1906,9 @@ xelpd_dsc_compute_link_config(struct intel_dp *intel_dp,
 	for (compressed_bppx16 = dsc_max_bpp;
 	     compressed_bppx16 >= dsc_min_bpp;
 	     compressed_bppx16 -= bppx16_step) {
+		if (intel_dp->force_dsc_fractional_bpp_en &&
+		    !intel_fractional_bpp_decimal(compressed_bppx16))
+			continue;
 		ret = dsc_compute_link_config(intel_dp,
 					      pipe_config,
 					      limits,
@@ -1913,6 +1916,10 @@ xelpd_dsc_compute_link_config(struct intel_dp *intel_dp,
 					      timeslots);
 		if (ret == 0) {
 			pipe_config->dsc.compressed_bpp_x16 = compressed_bppx16;
+			if (intel_dp->force_dsc_fractional_bpp_en &&
+			    intel_fractional_bpp_decimal(compressed_bppx16))
+				drm_dbg_kms(&i915->drm, "Forcing DSC fractional bpp\n");
+
 			return 0;
 		}
 	}
-- 
2.25.1


  parent reply	other threads:[~2023-09-13  6:12 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-13  6:05 [PATCH 0/8] Add DSC fractional bpp support Mitul Golani
2023-09-13  6:05 ` [Intel-gfx] " Mitul Golani
2023-09-13  6:05 ` [PATCH 1/8] drm/display/dp: Add helper function to get DSC bpp prescision Mitul Golani
2023-09-13  6:05   ` [Intel-gfx] " Mitul Golani
2023-09-13  6:14   ` Kandpal, Suraj
2023-09-13  6:14     ` [Intel-gfx] " Kandpal, Suraj
2023-09-21  7:41   ` Jani Nikula
2023-09-21  7:41     ` [Intel-gfx] " Jani Nikula
2023-09-22 12:05     ` Maxime Ripard
2023-09-22 12:05       ` [Intel-gfx] " Maxime Ripard
2023-09-22 14:39   ` [1/8] " Sui Jingfeng
2023-09-22 14:39     ` [Intel-gfx] " Sui Jingfeng
2023-09-13  6:06 ` [PATCH 2/8] drm/i915/display: Store compressed bpp in U6.4 format Mitul Golani
2023-09-13  6:06   ` [Intel-gfx] " Mitul Golani
2023-09-22 16:02   ` [2/8] " Sui Jingfeng
2023-09-22 16:02     ` [Intel-gfx] " Sui Jingfeng
2023-09-13  6:06 ` [PATCH 3/8] drm/i915/display: Consider fractional vdsc bpp while computing m_n values Mitul Golani
2023-09-13  6:06   ` [Intel-gfx] " Mitul Golani
2023-09-22 15:12   ` [3/8] " Sui Jingfeng
2023-09-22 15:12     ` [Intel-gfx] " Sui Jingfeng
2023-09-13  6:06 ` [PATCH 4/8] drm/i915/audio : Consider fractional vdsc bpp while computing tu_data Mitul Golani
2023-09-13  6:06   ` [Intel-gfx] " Mitul Golani
2023-09-13  6:06 ` [PATCH 5/8] drm/i915/dsc/mtl: Add support for fractional bpp Mitul Golani
2023-09-13  6:06   ` [Intel-gfx] " Mitul Golani
2023-09-13  6:06 ` [PATCH 6/8] drm/i915/dp: Iterate over output bpp with fractional step size Mitul Golani
2023-09-13  6:06   ` [Intel-gfx] " Mitul Golani
2023-09-13  6:06 ` [PATCH 7/8] drm/i915/dsc: Add debugfs entry to validate DSC fractional bpp Mitul Golani
2023-09-13  6:06   ` [Intel-gfx] " Mitul Golani
2023-09-21  8:00   ` Jani Nikula
2023-09-21  8:00     ` [Intel-gfx] " Jani Nikula
2023-09-21 11:53     ` Sharma, Swati2
2023-09-21 11:53       ` [Intel-gfx] " Sharma, Swati2
2023-09-21 12:14       ` Jani Nikula
2023-09-21 12:14         ` [Intel-gfx] " Jani Nikula
2023-09-21 12:59         ` Sharma, Swati2
2023-09-21 12:59           ` [Intel-gfx] " Sharma, Swati2
2023-09-22 12:28           ` Jani Nikula
2023-09-22 12:28             ` [Intel-gfx] " Jani Nikula
2023-09-22 16:03   ` [7/8] " Sui Jingfeng
2023-09-22 16:03     ` [Intel-gfx] " Sui Jingfeng
2023-09-13  6:06 ` Mitul Golani [this message]
2023-09-13  6:06   ` [Intel-gfx] [PATCH 8/8] drm/i915/dsc: Allow DSC only with fractional bpp when forced from debugfs Mitul Golani
2023-09-13  6:42 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add DSC fractional bpp support (rev7) Patchwork
2023-09-13  6:42 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-09-13  6:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-09-13  8:45 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-20  4:56 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
2023-09-22 12:45 ` [Intel-gfx] [PATCH 0/8] Add DSC fractional bpp support Imre Deak
2023-09-27 15:22   ` Imre Deak
2023-09-27 16:36     ` Sharma, Swati2
  -- strict thread matches above, loose matches on Subject: below --
2023-09-29  7:13 Mitul Golani
2023-09-29  7:13 ` [PATCH 8/8] drm/i915/dsc: Allow DSC only with fractional bpp when forced from debugfs Mitul Golani
2023-09-26  8:23 [PATCH 0/8] Add DSC fractional bpp support Mitul Golani
2023-09-26  8:23 ` [PATCH 8/8] drm/i915/dsc: Allow DSC only with fractional bpp when forced from debugfs Mitul Golani
2023-09-12 16:37 [PATCH 0/8] Add DSC fractional bpp support Mitul Golani
2023-09-12 16:37 ` [PATCH 8/8] drm/i915/dsc: Allow DSC only with fractional bpp when forced from debugfs Mitul Golani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230913060606.1105349-9-mitulkumar.ajitkumar.golani@intel.com \
    --to=mitulkumar.ajitkumar.golani@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=suraj.kandpal@intel.com \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.