From: Zi Yan <zi.yan@sent.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org
Cc: Zi Yan <ziy@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Muchun Song <muchun.song@linux.dev>,
"Mike Rapoport (IBM)" <rppt@kernel.org>,
stable@vger.kernel.org, Muchun Song <songmuchun@bytedance.com>
Subject: [PATCH v3 3/5] mm/memory_hotplug: use pfn math in place of direct struct page manipulation.
Date: Wed, 13 Sep 2023 16:12:46 -0400 [thread overview]
Message-ID: <20230913201248.452081-4-zi.yan@sent.com> (raw)
In-Reply-To: <20230913201248.452081-1-zi.yan@sent.com>
From: Zi Yan <ziy@nvidia.com>
When dealing with hugetlb pages, manipulating struct page pointers
directly can get to wrong struct page, since struct page is not guaranteed
to be contiguous on SPARSEMEM without VMEMMAP. Use pfn calculation to
handle it properly.
Fixes: eeb0efd071d8 ("mm,memory_hotplug: fix scan_movable_pages() for gigantic hugepages")
Cc: <stable@vger.kernel.org>
Signed-off-by: Zi Yan <ziy@nvidia.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Acked-by: David Hildenbrand <david@redhat.com>
---
mm/memory_hotplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 1b03f4ec6fd2..3b301c4023ff 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -1689,7 +1689,7 @@ static int scan_movable_pages(unsigned long start, unsigned long end,
*/
if (HPageMigratable(head))
goto found;
- skip = compound_nr(head) - (page - head);
+ skip = compound_nr(head) - (pfn - page_to_pfn(head));
pfn += skip - 1;
}
return -ENOENT;
--
2.40.1
next prev parent reply other threads:[~2023-09-13 20:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 20:12 [PATCH v3 0/5] Use nth_page() in place of direct struct page manipulation Zi Yan
2023-09-13 20:12 ` [PATCH v3 1/5] mm/cma: use " Zi Yan
2023-09-14 2:16 ` Zi Yan
2023-09-14 19:05 ` Andrew Morton
2023-09-13 20:12 ` [PATCH v3 2/5] mm/hugetlb: " Zi Yan
2023-09-14 2:20 ` Zi Yan
2023-09-13 20:12 ` Zi Yan [this message]
2023-09-14 2:35 ` [PATCH v3 3/5] mm/memory_hotplug: use pfn math " Zi Yan
2023-09-13 20:12 ` [PATCH v3 4/5] fs: use nth_page() " Zi Yan
2023-09-14 2:45 ` [PATCH v3 4/5] " Zi Yan
2023-09-13 20:12 ` [PATCH v3 5/5] mips: " Zi Yan
2023-09-14 2:46 ` Zi Yan
2023-09-13 21:12 ` [PATCH v3 0/5] Use " Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230913201248.452081-4-zi.yan@sent.com \
--to=zi.yan@sent.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=rppt@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=stable@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.