From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, kernel@pengutronix.de
Subject: [PATCH] spi: Drop warning from spi_stop_queue()
Date: Sat, 16 Sep 2023 18:12:35 +0200 [thread overview]
Message-ID: <20230916161235.1050176-1-u.kleine-koenig@pengutronix.de> (raw)
Both callers of spi_stop_queue() (i.e. spi_destroy_queue() and
spi_controller_suspend()) already emit an error message if
spi_stop_queue() fails. Another warning in this case isn't helpful, so
drop it.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/spi/spi.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 8d6304cb061e..ac518be34917 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -2093,10 +2093,6 @@ static int spi_stop_queue(struct spi_controller *ctlr)
spin_unlock_irqrestore(&ctlr->queue_lock, flags);
- if (ret) {
- dev_warn(&ctlr->dev, "could not stop message queue\n");
- return ret;
- }
return ret;
}
base-commit: dfa449a58323de195773cf928d99db4130702bf7
--
2.40.1
next reply other threads:[~2023-09-16 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 16:12 Uwe Kleine-König [this message]
2023-09-18 15:45 ` [PATCH] spi: Drop warning from spi_stop_queue() Mark Brown
2023-09-19 7:26 ` Geert Uytterhoeven
2023-09-19 8:18 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230916161235.1050176-1-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.