All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Alexander Aring <alex.aring@gmail.com>,
	Stefan Schmidt <stefan@datenfreihafen.org>,
	linux-wpan@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	netdev@vger.kernel.org, David Girault <david.girault@qorvo.com>,
	Romuald Despres <romuald.despres@qorvo.com>,
	Frederic Blain <frederic.blain@qorvo.com>,
	Nicolas Schodet <nico@ni.fr.eu.org>,
	Guilhem Imberton <guilhem.imberton@qorvo.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>
Subject: [PATCH wpan-next v3 01/11] ieee802154: Let PAN IDs be reset
Date: Mon, 18 Sep 2023 17:07:59 +0200	[thread overview]
Message-ID: <20230918150809.275058-2-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20230918150809.275058-1-miquel.raynal@bootlin.com>

Soon association and disassociation will be implemented, which will
require to be able to either change the PAN ID from 0xFFFF to a real
value when association succeeded, or to reset the PAN ID to 0xFFFF upon
disassociation. Let's allow to do that manually for now.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 net/ieee802154/nl802154.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c
index d610c1886160..46ac6f599fe1 100644
--- a/net/ieee802154/nl802154.c
+++ b/net/ieee802154/nl802154.c
@@ -1087,16 +1087,6 @@ static int nl802154_set_pan_id(struct sk_buff *skb, struct genl_info *info)
 
 	pan_id = nla_get_le16(info->attrs[NL802154_ATTR_PAN_ID]);
 
-	/* TODO
-	 * I am not sure about to check here on broadcast pan_id.
-	 * Broadcast is a valid setting, comment from 802.15.4:
-	 * If this value is 0xffff, the device is not associated.
-	 *
-	 * This could useful to simple deassociate an device.
-	 */
-	if (pan_id == cpu_to_le16(IEEE802154_PAN_ID_BROADCAST))
-		return -EINVAL;
-
 	return rdev_set_pan_id(rdev, wpan_dev, pan_id);
 }
 
-- 
2.34.1


  reply	other threads:[~2023-09-18 15:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-18 15:07 [PATCH wpan-next v3 00/11] ieee802154: Associations between devices Miquel Raynal
2023-09-18 15:07 ` Miquel Raynal [this message]
2023-09-18 15:08 ` [PATCH wpan-next v3 02/11] ieee802154: Internal PAN management Miquel Raynal
2023-09-20 18:08   ` Stefan Schmidt
2023-09-22 15:18     ` Miquel Raynal
2023-09-18 15:08 ` [PATCH wpan-next v3 03/11] ieee802154: Add support for user association requests Miquel Raynal
2023-09-18 15:08 ` [PATCH wpan-next v3 04/11] mac802154: Handle associating Miquel Raynal
2023-09-18 15:08 ` [PATCH wpan-next v3 05/11] ieee802154: Add support for user disassociation requests Miquel Raynal
2023-09-18 15:08 ` [PATCH wpan-next v3 06/11] mac802154: Handle disassociations Miquel Raynal
2023-09-18 15:08 ` [PATCH wpan-next v3 07/11] mac802154: Handle association requests from peers Miquel Raynal
2023-09-18 15:08 ` [PATCH wpan-next v3 08/11] ieee802154: Add support for limiting the number of associated devices Miquel Raynal
2023-09-18 15:08 ` [PATCH wpan-next v3 09/11] mac802154: Follow " Miquel Raynal
2023-09-18 15:08 ` [PATCH wpan-next v3 10/11] mac802154: Handle disassociation notifications from peers Miquel Raynal
2023-09-18 15:08 ` [PATCH wpan-next v3 11/11] ieee802154: Give the user the association list Miquel Raynal
2023-09-19  3:10   ` kernel test robot
2023-09-19  7:32     ` Miquel Raynal
2023-09-18 15:18 ` [PATCH wpan-next v3 00/11] ieee802154: Associations between devices Miquel Raynal
2023-09-20 18:46 ` Stefan Schmidt
2023-09-22 15:19   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230918150809.275058-2-miquel.raynal@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=alex.aring@gmail.com \
    --cc=davem@davemloft.net \
    --cc=david.girault@qorvo.com \
    --cc=edumazet@google.com \
    --cc=frederic.blain@qorvo.com \
    --cc=guilhem.imberton@qorvo.com \
    --cc=kuba@kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nico@ni.fr.eu.org \
    --cc=pabeni@redhat.com \
    --cc=romuald.despres@qorvo.com \
    --cc=stefan@datenfreihafen.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.