All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: Marek Vasut <marex@denx.de>, Liu Ying <victor.liu@nxp.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	patchwork-lst@pengutronix.de
Subject: [PATCH 1/5] drm: lcdif: improve burst size configuration comment
Date: Wed, 20 Sep 2023 12:31:22 +0200	[thread overview]
Message-ID: <20230920103126.2759601-2-l.stach@pengutronix.de> (raw)
In-Reply-To: <20230920103126.2759601-1-l.stach@pengutronix.de>

The comment regarding AXI bust size configuration is a bit hard
to read. Improve the wording somewhat.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/gpu/drm/mxsfb/lcdif_kms.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c b/drivers/gpu/drm/mxsfb/lcdif_kms.c
index 2541d2de4e45..f5bfe8b52920 100644
--- a/drivers/gpu/drm/mxsfb/lcdif_kms.c
+++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c
@@ -329,12 +329,12 @@ static void lcdif_set_mode(struct lcdif_drm_private *lcdif, u32 bus_flags)
 	       lcdif->base + LCDC_V8_CTRLDESCL0_1);
 
 	/*
-	 * Undocumented P_SIZE and T_SIZE register but those written in the
-	 * downstream kernel those registers control the AXI burst size. As of
-	 * now there are two known values:
+	 * Undocumented P_SIZE and T_SIZE bitfields written in the downstream
+	 * driver. Those bitfields control the AXI burst size. As of now there
+	 * are two known values:
 	 *  1 - 128Byte
 	 *  2 - 256Byte
-	 * Downstream set it to 256B burst size to improve the memory
+	 * Downstream sets this to 256B burst size to improve the memory access
 	 * efficiency so set it here too.
 	 */
 	ctrl = CTRLDESCL0_3_P_SIZE(2) | CTRLDESCL0_3_T_SIZE(2) |
-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Lucas Stach <l.stach@pengutronix.de>
To: Marek Vasut <marex@denx.de>, Liu Ying <victor.liu@nxp.com>
Cc: linux-arm-kernel@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	patchwork-lst@pengutronix.de
Subject: [PATCH 1/5] drm: lcdif: improve burst size configuration comment
Date: Wed, 20 Sep 2023 12:31:22 +0200	[thread overview]
Message-ID: <20230920103126.2759601-2-l.stach@pengutronix.de> (raw)
In-Reply-To: <20230920103126.2759601-1-l.stach@pengutronix.de>

The comment regarding AXI bust size configuration is a bit hard
to read. Improve the wording somewhat.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/gpu/drm/mxsfb/lcdif_kms.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c b/drivers/gpu/drm/mxsfb/lcdif_kms.c
index 2541d2de4e45..f5bfe8b52920 100644
--- a/drivers/gpu/drm/mxsfb/lcdif_kms.c
+++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c
@@ -329,12 +329,12 @@ static void lcdif_set_mode(struct lcdif_drm_private *lcdif, u32 bus_flags)
 	       lcdif->base + LCDC_V8_CTRLDESCL0_1);
 
 	/*
-	 * Undocumented P_SIZE and T_SIZE register but those written in the
-	 * downstream kernel those registers control the AXI burst size. As of
-	 * now there are two known values:
+	 * Undocumented P_SIZE and T_SIZE bitfields written in the downstream
+	 * driver. Those bitfields control the AXI burst size. As of now there
+	 * are two known values:
 	 *  1 - 128Byte
 	 *  2 - 256Byte
-	 * Downstream set it to 256B burst size to improve the memory
+	 * Downstream sets this to 256B burst size to improve the memory access
 	 * efficiency so set it here too.
 	 */
 	ctrl = CTRLDESCL0_3_P_SIZE(2) | CTRLDESCL0_3_T_SIZE(2) |
-- 
2.39.2


  reply	other threads:[~2023-09-20 10:32 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20 10:31 [PATCH 0/5] imx-lcdif modeset changes Lucas Stach
2023-09-20 10:31 ` Lucas Stach
2023-09-20 10:31 ` Lucas Stach [this message]
2023-09-20 10:31   ` [PATCH 1/5] drm: lcdif: improve burst size configuration comment Lucas Stach
2023-09-20 10:59   ` Marco Felsch
2023-09-20 10:59     ` Marco Felsch
2023-09-20 17:30   ` Marek Vasut
2023-09-20 17:30     ` Marek Vasut
2023-09-20 10:31 ` [PATCH 2/5] drm: lcdif: move controller enable into atomic_flush Lucas Stach
2023-09-20 10:31   ` Lucas Stach
2023-09-20 17:31   ` Marek Vasut
2023-09-20 17:31     ` Marek Vasut
2023-09-21  7:13   ` Ying Liu
2023-09-21  7:13     ` Ying Liu
2023-09-21  7:55     ` Lucas Stach
2023-09-21  7:55       ` Lucas Stach
2023-09-21  8:18       ` Ying Liu
2023-09-21  8:18         ` Ying Liu
2023-09-21  8:56         ` Lucas Stach
2023-09-21  8:56           ` Lucas Stach
2023-09-21  9:14           ` Ying Liu
2023-09-21  9:14             ` Ying Liu
2023-09-20 10:31 ` [PATCH 3/5] drm: lcdif: remove superfluous setup of framebuffer DMA address Lucas Stach
2023-09-20 10:31   ` Lucas Stach
2023-09-20 17:32   ` Marek Vasut
2023-09-20 17:32     ` Marek Vasut
2023-09-20 10:31 ` [PATCH 4/5] drm: lcdif: move pitch setup to plane atomic update Lucas Stach
2023-09-20 10:31   ` Lucas Stach
2023-09-20 17:32   ` Marek Vasut
2023-09-20 17:32     ` Marek Vasut
2023-09-20 10:31 ` [PATCH 5/5] drm: lcdif: force modeset when FB format changes Lucas Stach
2023-09-20 10:31   ` Lucas Stach
2023-09-20 17:33   ` Marek Vasut
2023-09-20 17:33     ` Marek Vasut
2023-09-21  7:34   ` Ying Liu
2023-09-21  7:34     ` Ying Liu
2023-09-21  7:59     ` Lucas Stach
2023-09-21  7:59       ` Lucas Stach
2023-09-21  8:30       ` Ying Liu
2023-09-21  8:30         ` Ying Liu
2023-09-21  6:55 ` [PATCH 0/5] imx-lcdif modeset changes Ying Liu
2023-09-21  6:55   ` Ying Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230920103126.2759601-2-l.stach@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=marex@denx.de \
    --cc=patchwork-lst@pengutronix.de \
    --cc=victor.liu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.