All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@kernel.org>
To: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>
Cc: Song Liu <song@kernel.org>,
	bpf@vger.kernel.org, Martin KaFai Lau <kafai@fb.com>,
	Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@chromium.org>,
	Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
	Hou Tao <houtao1@huawei.com>, Daniel Xu <dxu@dxuuu.xyz>
Subject: [PATCHv3 bpf-next 1/9] bpf: Count stats for kprobe_multi programs
Date: Wed, 20 Sep 2023 23:31:37 +0200	[thread overview]
Message-ID: <20230920213145.1941596-2-jolsa@kernel.org> (raw)
In-Reply-To: <20230920213145.1941596-1-jolsa@kernel.org>

Adding support to gather missed stats for kprobe_multi
programs due to bpf_prog_active protection.

Reviewed-and-tested-by: Song Liu <song@kernel.org>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 kernel/trace/bpf_trace.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
index a7264b2c17ad..279a3d370812 100644
--- a/kernel/trace/bpf_trace.c
+++ b/kernel/trace/bpf_trace.c
@@ -2710,6 +2710,7 @@ kprobe_multi_link_prog_run(struct bpf_kprobe_multi_link *link,
 	int err;
 
 	if (unlikely(__this_cpu_inc_return(bpf_prog_active) != 1)) {
+		bpf_prog_inc_misses_counter(link->link.prog);
 		err = 0;
 		goto out;
 	}
-- 
2.41.0


  reply	other threads:[~2023-09-20 21:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20 21:31 [PATCHv3 bpf-next 0/9] bpf: Add missed stats for kprobes Jiri Olsa
2023-09-20 21:31 ` Jiri Olsa [this message]
2023-09-20 21:31 ` [PATCHv3 bpf-next 2/9] bpf: Add missed value to kprobe_multi link info Jiri Olsa
2023-09-21 18:52   ` Song Liu
2023-09-23  8:21     ` Jiri Olsa
2023-09-20 21:31 ` [PATCHv3 bpf-next 3/9] bpf: Add missed value to kprobe perf " Jiri Olsa
2023-09-20 21:31 ` [PATCHv3 bpf-next 4/9] bpf: Count missed stats in trace_call_bpf Jiri Olsa
2023-09-20 21:31 ` [PATCHv3 bpf-next 5/9] bpftool: Display missed count for kprobe_multi link Jiri Olsa
2023-09-20 21:31 ` [PATCHv3 bpf-next 6/9] bpftool: Display missed count for kprobe perf link Jiri Olsa
2023-09-20 21:31 ` [PATCHv3 bpf-next 7/9] selftests/bpf: Add test for missed counts of perf event link kprobe Jiri Olsa
2023-09-20 21:31 ` [PATCHv3 bpf-next 8/9] selftests/bpf: Add test for recursion " Jiri Olsa
2023-09-20 21:31 ` [PATCHv3 bpf-next 9/9] selftests/bpf: Add test for recursion counts of perf event link tracepoint Jiri Olsa
2023-09-25 23:50 ` [PATCHv3 bpf-next 0/9] bpf: Add missed stats for kprobes patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230920213145.1941596-2-jolsa@kernel.org \
    --to=jolsa@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=dxu@dxuuu.xyz \
    --cc=haoluo@google.com \
    --cc=houtao1@huawei.com \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@chromium.org \
    --cc=sdf@google.com \
    --cc=song@kernel.org \
    --cc=songliubraving@fb.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.