All of lore.kernel.org
 help / color / mirror / Atom feed
From: Drew Fustini <dfustini@baylibre.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jisheng Zhang <jszhang@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Guo Ren <guoren@kernel.org>, Fu Wei <wefu@redhat.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Conor Dooley <conor@kernel.org>
Cc: Robert Nelson <robertcnelson@beagleboard.org>,
	Jason Kridner <jkridner@beagleboard.org>,
	Xi Ruoyao <xry111@xry111.site>, Han Gao <gaohan@iscas.ac.cn>,
	Icenowy Zheng <uwu@icenowy.me>,
	linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	Drew Fustini <dfustini@baylibre.com>
Subject: [PATCH 2/6] mmc: sdhci: add __sdhci_execute_tuning() to header
Date: Thu, 21 Sep 2023 18:49:49 -0700	[thread overview]
Message-ID: <20230921-th1520-mmc-v1-2-49f76c274fb3@baylibre.com> (raw)
In-Reply-To: <20230921-th1520-mmc-v1-0-49f76c274fb3@baylibre.com>

Expose __sdhci_execute_tuning() so that it can be called from the
mmc host controller drivers.

In the sdhci-of-dwcmshc driver, sdhci_dwcmshc_th1520_ops sets
platform_execute_tuning to th1520_execute_tuning(). That function has
to manipulate phy registers before tuning can be performed. To avoid
copying the code verbatim from __sdhci_execute_tuning() into
th1520_execute_tuning(), make it possible for __sdhci_execute_tuning()
to be called from sdhci-of-dwcmshc.

Signed-off-by: Drew Fustini <dfustini@baylibre.com>
---
 drivers/mmc/host/sdhci.c | 2 +-
 drivers/mmc/host/sdhci.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index ff41aa56564e..fd607058d176 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -2841,7 +2841,7 @@ void sdhci_send_tuning(struct sdhci_host *host, u32 opcode)
 }
 EXPORT_SYMBOL_GPL(sdhci_send_tuning);
 
-static int __sdhci_execute_tuning(struct sdhci_host *host, u32 opcode)
+int __sdhci_execute_tuning(struct sdhci_host *host, u32 opcode)
 {
 	int i;
 
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index f219bdea8f28..a20864fc0641 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -793,6 +793,7 @@ void sdhci_set_bus_width(struct sdhci_host *host, int width);
 void sdhci_reset(struct sdhci_host *host, u8 mask);
 void sdhci_set_uhs_signaling(struct sdhci_host *host, unsigned timing);
 int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode);
+int __sdhci_execute_tuning(struct sdhci_host *host, u32 opcode);
 void sdhci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios);
 int sdhci_start_signal_voltage_switch(struct mmc_host *mmc,
 				      struct mmc_ios *ios);

-- 
2.34.1


WARNING: multiple messages have this Message-ID (diff)
From: Drew Fustini <dfustini@baylibre.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Jisheng Zhang <jszhang@kernel.org>,
	 Adrian Hunter <adrian.hunter@intel.com>,
	Guo Ren <guoren@kernel.org>,  Fu Wei <wefu@redhat.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	 Conor Dooley <conor@kernel.org>
Cc: devicetree@vger.kernel.org, Drew Fustini <dfustini@baylibre.com>,
	Han Gao <gaohan@iscas.ac.cn>,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Robert Nelson <robertcnelson@beagleboard.org>,
	Jason Kridner <jkridner@beagleboard.org>,
	Xi Ruoyao <xry111@xry111.site>,
	linux-riscv@lists.infradead.org
Subject: [PATCH 2/6] mmc: sdhci: add __sdhci_execute_tuning() to header
Date: Thu, 21 Sep 2023 18:49:49 -0700	[thread overview]
Message-ID: <20230921-th1520-mmc-v1-2-49f76c274fb3@baylibre.com> (raw)
In-Reply-To: <20230921-th1520-mmc-v1-0-49f76c274fb3@baylibre.com>

Expose __sdhci_execute_tuning() so that it can be called from the
mmc host controller drivers.

In the sdhci-of-dwcmshc driver, sdhci_dwcmshc_th1520_ops sets
platform_execute_tuning to th1520_execute_tuning(). That function has
to manipulate phy registers before tuning can be performed. To avoid
copying the code verbatim from __sdhci_execute_tuning() into
th1520_execute_tuning(), make it possible for __sdhci_execute_tuning()
to be called from sdhci-of-dwcmshc.

Signed-off-by: Drew Fustini <dfustini@baylibre.com>
---
 drivers/mmc/host/sdhci.c | 2 +-
 drivers/mmc/host/sdhci.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index ff41aa56564e..fd607058d176 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -2841,7 +2841,7 @@ void sdhci_send_tuning(struct sdhci_host *host, u32 opcode)
 }
 EXPORT_SYMBOL_GPL(sdhci_send_tuning);
 
-static int __sdhci_execute_tuning(struct sdhci_host *host, u32 opcode)
+int __sdhci_execute_tuning(struct sdhci_host *host, u32 opcode)
 {
 	int i;
 
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index f219bdea8f28..a20864fc0641 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -793,6 +793,7 @@ void sdhci_set_bus_width(struct sdhci_host *host, int width);
 void sdhci_reset(struct sdhci_host *host, u8 mask);
 void sdhci_set_uhs_signaling(struct sdhci_host *host, unsigned timing);
 int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode);
+int __sdhci_execute_tuning(struct sdhci_host *host, u32 opcode);
 void sdhci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios);
 int sdhci_start_signal_voltage_switch(struct mmc_host *mmc,
 				      struct mmc_ios *ios);

-- 
2.34.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2023-09-22  1:51 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-22  1:49 [PATCH 0/6] RISC-V: Add eMMC support for TH1520 boards Drew Fustini
2023-09-22  1:49 ` Drew Fustini
2023-09-22  1:49 ` [PATCH 1/6] dt-bindings: mmc: sdhci-of-dwcmhsc: Add T-Head TH1520 support Drew Fustini
2023-09-22  1:49   ` Drew Fustini
2023-09-22  9:57   ` Conor Dooley
2023-09-22  9:57     ` Conor Dooley
2023-09-22 15:18     ` Drew Fustini
2023-09-22 15:18       ` Drew Fustini
2023-09-23  8:10       ` Guo Ren
2023-09-23  8:10         ` Guo Ren
2023-09-24 21:04         ` Drew Fustini
2023-09-24 21:04           ` Drew Fustini
2023-09-22  1:49 ` Drew Fustini [this message]
2023-09-22  1:49   ` [PATCH 2/6] mmc: sdhci: add __sdhci_execute_tuning() to header Drew Fustini
2023-09-25 10:21   ` Adrian Hunter
2023-09-25 10:21     ` Adrian Hunter
2023-09-25 10:23     ` Xi Ruoyao
2023-09-25 10:23       ` Xi Ruoyao
2023-09-25 10:31       ` Adrian Hunter
2023-09-25 10:31         ` Adrian Hunter
2023-09-25 14:41     ` Drew Fustini
2023-09-25 14:41       ` Drew Fustini
2023-09-22  1:49 ` [PATCH 3/6] mmc: sdhci-of-dwcmshc: Add support for T-Head TH1520 Drew Fustini
2023-09-22  1:49   ` Drew Fustini
2023-09-25 10:35   ` Adrian Hunter
2023-09-25 10:35     ` Adrian Hunter
2023-09-25 14:43     ` Drew Fustini
2023-09-25 14:43       ` Drew Fustini
2023-10-04 16:19   ` Jisheng Zhang
2023-10-04 16:19     ` Jisheng Zhang
2023-10-04 19:12     ` Drew Fustini
2023-10-04 19:12       ` Drew Fustini
2023-09-22  1:49 ` [PATCH 4/6] riscv: dts: thead: Add TH1520 mmc controller and sdhci clock Drew Fustini
2023-09-22  1:49   ` Drew Fustini
2023-09-22  1:49 ` [PATCH 5/6] riscv: dts: thead: Enable BeagleV Ahead eMMC controller Drew Fustini
2023-09-22  1:49   ` Drew Fustini
2023-09-22  1:49 ` [PATCH 6/6] riscv: dts: thead: Enable LicheePi 4A " Drew Fustini
2023-09-22  1:49   ` Drew Fustini
2023-09-22 11:41 ` [PATCH 0/6] RISC-V: Add eMMC support for TH1520 boards Xi Ruoyao
2023-09-22 11:41   ` Xi Ruoyao
2023-09-22 16:23   ` Drew Fustini
2023-09-22 16:23     ` Drew Fustini
2023-09-23 16:33     ` Xi Ruoyao
2023-09-23 16:33       ` Xi Ruoyao
2023-09-23  0:11   ` Icenowy Zheng
2023-09-23  0:11     ` Icenowy Zheng
2023-09-22 19:08 ` Robert Nelson
2023-09-22 19:08   ` Robert Nelson
2023-09-22 22:48   ` Robert Nelson
2023-09-22 22:48     ` Robert Nelson
2023-10-03  4:37     ` Drew Fustini
2023-10-03  4:37       ` Drew Fustini
2023-10-04 11:30       ` Jisheng Zhang
2023-10-04 11:30         ` Jisheng Zhang
2023-10-04 13:02         ` Lad, Prabhakar
2023-10-04 13:02           ` Lad, Prabhakar
2023-10-04 13:49           ` Robin Murphy
2023-10-04 13:49             ` Robin Murphy
2023-10-04 14:02             ` Icenowy Zheng
2023-10-04 14:02               ` Icenowy Zheng
2023-10-04 14:18               ` Robin Murphy
2023-10-04 14:18                 ` Robin Murphy
2023-10-04 14:46                 ` Icenowy Zheng
2023-10-04 14:46                   ` Icenowy Zheng
2023-10-04 14:58                 ` Icenowy Zheng
2023-10-04 14:58                   ` Icenowy Zheng
2023-10-04 16:03                 ` Lad, Prabhakar
2023-10-04 16:03                   ` Lad, Prabhakar
2023-10-04 17:16                   ` Lad, Prabhakar
2023-10-04 17:16                     ` Lad, Prabhakar
2023-10-04 18:49                     ` Samuel Holland
2023-10-04 18:49                       ` Samuel Holland
2023-10-04 19:38                       ` Robin Murphy
2023-10-04 19:38                         ` Robin Murphy
2023-10-04 20:47                         ` Lad, Prabhakar
2023-10-04 20:47                           ` Lad, Prabhakar
2023-10-05  6:57                     ` Christoph Hellwig
2023-10-05  6:57                       ` Christoph Hellwig
2023-10-04 14:06             ` Jisheng Zhang
2023-10-04 14:06               ` Jisheng Zhang
2023-10-04 15:27               ` Geert Uytterhoeven
2023-10-04 15:27                 ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230921-th1520-mmc-v1-2-49f76c274fb3@baylibre.com \
    --to=dfustini@baylibre.com \
    --cc=adrian.hunter@intel.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gaohan@iscas.ac.cn \
    --cc=guoren@kernel.org \
    --cc=jkridner@beagleboard.org \
    --cc=jszhang@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robertcnelson@beagleboard.org \
    --cc=robh+dt@kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=uwu@icenowy.me \
    --cc=wefu@redhat.com \
    --cc=xry111@xry111.site \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.