All of lore.kernel.org
 help / color / mirror / Atom feed
From: roynatech@gmail.com
To: johannes@sipsolutions.net
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] mac80211: fix station hash table max_size config dependency
Date: Sat, 23 Sep 2023 03:28:34 +0000	[thread overview]
Message-ID: <20230923032834.9694-1-roynatech@gmail.com> (raw)

From: roynatech2544 <whiteshell2544@naver.com>

Commit ebd82b3 ("mac80211: make station hash table max_size configurable") introduced config
MAC80211_STA_HASH_MAX_SIZE, which is defined unconditionally even if MAC80211 is not set.
It doesn't look like it is dependent of MAC80211_DEBUG_MENU either, as its only user is sta_info.c
which is compiled unconditionally when MAC80211 != n. And without this config set somewhere, compile
would error out.

Make it depend on MAC80211 to correctly hide the config when MAC80211=n

Fixes: ebd82b3 ("mac80211: make station hash table max_size configurable")
Signed-off-by: roynatech2544 <whiteshell2544@naver.com>

diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
index 51ec8256b..b9dc520b6 100644
--- a/net/mac80211/Kconfig
+++ b/net/mac80211/Kconfig
@@ -296,7 +296,8 @@ config MAC80211_DEBUG_COUNTERS
 	  If unsure, say N.
 
 config MAC80211_STA_HASH_MAX_SIZE
-	int "Station hash table maximum size" if MAC80211_DEBUG_MENU
+	int "Station hash table maximum size"
+	depends on MAC80211
 	default 0
 	help
 	  Setting this option to a low value (e.g. 4) allows testing the
-- 
2.34.1


             reply	other threads:[~2023-09-23  3:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-23  3:28 roynatech [this message]
2023-09-26 10:47 ` [PATCH] mac80211: fix station hash table max_size config dependency Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230923032834.9694-1-roynatech@gmail.com \
    --to=roynatech@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.