From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: linux-media@vger.kernel.org Cc: Dafna Hirschfeld <dafna@fastmail.com>, Paul Elder <paul.elder@ideasonboard.com>, linux-rockchip@lists.infradead.org Subject: [PATCH v2 13/14] media: rkisp1: resizer: Improve debug message when configuring resizer Date: Mon, 25 Sep 2023 03:41:11 +0300 [thread overview] Message-ID: <20230925004112.22797-14-laurent.pinchart@ideasonboard.com> (raw) In-Reply-To: <20230925004112.22797-1-laurent.pinchart@ideasonboard.com> The debug messages that show the resizer configuration are only printed if the driver enables the resizer. This prevents checking the resizer configuration when the driver believes it should be disabled. Fix it by moving the dev_dbg() statements earlier. Also, combine the two debug prints into a single one to gather all the information in one place, which makes reading the log easier. While at it, use %u instead of %d to print unsigned values. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- .../media/platform/rockchip/rkisp1/rkisp1-resizer.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c index 1741ada7032b..92ae2d2e0f12 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c @@ -309,17 +309,17 @@ static void rkisp1_rsz_config(struct rkisp1_resizer *rsz, src_c.width = src_y.width / src_yuv_info->hdiv; src_c.height = src_y.height / src_yuv_info->vdiv; + dev_dbg(rsz->rkisp1->dev, + "stream %u rsz/scale: Y %ux%u -> %ux%u, CbCr %ux%u -> %ux%u\n", + rsz->id, sink_y->width, sink_y->height, + src_fmt->width, src_fmt->height, + sink_c.width, sink_c.height, src_c.width, src_c.height); + if (sink_c.width == src_c.width && sink_c.height == src_c.height) { rkisp1_rsz_disable(rsz, when); return; } - dev_dbg(rsz->rkisp1->dev, "stream %d rsz/scale: %dx%d -> %dx%d\n", - rsz->id, sink_y->width, sink_y->height, - src_fmt->width, src_fmt->height); - dev_dbg(rsz->rkisp1->dev, "chroma scaling %dx%d -> %dx%d\n", - sink_c.width, sink_c.height, src_c.width, src_c.height); - /* set values in the hw */ rkisp1_rsz_config_regs(rsz, sink_y, &sink_c, &src_y, &src_c, when); } -- Regards, Laurent Pinchart _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: linux-media@vger.kernel.org Cc: Dafna Hirschfeld <dafna@fastmail.com>, Paul Elder <paul.elder@ideasonboard.com>, linux-rockchip@lists.infradead.org Subject: [PATCH v2 13/14] media: rkisp1: resizer: Improve debug message when configuring resizer Date: Mon, 25 Sep 2023 03:41:11 +0300 [thread overview] Message-ID: <20230925004112.22797-14-laurent.pinchart@ideasonboard.com> (raw) In-Reply-To: <20230925004112.22797-1-laurent.pinchart@ideasonboard.com> The debug messages that show the resizer configuration are only printed if the driver enables the resizer. This prevents checking the resizer configuration when the driver believes it should be disabled. Fix it by moving the dev_dbg() statements earlier. Also, combine the two debug prints into a single one to gather all the information in one place, which makes reading the log easier. While at it, use %u instead of %d to print unsigned values. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- .../media/platform/rockchip/rkisp1/rkisp1-resizer.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c index 1741ada7032b..92ae2d2e0f12 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-resizer.c @@ -309,17 +309,17 @@ static void rkisp1_rsz_config(struct rkisp1_resizer *rsz, src_c.width = src_y.width / src_yuv_info->hdiv; src_c.height = src_y.height / src_yuv_info->vdiv; + dev_dbg(rsz->rkisp1->dev, + "stream %u rsz/scale: Y %ux%u -> %ux%u, CbCr %ux%u -> %ux%u\n", + rsz->id, sink_y->width, sink_y->height, + src_fmt->width, src_fmt->height, + sink_c.width, sink_c.height, src_c.width, src_c.height); + if (sink_c.width == src_c.width && sink_c.height == src_c.height) { rkisp1_rsz_disable(rsz, when); return; } - dev_dbg(rsz->rkisp1->dev, "stream %d rsz/scale: %dx%d -> %dx%d\n", - rsz->id, sink_y->width, sink_y->height, - src_fmt->width, src_fmt->height); - dev_dbg(rsz->rkisp1->dev, "chroma scaling %dx%d -> %dx%d\n", - sink_c.width, sink_c.height, src_c.width, src_c.height); - /* set values in the hw */ rkisp1_rsz_config_regs(rsz, sink_y, &sink_c, &src_y, &src_c, when); } -- Regards, Laurent Pinchart
next prev parent reply other threads:[~2023-09-25 0:41 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-25 0:40 [PATCH v2 00/14] media: rkisp1: Various cleanups and fixes Laurent Pinchart 2023-09-25 0:40 ` Laurent Pinchart 2023-09-25 0:40 ` [PATCH v2 01/14] MAINTAINERS: Add co-maintainer for the rkisp1 driver Laurent Pinchart 2023-09-25 0:40 ` Laurent Pinchart 2023-09-25 6:35 ` Hans Verkuil 2023-09-25 6:35 ` Hans Verkuil 2023-09-25 0:41 ` [PATCH v2 02/14] media: rkisp1: resizer: Use V4L2 subdev active state Laurent Pinchart 2023-09-25 0:41 ` Laurent Pinchart 2023-09-25 0:41 ` [PATCH v2 03/14] media: rkisp1: isp: " Laurent Pinchart 2023-09-25 0:41 ` Laurent Pinchart 2023-09-25 0:41 ` [PATCH v2 04/14] media: rkisp1: csi: " Laurent Pinchart 2023-09-25 0:41 ` Laurent Pinchart 2023-09-25 0:41 ` [PATCH v2 05/14] media: rkisp1: Convert hex constants to lowercase Laurent Pinchart 2023-09-25 0:41 ` Laurent Pinchart 2023-09-25 0:41 ` [PATCH v2 06/14] media: rkisp1: Constify rkisp1_v12_params_ops Laurent Pinchart 2023-09-25 0:41 ` Laurent Pinchart 2023-09-25 0:41 ` [PATCH v2 07/14] media: rkisp1: Fix line stride calculation Laurent Pinchart 2023-09-25 0:41 ` Laurent Pinchart 2023-09-25 0:41 ` [PATCH v2 08/14] media: rkisp1: Remove dual crop control register from config structure Laurent Pinchart 2023-09-25 0:41 ` Laurent Pinchart 2023-09-25 0:41 ` [PATCH v2 09/14] media: rkisp1: Program RKISP1_CIF_MI_SP_Y_PIC_SIZE register Laurent Pinchart 2023-09-25 0:41 ` Laurent Pinchart 2023-09-25 0:41 ` [PATCH v2 10/14] media: rkisp1: resizer: Constify argument and local variables Laurent Pinchart 2023-09-25 0:41 ` Laurent Pinchart 2023-09-25 0:41 ` [PATCH v2 11/14] media: rkisp1: resizer: Use v4l2_area instead of v4l2_rect to store size Laurent Pinchart 2023-09-25 0:41 ` Laurent Pinchart 2023-09-25 0:41 ` [PATCH v2 12/14] media: rkisp1: resizer: Drop unneeded local variable Laurent Pinchart 2023-09-25 0:41 ` Laurent Pinchart 2023-09-25 0:41 ` Laurent Pinchart [this message] 2023-09-25 0:41 ` [PATCH v2 13/14] media: rkisp1: resizer: Improve debug message when configuring resizer Laurent Pinchart 2023-09-25 0:41 ` [PATCH v2 14/14] media: rkisp1: resizer: Fix resizer disable check when starting stream Laurent Pinchart 2023-09-25 0:41 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230925004112.22797-14-laurent.pinchart@ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=dafna@fastmail.com \ --cc=linux-media@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=paul.elder@ideasonboard.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.