All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Eric Blake" <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: balaton@eik.bme.hu, andrey.drobyshev@virtuozzo.com,
	peter.maydell@linaro.org, Eric Blake <eblake@redhat.com>
Subject: [PATCH v2 2/3] maint: Tweak comments in mailmap regarding SPF
Date: Wed, 27 Sep 2023 09:38:18 -0500	[thread overview]
Message-ID: <20230927143815.3397386-7-eblake@redhat.com> (raw)
In-Reply-To: <20230927143815.3397386-5-eblake@redhat.com>

From: Eric Blake <eblake@redhat.com>

Documenting that we should not add new lines to work around SPF
rewrites sounds foreboding; the intent is instead that new lines here
are okay, but indicate a second problem elsewhere in our build process
that we should also consider fixing at the same time, to keep the
section from growing without bounds.  While we have been doing that
for qemu-devel for a while, we jut recently fixed that for qemu-block:
https://git.linaro.org/people/pmaydell/misc-scripts.git/commit/?id=f9a317392

Mentioning DMARC alongside SPF may also help people grep for this
scenario, as well as documenting the 'git config' workaround that can
be used by submitters to avoid the munging issue in the first place.

Note the subtelty: 'git commit' sets authorship information based on
user.name and user.email (where name is usually unquoted); while 'git
format-patch' includes a body 'From:' line only when sendemail.from is
present but differs from authorship information.  Hence the use of
quotes in sendemail.from (not a semantic change to email, but enough
of a difference to add the body 'From:').

Fixes: 3bd2608d ("maint: Add .mailmap entries for patches claiming list authorship")
CC: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Eric Blake <eblake@redhat.com>
---

Once again, sending this patch to the list with my git config
temporarily changed.  I used a command line:
 git config sendemail.from '"Eric Blake" <eblakeWredhat.com>'
which turned into this in my .git/config:
[sendemail]
  from = \"Eric Blake\" <eblake@redhat.com>

My editor window in 'git send-email' doesn't show the body from line,
but hopefully the list archives do (that is, the addition of a body
From appears to be a post-processing step done by git after my editor
window closes but before the final mail is actually shoved out my MUA)
---
 .mailmap | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/.mailmap b/.mailmap
index 04a7feb005b..fadf6e74506 100644
--- a/.mailmap
+++ b/.mailmap
@@ -40,7 +40,19 @@ Nick Hudson <hnick@vmware.com> hnick@vmware.com <hnick@vmware.com>
 # for the cvs2svn initialization commit e63c3dc74bf.

 # Next, translate a few commits where mailman rewrote the From: line due
-# to strict SPF, although we prefer to avoid adding more entries like that.
+# to strict SPF and DMARC.  Usually, our build process should be flagging
+# commits like these before maintainer merges; if you find the need to add
+# a line here, please also report a bug against the part of the build
+# process that let the mis-attribution slip through in the first place.
+#
+# If the mailing list munges your emails, use:
+#   git config sendemail.from '"Your Name" <your.email@example.com>'
+# the use of "" in that line will differ from the typically unquoted
+# 'git config user.name', which in turn is sufficient for 'git send-email'
+# to add an extra From: line in the body of your email that takes
+# precedence over any munged From: in the mail's headers.
+# See https://lists.openembedded.org/g/openembedded-core/message/166515
+# and https://lists.gnu.org/archive/html/qemu-devel/2023-09/msg06784.html
 Ed Swierk <eswierk@skyportsystems.com> Ed Swierk via Qemu-devel <qemu-devel@nongnu.org>
 Ian McKellar <ianloic@google.com> Ian McKellar via Qemu-devel <qemu-devel@nongnu.org>
 Julia Suvorova <jusual@mail.ru> Julia Suvorova via Qemu-devel <qemu-devel@nongnu.org>
-- 
2.41.0



  parent reply	other threads:[~2023-09-27 14:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-27 14:38 [PATCH v2 0/3] Another attempt at mailmap patches Eric Blake
2023-09-27 14:38 ` [PATCH v2 1/3] mailmap: Fix Andrey Drobyshev author email Eric Blake
2023-09-27 14:38 ` Eric Blake [this message]
2023-09-27 14:51   ` [PATCH v2 2/3] maint: Tweak comments in mailmap regarding SPF Eric Blake
2023-09-27 14:55   ` Peter Maydell
2023-09-27 14:38 ` [PATCH v2 3/3] mailmap: Fix BALATON Zoltan author email Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230927143815.3397386-7-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=andrey.drobyshev@virtuozzo.com \
    --cc=balaton@eik.bme.hu \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.