From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> To: "Rafael J. Wysocki" <rafael@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org> Cc: Guillaume La Roque <glaroque@baylibre.com>, Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>, linux-pm@vger.kernel.org, linux-amlogic@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 01/31] thermal: amlogic: Convert to platform remove callback returning void Date: Wed, 27 Sep 2023 21:37:06 +0200 [thread overview] Message-ID: <20230927193736.2236447-2-u.kleine-koenig@pengutronix.de> (raw) In-Reply-To: <20230927193736.2236447-1-u.kleine-koenig@pengutronix.de> The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). amlogic_thermal_disable() always returned zero. Change it to return no value and then trivially convert the driver to .remove_new() and fix a whitespace inconsitency en passant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/thermal/amlogic_thermal.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c index 81ebbf6de0de..1426f1eb4ac6 100644 --- a/drivers/thermal/amlogic_thermal.c +++ b/drivers/thermal/amlogic_thermal.c @@ -167,13 +167,11 @@ static int amlogic_thermal_enable(struct amlogic_thermal *data) return 0; } -static int amlogic_thermal_disable(struct amlogic_thermal *data) +static void amlogic_thermal_disable(struct amlogic_thermal *data) { regmap_update_bits(data->regmap, TSENSOR_CFG_REG1, TSENSOR_CFG_REG1_ENABLE, 0); clk_disable_unprepare(data->clk); - - return 0; } static int amlogic_thermal_get_temp(struct thermal_zone_device *tz, int *temp) @@ -291,11 +289,11 @@ static int amlogic_thermal_probe(struct platform_device *pdev) return ret; } -static int amlogic_thermal_remove(struct platform_device *pdev) +static void amlogic_thermal_remove(struct platform_device *pdev) { struct amlogic_thermal *data = platform_get_drvdata(pdev); - return amlogic_thermal_disable(data); + amlogic_thermal_disable(data); } static int __maybe_unused amlogic_thermal_suspend(struct device *dev) @@ -321,8 +319,8 @@ static struct platform_driver amlogic_thermal_driver = { .pm = &amlogic_thermal_pm_ops, .of_match_table = of_amlogic_thermal_match, }, - .probe = amlogic_thermal_probe, - .remove = amlogic_thermal_remove, + .probe = amlogic_thermal_probe, + .remove_new = amlogic_thermal_remove, }; module_platform_driver(amlogic_thermal_driver); -- 2.40.1
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> To: "Rafael J. Wysocki" <rafael@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org> Cc: Guillaume La Roque <glaroque@baylibre.com>, Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>, linux-pm@vger.kernel.org, linux-amlogic@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 01/31] thermal: amlogic: Convert to platform remove callback returning void Date: Wed, 27 Sep 2023 21:37:06 +0200 [thread overview] Message-ID: <20230927193736.2236447-2-u.kleine-koenig@pengutronix.de> (raw) In-Reply-To: <20230927193736.2236447-1-u.kleine-koenig@pengutronix.de> The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). amlogic_thermal_disable() always returned zero. Change it to return no value and then trivially convert the driver to .remove_new() and fix a whitespace inconsitency en passant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/thermal/amlogic_thermal.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c index 81ebbf6de0de..1426f1eb4ac6 100644 --- a/drivers/thermal/amlogic_thermal.c +++ b/drivers/thermal/amlogic_thermal.c @@ -167,13 +167,11 @@ static int amlogic_thermal_enable(struct amlogic_thermal *data) return 0; } -static int amlogic_thermal_disable(struct amlogic_thermal *data) +static void amlogic_thermal_disable(struct amlogic_thermal *data) { regmap_update_bits(data->regmap, TSENSOR_CFG_REG1, TSENSOR_CFG_REG1_ENABLE, 0); clk_disable_unprepare(data->clk); - - return 0; } static int amlogic_thermal_get_temp(struct thermal_zone_device *tz, int *temp) @@ -291,11 +289,11 @@ static int amlogic_thermal_probe(struct platform_device *pdev) return ret; } -static int amlogic_thermal_remove(struct platform_device *pdev) +static void amlogic_thermal_remove(struct platform_device *pdev) { struct amlogic_thermal *data = platform_get_drvdata(pdev); - return amlogic_thermal_disable(data); + amlogic_thermal_disable(data); } static int __maybe_unused amlogic_thermal_suspend(struct device *dev) @@ -321,8 +319,8 @@ static struct platform_driver amlogic_thermal_driver = { .pm = &amlogic_thermal_pm_ops, .of_match_table = of_amlogic_thermal_match, }, - .probe = amlogic_thermal_probe, - .remove = amlogic_thermal_remove, + .probe = amlogic_thermal_probe, + .remove_new = amlogic_thermal_remove, }; module_platform_driver(amlogic_thermal_driver); -- 2.40.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-09-27 19:37 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-27 19:37 [PATCH 00/31] thermal: Convert to platform remove callback returning void Uwe Kleine-König 2023-09-27 19:37 ` Uwe Kleine-König 2023-09-27 19:37 ` Uwe Kleine-König 2023-09-27 19:37 ` Uwe Kleine-König [this message] 2023-09-27 19:37 ` [PATCH 01/31] thermal: amlogic: " Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 02/31] thermal: armada: " Uwe Kleine-König 2023-10-01 16:09 ` Miquel Raynal 2023-09-27 19:37 ` [PATCH 03/31] thermal: bcm2835: " Uwe Kleine-König 2023-09-27 19:37 ` Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 04/31] thermal: ns: " Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 05/31] thermal: da9062: " Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 06/31] thermal: dove: " Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 07/31] thermal: hisi: " Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 08/31] thermal: imx8mm: " Uwe Kleine-König 2023-09-27 19:37 ` Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 09/31] thermal: imx: " Uwe Kleine-König 2023-09-27 19:37 ` Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 10/31] thermal: int3400: " Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 11/31] thermal: int3401: " Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 12/31] thermal: int3402: " Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 13/31] thermal: int3403: " Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 14/31] thermal: int3406: " Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 15/31] thermal: k3_bandgap: " Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 16/31] thermal: k3_j72xx_bandgap: " Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 17/31] thermal: kirkwood: " Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 18/31] thermal: lvts: " Uwe Kleine-König 2023-09-27 19:37 ` Uwe Kleine-König 2023-09-28 11:13 ` AngeloGioacchino Del Regno 2023-09-28 11:13 ` AngeloGioacchino Del Regno 2023-09-27 19:37 ` [PATCH 19/31] thermal: tsens: " Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 20/31] thermal: rcar_gen3: " Uwe Kleine-König 2023-09-27 19:40 ` Wolfram Sang 2023-09-28 8:21 ` Geert Uytterhoeven 2023-09-28 15:26 ` Niklas Söderlund 2023-09-27 19:37 ` [PATCH 21/31] thermal: rcar: " Uwe Kleine-König 2023-09-27 19:40 ` Wolfram Sang 2023-09-28 8:22 ` Geert Uytterhoeven 2023-09-28 15:26 ` Niklas Söderlund 2023-09-27 19:37 ` [PATCH 22/31] thermal: rockchip: " Uwe Kleine-König 2023-09-27 19:37 ` Uwe Kleine-König 2023-09-27 19:37 ` Uwe Kleine-König 2023-10-01 22:53 ` Heiko Stuebner 2023-10-01 22:53 ` Heiko Stuebner 2023-10-01 22:53 ` Heiko Stuebner 2023-09-27 19:37 ` [PATCH 23/31] thermal: rzg2l: " Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 24/31] thermal: exynos_tmu: " Uwe Kleine-König 2023-09-27 19:37 ` Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 25/31] thermal: spear: " Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 26/31] thermal: sprd: " Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 27/31] thermal: stm: " Uwe Kleine-König 2023-09-27 19:37 ` Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 28/31] thermal: soctherm: " Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 29/31] thermal: tegra-bpmp: " Uwe Kleine-König 2023-09-27 19:37 ` [PATCH 30/31] thermal: ti-bandgap: " Uwe Kleine-König 2023-09-28 16:09 ` Dhruva Gole 2023-09-27 19:37 ` [PATCH 31/31] thermal: uniphier: " Uwe Kleine-König 2023-09-27 19:37 ` Uwe Kleine-König 2023-09-27 19:45 ` [PATCH 00/31] thermal: " Rafael J. Wysocki 2023-09-27 19:45 ` Rafael J. Wysocki 2023-09-27 19:45 ` Rafael J. Wysocki 2023-09-28 7:05 ` Daniel Lezcano 2023-09-28 7:05 ` Daniel Lezcano 2023-09-28 7:05 ` Daniel Lezcano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230927193736.2236447-2-u.kleine-koenig@pengutronix.de \ --to=u.kleine-koenig@pengutronix.de \ --cc=amitk@kernel.org \ --cc=daniel.lezcano@linaro.org \ --cc=glaroque@baylibre.com \ --cc=kernel@pengutronix.de \ --cc=linux-amlogic@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=rafael@kernel.org \ --cc=rui.zhang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.