All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nirmoy Das <nirmoy.das@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: matthew.d.roper@intel.com, andi.shyti@linux.intel.com,
	dri-devel@lists.freedesktop.org,
	Nirmoy Das <nirmoy.das@intel.com>
Subject: [PATCH v6 3/4] drm/i915: Reset steer semaphore for media GT on resume
Date: Wed, 27 Sep 2023 23:03:56 +0200	[thread overview]
Message-ID: <20230927210357.17461-3-nirmoy.das@intel.com> (raw)
In-Reply-To: <20230927210357.17461-1-nirmoy.das@intel.com>

During resume, the steer semaphore on GT1 was observed to be held. The
hardware team has confirmed the safety of clearing the steer semaphore
during driver load/resume, as no lock acquisitions can occur in this
process by other agents.

v2: reset on resume not in intel_gt_init().
v3: do the reset on intel_gt_resume_early()

Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_gt_pm.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
index dab73980c9f1..59cebf205b72 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
@@ -13,6 +13,7 @@
 #include "intel_engine_pm.h"
 #include "intel_gt.h"
 #include "intel_gt_clock_utils.h"
+#include "intel_gt_mcr.h"
 #include "intel_gt_pm.h"
 #include "intel_gt_print.h"
 #include "intel_gt_requests.h"
@@ -218,6 +219,17 @@ void intel_gt_pm_fini(struct intel_gt *gt)
 
 void intel_gt_resume_early(struct intel_gt *gt)
 {
+	/*
+	 * Reset the steer semaphore on GT1, as we have observed it
+	 * remaining held after a suspend operation. Confirmation
+	 * from the hardware team ensures the safety of resetting
+	 * the steer semaphore during driver load/resume, as there
+	 * are no lock acquisitions during this process by other
+	 * agents.
+	 */
+	if (MEDIA_VER(gt->i915) >= 13 && gt->type == GT_MEDIA)
+		intel_gt_mcr_lock_reset(gt);
+
 	intel_uncore_resume_early(gt->uncore);
 	intel_gt_check_and_clear_faults(gt);
 }
-- 
2.41.0


WARNING: multiple messages have this Message-ID (diff)
From: Nirmoy Das <nirmoy.das@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: matthew.d.roper@intel.com, dri-devel@lists.freedesktop.org,
	Nirmoy Das <nirmoy.das@intel.com>
Subject: [Intel-gfx] [PATCH v6 3/4] drm/i915: Reset steer semaphore for media GT on resume
Date: Wed, 27 Sep 2023 23:03:56 +0200	[thread overview]
Message-ID: <20230927210357.17461-3-nirmoy.das@intel.com> (raw)
In-Reply-To: <20230927210357.17461-1-nirmoy.das@intel.com>

During resume, the steer semaphore on GT1 was observed to be held. The
hardware team has confirmed the safety of clearing the steer semaphore
during driver load/resume, as no lock acquisitions can occur in this
process by other agents.

v2: reset on resume not in intel_gt_init().
v3: do the reset on intel_gt_resume_early()

Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_gt_pm.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
index dab73980c9f1..59cebf205b72 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
@@ -13,6 +13,7 @@
 #include "intel_engine_pm.h"
 #include "intel_gt.h"
 #include "intel_gt_clock_utils.h"
+#include "intel_gt_mcr.h"
 #include "intel_gt_pm.h"
 #include "intel_gt_print.h"
 #include "intel_gt_requests.h"
@@ -218,6 +219,17 @@ void intel_gt_pm_fini(struct intel_gt *gt)
 
 void intel_gt_resume_early(struct intel_gt *gt)
 {
+	/*
+	 * Reset the steer semaphore on GT1, as we have observed it
+	 * remaining held after a suspend operation. Confirmation
+	 * from the hardware team ensures the safety of resetting
+	 * the steer semaphore during driver load/resume, as there
+	 * are no lock acquisitions during this process by other
+	 * agents.
+	 */
+	if (MEDIA_VER(gt->i915) >= 13 && gt->type == GT_MEDIA)
+		intel_gt_mcr_lock_reset(gt);
+
 	intel_uncore_resume_early(gt->uncore);
 	intel_gt_check_and_clear_faults(gt);
 }
-- 
2.41.0


  parent reply	other threads:[~2023-09-27 21:11 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-27 21:03 [PATCH v6 1/4] drm/i915: Introduce intel_gt_mcr_lock_reset() Nirmoy Das
2023-09-27 21:03 ` [Intel-gfx] " Nirmoy Das
2023-09-27 21:03 ` [PATCH v6 2/4] drm/i915: Introduce the intel_gt_resume_early() Nirmoy Das
2023-09-27 21:03   ` [Intel-gfx] " Nirmoy Das
2023-09-28  7:24   ` Andi Shyti
2023-09-28  7:24     ` [Intel-gfx] " Andi Shyti
2023-09-28  8:30     ` Nirmoy Das
2023-09-28  8:30       ` [Intel-gfx] " Nirmoy Das
2023-09-27 21:03 ` Nirmoy Das [this message]
2023-09-27 21:03   ` [Intel-gfx] [PATCH v6 3/4] drm/i915: Reset steer semaphore for media GT on resume Nirmoy Das
2023-09-27 22:35   ` Matt Roper
2023-09-27 22:35     ` [Intel-gfx] " Matt Roper
2023-09-28  8:08     ` Nirmoy Das
2023-09-28  8:08       ` [Intel-gfx] " Nirmoy Das
2023-09-28  7:19   ` Andi Shyti
2023-09-28  7:19     ` [Intel-gfx] " Andi Shyti
2023-09-28  8:12     ` Nirmoy Das
2023-09-28  8:12       ` [Intel-gfx] " Nirmoy Das
2023-09-28 12:39       ` Andi Shyti
2023-09-28 12:39         ` [Intel-gfx] " Andi Shyti
2023-09-27 21:03 ` [PATCH v6 4/4] drm/i915/mtl: Skip MCR ops for ring fault register Nirmoy Das
2023-09-27 21:03   ` [Intel-gfx] " Nirmoy Das
2023-09-27 22:23 ` [PATCH v6 1/4] drm/i915: Introduce intel_gt_mcr_lock_reset() Matt Roper
2023-09-27 22:23   ` [Intel-gfx] " Matt Roper
2023-09-28  8:15   ` Nirmoy Das
2023-09-28  8:15     ` [Intel-gfx] " Nirmoy Das
2023-09-27 22:49 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v6,1/4] " Patchwork
2023-09-27 23:08 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-09-28  3:22 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v6,1/4] drm/i915: Introduce intel_gt_mcr_lock_reset() (rev2) Patchwork
2023-09-28  3:35 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-09-28  7:18 ` [PATCH v6 1/4] drm/i915: Introduce intel_gt_mcr_lock_reset() Andi Shyti
2023-09-28  7:18   ` [Intel-gfx] " Andi Shyti
2023-09-28  8:19   ` Nirmoy Das
2023-09-28  8:19     ` [Intel-gfx] " Nirmoy Das
2023-09-28 15:41 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v6,1/4] drm/i915: Introduce intel_gt_mcr_lock_reset() (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230927210357.17461-3-nirmoy.das@intel.com \
    --to=nirmoy.das@intel.com \
    --cc=andi.shyti@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.