All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: linux-kselftest@vger.kernel.org, "Shuah Khan" <shuah@kernel.org>,
	"Reinette Chatre" <reinette.chatre@intel.com>,
	"Maciej Wieczór-Retman" <maciej.wieczor-retman@intel.com>,
	"Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v3 3/7] selftests/resctrl: Remove duplicate feature check from CMT test
Date: Fri, 29 Sep 2023 14:20:35 +0300	[thread overview]
Message-ID: <20230929112039.7488-4-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20230929112039.7488-1-ilpo.jarvinen@linux.intel.com>

The test runner run_cmt_test() in resctrl_tests.c checks for CMT
feature and does not run cmt_resctrl_val() if CMT is not supported.
Then cmt_resctrl_val() also check is CMT is supported.

Remove the duplicated feature check for CMT from cmt_resctrl_val().

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reviewed-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Cc: <stable@vger.kernel.org>
---
 tools/testing/selftests/resctrl/cmt_test.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tools/testing/selftests/resctrl/cmt_test.c b/tools/testing/selftests/resctrl/cmt_test.c
index cf2f5e92dea6..50bdbce9fba9 100644
--- a/tools/testing/selftests/resctrl/cmt_test.c
+++ b/tools/testing/selftests/resctrl/cmt_test.c
@@ -80,9 +80,6 @@ int cmt_resctrl_val(int cpu_no, int n, const char * const *benchmark_cmd)
 	size_t span;
 	int ret, i;
 
-	if (!validate_resctrl_feature_request(CMT_STR))
-		return -1;
-
 	ret = get_cbm_mask("L3", cbm_mask);
 	if (ret)
 		return ret;
-- 
2.30.2


  parent reply	other threads:[~2023-09-29 11:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-29 11:20 [PATCH v3 0/7] selftests/resctrl: Fixes to failing tests Ilpo Järvinen
2023-09-29 11:20 ` [PATCH v3 1/7] selftests/resctrl: Fix uninitialized .sa_flags Ilpo Järvinen
2023-09-29 16:55   ` Reinette Chatre
2023-10-02  9:46     ` Ilpo Järvinen
2023-09-29 11:20 ` [PATCH v3 2/7] selftests/resctrl: Extend signal handler coverage to unmount on receiving signal Ilpo Järvinen
2023-09-29 16:55   ` Reinette Chatre
2023-09-29 11:20 ` Ilpo Järvinen [this message]
2023-09-29 11:20 ` [PATCH v3 4/7] selftests/resctrl: Move _GNU_SOURCE define into Makefile Ilpo Järvinen
2023-09-29 11:20 ` [PATCH v3 5/7] selftests/resctrl: Refactor feature check to use resource and feature name Ilpo Järvinen
2023-09-29 11:20 ` [PATCH v3 6/7] selftests/resctrl: Fix feature checks Ilpo Järvinen
2023-09-29 11:20 ` [PATCH v3 7/7] selftests/resctrl: Reduce failures due to outliers in MBA/MBM tests Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230929112039.7488-4-ilpo.jarvinen@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=maciej.wieczor-retman@intel.com \
    --cc=reinette.chatre@intel.com \
    --cc=shuah@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tan.shaopeng@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.