From: <marius.cristea@microchip.com>
To: <jic23@kernel.org>, <lars@metafoo.de>, <lgirdwood@gmail.com>,
<broonie@kernel.org>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<marius.cristea@microchip.com>
Subject: [PATCH v1] iio: adc: MCP3564: fix warn: unsigned '__x' is never less than zero.
Date: Mon, 2 Oct 2023 19:16:18 +0300 [thread overview]
Message-ID: <20231002161618.36373-1-marius.cristea@microchip.com> (raw)
From: Marius Cristea <marius.cristea@microchip.com>
The patch efea15e3c65d: "iio: adc: MCP3564: fix the static checker warning"
leads to the following Smatch static checker warning:
smatch warnings:
drivers/iio/adc/mcp3564.c:1105 mcp3564_fill_scale_tbls() warn: unsigned '__x' is never less than zero.
vim +/__x +1105 drivers/iio/adc/mcp3564.c
1094
1095 static void mcp3564_fill_scale_tbls(struct mcp3564_state *adc)
1096 {
.....
1103 for (i = 0; i < MCP3564_MAX_PGA; i++) {
1104 ref = adc->vref_mv;
> 1105 tmp1 = shift_right((u64)ref * NANO, pow);
1106 div_u64_rem(tmp1, NANO, &tmp0);
1107
.....
1113 }
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202309280738.NWjVfVt4-lkp@intel.com/
Fixes: efea15e3c65d (iio: adc: MCP3564: fix the static checker warning)
Signed-off-by: Marius Cristea <marius.cristea@microchip.com>
---
drivers/iio/adc/mcp3564.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/mcp3564.c b/drivers/iio/adc/mcp3564.c
index 9ede1a5d5d7b..e3f1de5fcc5a 100644
--- a/drivers/iio/adc/mcp3564.c
+++ b/drivers/iio/adc/mcp3564.c
@@ -1102,7 +1102,7 @@ static void mcp3564_fill_scale_tbls(struct mcp3564_state *adc)
for (i = 0; i < MCP3564_MAX_PGA; i++) {
ref = adc->vref_mv;
- tmp1 = shift_right((u64)ref * NANO, pow);
+ tmp1 = ((u64)ref * NANO) >> pow;
div_u64_rem(tmp1, NANO, &tmp0);
tmp1 = tmp1 * mcp3564_hwgain_frac[(2 * i) + 1];
base-commit: 5e99f692d4e32e3250ab18d511894ca797407aec
--
2.34.1
next reply other threads:[~2023-10-02 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 16:16 marius.cristea [this message]
2023-10-10 9:44 ` [PATCH v1] iio: adc: MCP3564: fix warn: unsigned '__x' is never less than zero Jonathan Cameron
2023-10-11 16:41 ` Marius.Cristea
2023-10-12 7:36 ` Jonathan Cameron
2023-10-12 8:18 ` Marius.Cristea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231002161618.36373-1-marius.cristea@microchip.com \
--to=marius.cristea@microchip.com \
--cc=broonie@kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.