All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregory.greenman@intel.com
To: johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org,
	Rotem Saado <rotem.saado@intel.com>,
	Gregory Greenman <gregory.greenman@intel.com>
Subject: [PATCH 03/15] wifi: iwlwifi: yoyo: swap cdb and jacket bits values
Date: Wed,  4 Oct 2023 12:36:22 +0300	[thread overview]
Message-ID: <20231004123422.356d8dacda2f.I349ab888b43a11baa2453a1d6978a6a703e422f0@changeid> (raw)
In-Reply-To: <20231004093634.131303-1-gregory.greenman@intel.com>

From: Rotem Saado <rotem.saado@intel.com>

The bits are wrong, the jacket bit should be 5 and cdb bit 4.
Fix it.

Fixes: 1f171f4f1437 ("iwlwifi: Add support for getting rf id with blank otp")
Signed-off-by: Rotem Saado <rotem.saado@intel.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/iwl-prph.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-prph.h b/drivers/net/wireless/intel/iwlwifi/iwl-prph.h
index 06d467068ff4..7bd4ce149e04 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-prph.h
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-prph.h
@@ -348,8 +348,8 @@
 #define RFIC_REG_RD			0xAD0470
 #define WFPM_CTRL_REG			0xA03030
 #define WFPM_OTP_CFG1_ADDR		0x00a03098
-#define WFPM_OTP_CFG1_IS_JACKET_BIT	BIT(4)
-#define WFPM_OTP_CFG1_IS_CDB_BIT	BIT(5)
+#define WFPM_OTP_CFG1_IS_JACKET_BIT	BIT(5)
+#define WFPM_OTP_CFG1_IS_CDB_BIT	BIT(4)
 #define WFPM_OTP_BZ_BNJ_JACKET_BIT	5
 #define WFPM_OTP_BZ_BNJ_CDB_BIT		4
 #define WFPM_OTP_CFG1_IS_JACKET(_val)   (((_val) & 0x00000020) >> WFPM_OTP_BZ_BNJ_JACKET_BIT)
-- 
2.38.1


  parent reply	other threads:[~2023-10-04  9:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-04  9:36 [PATCH 00/15] wifi: iwlwifi: updates - 2023-10-04 gregory.greenman
2023-10-04  9:36 ` [PATCH 01/15] wifi: iwlwifi: Extract common prph mac/phy regions data dump logic gregory.greenman
2023-10-04  9:36 ` [PATCH 02/15] wifi: iwlwifi: add support for new ini region types gregory.greenman
2023-10-04  9:36 ` gregory.greenman [this message]
2023-10-04  9:36 ` [PATCH 04/15] wifi: iwlwifi: mvm: rework debugfs handling gregory.greenman
2023-10-04 21:30   ` kernel test robot
2023-10-04  9:36 ` [PATCH 05/15] wifi: iwlwifi: mvm: add a per-link debugfs gregory.greenman
2023-10-04  9:36 ` [PATCH 06/15] wifi: iwlwifi: mvm: fix SB CFG check gregory.greenman
2023-10-04  9:36 ` [PATCH 07/15] wifi: iwlwifi: mei: return error from register when not built gregory.greenman
2023-10-04  9:36 ` [PATCH 08/15] wifi: iwlwifi: mvm: Add basic link selection logic gregory.greenman
2023-10-04  9:36 ` [PATCH 09/15] wifi: iwlwifi: abort scan when rfkill on but device enabled gregory.greenman
2023-10-04  9:36 ` [PATCH 10/15] wifi: iwlwifi: mvm: add start mac ctdp sum calculation debugfs handler gregory.greenman
2023-10-04  9:36 ` [PATCH 11/15] wifi: iwlwifi: mvm: Don't always bind/link the P2P Device interface gregory.greenman
2023-10-04  9:36 ` [PATCH 12/15] wifi: iwlwifi: mvm: advertise support for SCS traffic description gregory.greenman
2023-10-04  9:36 ` [PATCH 13/15] wifi: iwlwifi: fw: Fix debugfs command sending gregory.greenman
2023-10-04  9:36 ` [PATCH 14/15] wifi: iwlwifi: fix the rf step and flavor bits range gregory.greenman
2023-10-04  9:36 ` [PATCH 15/15] wifi: iwlwifi: mvm: Correctly set link configuration gregory.greenman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231004123422.356d8dacda2f.I349ab888b43a11baa2453a1d6978a6a703e422f0@changeid \
    --to=gregory.greenman@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rotem.saado@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.