From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> To: Linus Walleij <linus.walleij@linaro.org> Cc: Tony Lindgren <tony@atomide.com>, Haojian Zhuang <haojian.zhuang@linaro.org>, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/20] pinctrl: single: Drop if block with always false condition Date: Mon, 9 Oct 2023 10:38:38 +0200 [thread overview] Message-ID: <20231009083856.222030-3-u.kleine-koenig@pengutronix.de> (raw) In-Reply-To: <20231009083856.222030-1-u.kleine-koenig@pengutronix.de> pcs_remove() is only called after pcs_probe() completed successfully. In this case platform_set_drvdata() was called with a non-NULL argument and so platform_get_drvdata() won't return NULL. Simplify by removing the if block with the always false condition. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/pinctrl/pinctrl-single.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index 461a7c02d4a3..f6c02c8b934d 100644 --- a/drivers/pinctrl/pinctrl-single.c +++ b/drivers/pinctrl/pinctrl-single.c @@ -1929,9 +1929,6 @@ static int pcs_remove(struct platform_device *pdev) { struct pcs_device *pcs = platform_get_drvdata(pdev); - if (!pcs) - return 0; - pcs_free_resources(pcs); return 0; -- 2.40.1
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> To: Linus Walleij <linus.walleij@linaro.org> Cc: Tony Lindgren <tony@atomide.com>, Haojian Zhuang <haojian.zhuang@linaro.org>, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/20] pinctrl: single: Drop if block with always false condition Date: Mon, 9 Oct 2023 10:38:38 +0200 [thread overview] Message-ID: <20231009083856.222030-3-u.kleine-koenig@pengutronix.de> (raw) In-Reply-To: <20231009083856.222030-1-u.kleine-koenig@pengutronix.de> pcs_remove() is only called after pcs_probe() completed successfully. In this case platform_set_drvdata() was called with a non-NULL argument and so platform_get_drvdata() won't return NULL. Simplify by removing the if block with the always false condition. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/pinctrl/pinctrl-single.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index 461a7c02d4a3..f6c02c8b934d 100644 --- a/drivers/pinctrl/pinctrl-single.c +++ b/drivers/pinctrl/pinctrl-single.c @@ -1929,9 +1929,6 @@ static int pcs_remove(struct platform_device *pdev) { struct pcs_device *pcs = platform_get_drvdata(pdev); - if (!pcs) - return 0; - pcs_free_resources(pcs); return 0; -- 2.40.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-09 9:23 UTC|newest] Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-09 8:38 [PATCH 00/20] pinctrl: Convert to platform remove callback returning void Uwe Kleine-König 2023-10-09 8:38 ` Uwe Kleine-König 2023-10-09 8:38 ` Uwe Kleine-König 2023-10-09 8:38 ` [PATCH 01/20] pinctrl: stmfx: Improve error message in .remove()'s error path Uwe Kleine-König 2023-10-09 8:38 ` Uwe Kleine-König 2023-10-10 13:35 ` Linus Walleij 2023-10-10 13:35 ` Linus Walleij 2023-10-09 8:38 ` Uwe Kleine-König [this message] 2023-10-09 8:38 ` [PATCH 02/20] pinctrl: single: Drop if block with always false condition Uwe Kleine-König 2023-10-10 13:36 ` Linus Walleij 2023-10-10 13:36 ` Linus Walleij 2023-10-09 8:38 ` [PATCH 03/20] pinctrl: ti: ti-iodelay: " Uwe Kleine-König 2023-10-10 13:36 ` Linus Walleij 2023-10-09 8:38 ` [PATCH 04/20] pinctrl: cirrus: madera-core: Convert to platform remove callback returning void Uwe Kleine-König 2023-10-09 10:37 ` Charles Keepax 2023-10-10 13:37 ` Linus Walleij 2023-10-09 8:38 ` [PATCH 05/20] pinctrl: intel: cherryview: " Uwe Kleine-König 2023-10-09 11:10 ` Mika Westerberg 2023-10-10 13:18 ` Andy Shevchenko 2023-10-09 8:38 ` [PATCH 06/20] pinctrl: intel: lynxpoint: " Uwe Kleine-König 2023-10-09 11:10 ` Mika Westerberg 2023-10-10 13:18 ` Andy Shevchenko 2023-10-10 15:34 ` Andy Shevchenko 2023-10-09 8:38 ` [PATCH 07/20] pinctrl: nomadik: abx500: " Uwe Kleine-König 2023-10-09 8:38 ` Uwe Kleine-König 2023-10-10 13:38 ` Linus Walleij 2023-10-10 13:38 ` Linus Walleij 2023-10-09 8:38 ` [PATCH 08/20] pinctrl: amd: " Uwe Kleine-König 2023-10-10 13:38 ` Linus Walleij 2023-10-09 8:38 ` [PATCH 09/20] pinctrl: artpec6: " Uwe Kleine-König 2023-10-10 8:40 ` Jesper Nilsson 2023-10-10 13:39 ` Linus Walleij 2023-10-09 8:38 ` [PATCH 10/20] pinctrl: as3722: " Uwe Kleine-König 2023-10-10 13:39 ` Linus Walleij 2023-10-09 8:38 ` [PATCH 11/20] pinctrl: rockchip: " Uwe Kleine-König 2023-10-09 8:38 ` Uwe Kleine-König 2023-10-09 8:38 ` Uwe Kleine-König 2023-10-09 20:16 ` Heiko Stuebner 2023-10-09 20:16 ` Heiko Stuebner 2023-10-09 20:16 ` Heiko Stuebner 2023-10-10 13:40 ` Linus Walleij 2023-10-10 13:40 ` Linus Walleij 2023-10-10 13:40 ` Linus Walleij 2023-10-09 8:38 ` [PATCH 12/20] pinctrl: single: " Uwe Kleine-König 2023-10-09 8:38 ` Uwe Kleine-König 2023-10-10 13:41 ` Linus Walleij 2023-10-10 13:41 ` Linus Walleij 2023-10-09 8:38 ` [PATCH 13/20] pinctrl: stmfx: " Uwe Kleine-König 2023-10-09 8:38 ` Uwe Kleine-König 2023-10-10 13:41 ` Linus Walleij 2023-10-10 13:41 ` Linus Walleij 2023-10-09 8:38 ` [PATCH 14/20] pinctrl: tb10x: " Uwe Kleine-König 2023-10-10 13:42 ` Linus Walleij 2023-10-09 8:38 ` [PATCH 15/20] pinctrl: qcom: spmi-gpio: " Uwe Kleine-König 2023-10-10 13:42 ` Linus Walleij 2023-10-09 8:38 ` [PATCH 16/20] pinctrl: qcom: spmi-mpp: " Uwe Kleine-König 2023-10-10 13:43 ` Linus Walleij 2023-10-09 8:38 ` [PATCH 17/20] pinctrl: qcom: ssbi-gpio: " Uwe Kleine-König 2023-10-10 13:43 ` Linus Walleij 2023-10-09 8:38 ` [PATCH 18/20] pinctrl: qcom: ssbi-mpp: " Uwe Kleine-König 2023-10-10 13:44 ` Linus Walleij 2023-10-09 8:38 ` [PATCH 19/20] pinctrl: renesas: rzn1: " Uwe Kleine-König 2023-10-09 9:39 ` Geert Uytterhoeven 2023-10-10 13:45 ` Linus Walleij 2023-10-10 13:48 ` Geert Uytterhoeven 2023-10-09 8:38 ` [PATCH 20/20] pinctrl: ti: ti-iodelay: " Uwe Kleine-König 2023-10-10 13:45 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231009083856.222030-3-u.kleine-koenig@pengutronix.de \ --to=u.kleine-koenig@pengutronix.de \ --cc=haojian.zhuang@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.