All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 06/25] drm/i915/display: Move lvds_channel_mode module parameter under display
Date: Tue, 10 Oct 2023 14:41:01 +0300	[thread overview]
Message-ID: <20231010114120.2504103-7-jouni.hogander@intel.com> (raw)
In-Reply-To: <20231010114120.2504103-1-jouni.hogander@intel.com>

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_params.c | 4 ++++
 drivers/gpu/drm/i915/display/intel_display_params.h | 3 ++-
 drivers/gpu/drm/i915/display/intel_lvds.c           | 4 ++--
 drivers/gpu/drm/i915/i915_params.c                  | 4 ----
 drivers/gpu/drm/i915/i915_params.h                  | 1 -
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_params.c b/drivers/gpu/drm/i915/display/intel_display_params.c
index 72f1782e27fe..cdc42bc575b8 100644
--- a/drivers/gpu/drm/i915/display/intel_display_params.c
+++ b/drivers/gpu/drm/i915/display/intel_display_params.c
@@ -30,6 +30,10 @@ static struct intel_display_params intel_display_modparams __read_mostly = {
 intel_display_param_named_unsafe(vbt_firmware, charp, 0400,
 	"Load VBT from specified file under /lib/firmware");
 
+intel_display_param_named_unsafe(lvds_channel_mode, int, 0400,
+	 "Specify LVDS channel mode "
+	 "(0=probe BIOS [default], 1=single-channel, 2=dual-channel)");
+
 intel_display_param_named_unsafe(enable_fbc, int, 0400,
 	"Enable frame buffer compression for power savings "
 	"(default: -1 (use per-chip default))");
diff --git a/drivers/gpu/drm/i915/display/intel_display_params.h b/drivers/gpu/drm/i915/display/intel_display_params.h
index a6f37c55523d..a4988ef44837 100644
--- a/drivers/gpu/drm/i915/display/intel_display_params.h
+++ b/drivers/gpu/drm/i915/display/intel_display_params.h
@@ -25,7 +25,8 @@ struct drm_i915_private;
  */
 #define INTEL_DISPLAY_PARAMS_FOR_EACH(param) \
 	param(char *, vbt_firmware, NULL, 0400) \
-	param(int, enable_fbc, -1, 0600)     \
+	param(int, lvds_channel_mode, 0, 0400) \
+	param(int, enable_fbc, -1, 0600)	\
 	param(int, enable_psr, -1, 0600) \
 	param(bool, psr_safest_params, false, 0400) \
 	param(bool, enable_psr2_sel_fetch, true, 0400) \
diff --git a/drivers/gpu/drm/i915/display/intel_lvds.c b/drivers/gpu/drm/i915/display/intel_lvds.c
index 2a4ca7e65775..4b114fde57b1 100644
--- a/drivers/gpu/drm/i915/display/intel_lvds.c
+++ b/drivers/gpu/drm/i915/display/intel_lvds.c
@@ -794,8 +794,8 @@ static bool compute_is_dual_link_lvds(struct intel_lvds_encoder *lvds_encoder)
 	unsigned int val;
 
 	/* use the module option value if specified */
-	if (i915->params.lvds_channel_mode > 0)
-		return i915->params.lvds_channel_mode == 2;
+	if (i915->display.params.lvds_channel_mode > 0)
+		return i915->display.params.lvds_channel_mode == 2;
 
 	/* single channel LVDS is limited to 112 MHz */
 	if (fixed_mode->clock > 112999)
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index 12a2bd59303e..46859a99fe20 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -72,10 +72,6 @@ i915_param_named_unsafe(enable_dc, int, 0400,
 	"(-1=auto [default]; 0=disable; 1=up to DC5; 2=up to DC6; "
 	"3=up to DC5 with DC3CO; 4=up to DC6 with DC3CO)");
 
-i915_param_named_unsafe(lvds_channel_mode, int, 0400,
-	 "Specify LVDS channel mode "
-	 "(0=probe BIOS [default], 1=single-channel, 2=dual-channel)");
-
 i915_param_named_unsafe(panel_use_ssc, int, 0400,
 	"Use Spread Spectrum Clock with panels [LVDS/eDP] "
 	"(default: auto from VBT)");
diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index 702da3a8d471..ddd0adb786a3 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -47,7 +47,6 @@ struct drm_printer;
  */
 #define I915_PARAMS_FOR_EACH(param) \
 	param(int, modeset, -1, 0400) \
-	param(int, lvds_channel_mode, 0, 0400) \
 	param(int, panel_use_ssc, -1, 0600) \
 	param(int, vbt_sdvo_panel_type, -1, 0400) \
 	param(int, enable_dc, -1, 0400) \
-- 
2.34.1


  parent reply	other threads:[~2023-10-10 11:43 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-10 11:40 [Intel-gfx] [PATCH 00/25] Framework for display parameters Jouni Högander
2023-10-10 11:40 ` [Intel-gfx] [PATCH 01/25] drm/i915/display: Add framework to add parameters specific to display Jouni Högander
2023-10-10 11:40 ` [Intel-gfx] [PATCH 02/25] drm/i915/display: Dump also display parameters into GPU error dump Jouni Högander
2023-10-12  7:38   ` Hogander, Jouni
2023-10-10 11:40 ` [Intel-gfx] [PATCH 03/25] drm/i915/display: Move enable_fbc module parameter under display Jouni Högander
2023-10-10 11:40 ` [Intel-gfx] [PATCH 04/25] drm/i915/display: Move psr related module parameters " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 05/25] drm/i915/display: Move vbt_firmware module parameter " Jouni Högander
2023-10-10 11:41 ` Jouni Högander [this message]
2023-10-10 11:41 ` [Intel-gfx] [PATCH 07/25] drm/i915/display: Move panel_use_ssc " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 08/25] drm/i915/display: Move vbt_sdvo_panel_type " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 09/25] drm/i915/display: Move enable_dc " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 10/25] drm/i915/display: Move enable_dpt " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 11/25] drm/i915/display: Move enable_sagv " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 12/25] drm/i915/display: Move disable_power_well " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 13/25] drm/i915/display: Move enable_ips " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 14/25] drm/i915/display: Move invert_brightness " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 15/25] drm/i915/display: Move edp_vswing " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 16/25] drm/i915/display: Move fastboot " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 17/25] drm/i915/display: Move enable_dpcd_backlightmodule " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 18/25] drm/i915/display: Move load_detect_test " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 19/25] drm/i915/display: Move force_reset_modeset_test " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 20/25] drm/i915/display: Move disable_display " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 21/25] drm/i915/display: Use device parameters instead of module in I915_STATE_WARN Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 22/25] drm/i915/display: Move verbose_state_checks under display Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 23/25] drm/i915/display: Move nuclear_pageflip " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 24/25] drm/i915/display: Move enable_dp_mst " Jouni Högander
2023-10-10 11:41 ` [Intel-gfx] [PATCH 25/25] drm/i915/display: Use same permissions for enable_sagv as for rest Jouni Högander
2023-10-10 22:25 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Framework for display parameters (rev2) Patchwork
2023-10-10 22:25 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-10-10 22:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-10-11 10:58 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-10-12 15:04 ` [Intel-gfx] [PATCH 00/25] Framework for display parameters Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231010114120.2504103-7-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.