From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: igt-dev@lists.freedesktop.org, Intel-gfx@lists.freedesktop.org Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Subject: [Intel-gfx] [PATCH i-g-t 3/4] tools/intel_gpu_top: Optimise interactive display a bit Date: Wed, 11 Oct 2023 09:28:57 +0100 [thread overview] Message-ID: <20231011082857.797045-1-tvrtko.ursulin@linux.intel.com> (raw) In-Reply-To: <20231010163518.hgcqkap3dx655hrk@kamilkon-desk.igk.intel.com> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Padding the percentage bars and table columns with spaces happens quite a lot so lets do better than putchar at a time. Have a table of visually empty strings and build the required length out of those chunks. While at it, also move the percentage bar table into its function scope. v2: * Fix checkpatch and use ARRAY_SIZE. (Kamil) Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Kamil Konieczny <kamil.konieczny@linux.intel.com> --- tools/intel_gpu_top.c | 38 +++++++++++++++++++++++++++++++++----- 1 file changed, 33 insertions(+), 5 deletions(-) diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c index c5abd0c92155..6bd03ab8d7fa 100644 --- a/tools/intel_gpu_top.c +++ b/tools/intel_gpu_top.c @@ -926,14 +926,39 @@ static void free_display_clients(struct igt_drm_clients *clients) free(clients); } -static const char *bars[] = { " ", "▏", "▎", "▍", "▌", "▋", "▊", "▉", "█" }; - static unsigned int n_spaces(const unsigned int n) { - unsigned int i; + static const char *spaces[] = { + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + }; + unsigned int i, r = n; - for (i = 0; i < n; i++) - putchar(' '); + while (r) { + if (r > ARRAY_SIZE(spaces)) + i = ARRAY_SIZE(spaces) - 1; + else + i = r - 1; + fputs(spaces[i], stdout); + r -= i + 1; + } return n; } @@ -941,6 +966,9 @@ static unsigned int n_spaces(const unsigned int n) static void print_percentage_bar(double percent, double max, int max_len, bool numeric) { + static const char *bars[] = { + " ", "▏", "▎", "▍", "▌", "▋", "▊", "▉", "█" + }; int bar_len, i, len = max_len - 2; const int w = 8; -- 2.39.2
WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> To: igt-dev@lists.freedesktop.org, Intel-gfx@lists.freedesktop.org Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Subject: [igt-dev] [PATCH i-g-t 3/4] tools/intel_gpu_top: Optimise interactive display a bit Date: Wed, 11 Oct 2023 09:28:57 +0100 [thread overview] Message-ID: <20231011082857.797045-1-tvrtko.ursulin@linux.intel.com> (raw) In-Reply-To: <20231010163518.hgcqkap3dx655hrk@kamilkon-desk.igk.intel.com> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Padding the percentage bars and table columns with spaces happens quite a lot so lets do better than putchar at a time. Have a table of visually empty strings and build the required length out of those chunks. While at it, also move the percentage bar table into its function scope. v2: * Fix checkpatch and use ARRAY_SIZE. (Kamil) Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Kamil Konieczny <kamil.konieczny@linux.intel.com> --- tools/intel_gpu_top.c | 38 +++++++++++++++++++++++++++++++++----- 1 file changed, 33 insertions(+), 5 deletions(-) diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c index c5abd0c92155..6bd03ab8d7fa 100644 --- a/tools/intel_gpu_top.c +++ b/tools/intel_gpu_top.c @@ -926,14 +926,39 @@ static void free_display_clients(struct igt_drm_clients *clients) free(clients); } -static const char *bars[] = { " ", "▏", "▎", "▍", "▌", "▋", "▊", "▉", "█" }; - static unsigned int n_spaces(const unsigned int n) { - unsigned int i; + static const char *spaces[] = { + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + " ", + }; + unsigned int i, r = n; - for (i = 0; i < n; i++) - putchar(' '); + while (r) { + if (r > ARRAY_SIZE(spaces)) + i = ARRAY_SIZE(spaces) - 1; + else + i = r - 1; + fputs(spaces[i], stdout); + r -= i + 1; + } return n; } @@ -941,6 +966,9 @@ static unsigned int n_spaces(const unsigned int n) static void print_percentage_bar(double percent, double max, int max_len, bool numeric) { + static const char *bars[] = { + " ", "▏", "▎", "▍", "▌", "▋", "▊", "▉", "█" + }; int bar_len, i, len = max_len - 2; const int w = 8; -- 2.39.2
next prev parent reply other threads:[~2023-10-11 8:29 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-10 11:07 [Intel-gfx] [PATCH i-g-t 0/4] Fix various intel_gpu_top UI layout issues Tvrtko Ursulin 2023-10-10 11:07 ` [igt-dev] " Tvrtko Ursulin 2023-10-10 11:07 ` [Intel-gfx] [PATCH i-g-t 1/4] tools/intel_gpu_top: Fix clients header width when no clients Tvrtko Ursulin 2023-10-10 11:07 ` [igt-dev] " Tvrtko Ursulin 2023-10-10 16:30 ` [Intel-gfx] " Kamil Konieczny 2023-10-10 16:30 ` [igt-dev] " Kamil Konieczny 2023-10-10 11:07 ` [Intel-gfx] [PATCH i-g-t 2/4] tools/intel_gpu_top: Fix client layout on first sample period Tvrtko Ursulin 2023-10-10 11:07 ` [igt-dev] " Tvrtko Ursulin 2023-10-10 16:31 ` [Intel-gfx] " Kamil Konieczny 2023-10-10 16:31 ` Kamil Konieczny 2023-10-10 11:07 ` [Intel-gfx] [PATCH i-g-t 3/4] tools/intel_gpu_top: Optimise interactive display a bit Tvrtko Ursulin 2023-10-10 11:07 ` [igt-dev] " Tvrtko Ursulin 2023-10-10 16:35 ` [Intel-gfx] " Kamil Konieczny 2023-10-10 16:35 ` [igt-dev] " Kamil Konieczny 2023-10-11 8:28 ` Tvrtko Ursulin [this message] 2023-10-11 8:28 ` [igt-dev] " Tvrtko Ursulin 2023-10-10 11:07 ` [Intel-gfx] [PATCH i-g-t 4/4] tools/intel_gpu_top: Handle narrow terminals more gracefully Tvrtko Ursulin 2023-10-10 11:07 ` [igt-dev] " Tvrtko Ursulin 2023-10-10 16:43 ` [Intel-gfx] " Kamil Konieczny 2023-10-10 16:43 ` [igt-dev] " Kamil Konieczny 2023-10-11 8:22 ` Tvrtko Ursulin 2023-10-11 8:22 ` [igt-dev] " Tvrtko Ursulin 2023-10-11 8:31 ` Tvrtko Ursulin 2023-10-11 8:31 ` [igt-dev] " Tvrtko Ursulin 2023-10-10 11:56 ` [igt-dev] ✗ Fi.CI.BAT: failure for Fix various intel_gpu_top UI layout issues Patchwork 2023-10-10 12:25 ` [igt-dev] ✗ CI.xeBAT: " Patchwork 2023-10-11 13:29 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix various intel_gpu_top UI layout issues (rev2) Patchwork 2023-10-11 14:28 ` [igt-dev] ✓ CI.xeBAT: " Patchwork 2023-10-12 3:48 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork 2023-10-11 8:38 [Intel-gfx] [PATCH i-g-t 1/4] tools/intel_gpu_top: Fix clients header width when no clients Tvrtko Ursulin 2023-10-11 8:38 ` [Intel-gfx] [PATCH i-g-t 3/4] tools/intel_gpu_top: Optimise interactive display a bit Tvrtko Ursulin 2023-10-11 12:40 ` Kamil Konieczny 2023-10-12 8:07 ` Tvrtko Ursulin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231011082857.797045-1-tvrtko.ursulin@linux.intel.com \ --to=tvrtko.ursulin@linux.intel.com \ --cc=Intel-gfx@lists.freedesktop.org \ --cc=igt-dev@lists.freedesktop.org \ --cc=tvrtko.ursulin@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.