All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-wireless@vger.kernel.org,
	Johannes Berg <johannes@sipsolutions.net>,
	linux-wpan@vger.kernel.org,
	Michael Hennerich <michael.hennerich@analog.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	"David S . Miller" <davem@davemloft.net>,
	Rodolfo Zitellini <rwz@xhero.org>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH v2 03/10] ethernet: sp7021: fix ioctl callback pointer
Date: Wed, 11 Oct 2023 16:02:18 +0200	[thread overview]
Message-ID: <20231011140225.253106-3-arnd@kernel.org> (raw)
In-Reply-To: <20231011140225.253106-1-arnd@kernel.org>

From: Arnd Bergmann <arnd@arndb.de>

The old .ndo_do_ioctl() callback is never called any more, instead the
driver should set .ndo_eth_ioctl() for the phy operations.

Fixes: fd3040b9394c5 ("net: ethernet: Add driver for Sunplus SP7021")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/ethernet/sunplus/spl2sw_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/sunplus/spl2sw_driver.c b/drivers/net/ethernet/sunplus/spl2sw_driver.c
index 391a1bc7f4463..bb4514f4e8157 100644
--- a/drivers/net/ethernet/sunplus/spl2sw_driver.c
+++ b/drivers/net/ethernet/sunplus/spl2sw_driver.c
@@ -199,7 +199,7 @@ static const struct net_device_ops netdev_ops = {
 	.ndo_start_xmit = spl2sw_ethernet_start_xmit,
 	.ndo_set_rx_mode = spl2sw_ethernet_set_rx_mode,
 	.ndo_set_mac_address = spl2sw_ethernet_set_mac_address,
-	.ndo_do_ioctl = phy_do_ioctl,
+	.ndo_eth_ioctl = phy_do_ioctl,
 	.ndo_tx_timeout = spl2sw_ethernet_tx_timeout,
 };
 
-- 
2.39.2


  parent reply	other threads:[~2023-10-11 14:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11 14:02 [PATCH v2 01/10] appletalk: make localtalk and ppp support conditional Arnd Bergmann
2023-10-11 14:02 ` [PATCH v2 02/10] ieee802154: avoid deprecated .ndo_do_ioctl callback Arnd Bergmann
2023-10-11 14:02 ` Arnd Bergmann [this message]
2023-10-11 14:02 ` [PATCH v2 04/10] staging: ks7010: remove unused ioctl handler Arnd Bergmann
2023-10-11 14:02 ` [PATCH v2 05/10] staging: rtl8192: remove unused legacy ioctl handlers Arnd Bergmann
2023-10-11 14:02 ` [PATCH v2 06/10] staging: rtl8712: " Arnd Bergmann
2023-10-11 14:02 ` [PATCH v2 07/10] staging: rtl8723bs: remove dead code Arnd Bergmann
2023-10-11 14:02 ` [PATCH v2 08/10] wifi: atmel: remove unused ioctl function Arnd Bergmann
2023-10-14  6:42   ` Kalle Valo
2023-10-11 14:02 ` [PATCH v2 09/10] wifi: hostap: " Arnd Bergmann
2023-10-11 14:02 ` [PATCH v2 10/10] net: remove ndo_do_ioctl handler Arnd Bergmann
2023-10-11 15:04 ` [PATCH v2 01/10] appletalk: make localtalk and ppp support conditional Jiri Pirko
2023-10-11 15:57   ` Arnd Bergmann
2023-10-12 13:46     ` Jiri Pirko
2023-10-14  0:07     ` Jakub Kicinski
2023-10-14  5:00       ` Kalle Valo
2023-10-18  0:22 ` Jakub Kicinski
2023-10-18  0:22   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231011140225.253106-3-arnd@kernel.org \
    --to=arnd@kernel.org \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rwz@xhero.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.