From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <brauner@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>, Jens Axboe <axboe@kernel.dk>
Cc: Jan Kara <jack@suse.cz>, Denis Efremov <efremov@linux.com>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: don't take s_umount under open_mutex
Date: Tue, 17 Oct 2023 20:48:18 +0200 [thread overview]
Message-ID: <20231017184823.1383356-1-hch@lst.de> (raw)
Hi all,
Christian has been pestering Jan and me a bit about finally fixing
all the pre-existing mostly theoretical cases of s_umount taken under
open_mutex. This series, which is mostly from him with some help from
me should get us to that goal by replacing bdev_mark_dead calls that
can't ever reach a file system holder to call into with simple bdev
page invalidation.
Expect future version to come from Christian again, I'm just helping
out while he is trouble shooting his mail setup.
Diffstat:
block/disk-events.c | 18 +++++++-----------
block/genhd.c | 7 +++++++
block/partitions/core.c | 43 +++++++++++++++++++++++++++++--------------
drivers/block/ataflop.c | 4 +++-
drivers/block/floppy.c | 4 +++-
fs/super.c | 2 ++
6 files changed, 51 insertions(+), 27 deletions(-)
next reply other threads:[~2023-10-17 18:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 18:48 Christoph Hellwig [this message]
2023-10-17 18:48 ` [PATCH 1/5] block: simplify bdev_del_partition() Christoph Hellwig
2023-10-18 2:33 ` Ming Lei
2023-10-17 18:48 ` [PATCH 2/5] block: WARN_ON_ONCE() when we remove active partitions Christoph Hellwig
2023-10-18 2:36 ` Ming Lei
2023-10-19 8:31 ` Jan Kara
2023-10-17 18:48 ` [PATCH 3/5] block: move bdev_mark_dead out of disk_check_media_change Christoph Hellwig
2023-10-18 3:16 ` Ming Lei
2023-10-18 6:46 ` Christoph Hellwig
2023-10-18 9:15 ` Ming Lei
2023-10-18 12:10 ` Christoph Hellwig
2023-10-18 9:24 ` Christian Brauner
2023-10-19 5:57 ` Christoph Hellwig
2023-10-19 7:24 ` Christian Brauner
2023-10-19 8:34 ` Jan Kara
2023-10-17 18:48 ` [PATCH 4/5] block: assert that we're not holding open_mutex over blk_report_disk_dead Christoph Hellwig
2023-10-18 3:18 ` Ming Lei
2023-10-19 8:43 ` Jan Kara
2023-10-17 18:48 ` [PATCH 5/5] fs: assert that open_mutex isn't held over holder ops Christoph Hellwig
2023-10-18 9:53 ` Ming Lei
2023-10-19 8:43 ` Jan Kara
2023-10-19 9:35 ` don't take s_umount under open_mutex Christian Brauner
2023-10-19 11:27 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231017184823.1383356-1-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=efremov@linux.com \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.