From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [topic/core-for-CI][PATCH 1/2] Revert "freezer: Dump more info on whoever is trying to get frozen with locks held"
Date: Tue, 24 Oct 2023 20:55:51 +0300 [thread overview]
Message-ID: <20231024175552.15503-2-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20231024175552.15503-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
This was just extra debug to hunt down a regression, which got fixed.
This reverts commit d77cc11a9ab0558923d304683ad2307ec0cd5681.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
kernel/freezer.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/kernel/freezer.c b/kernel/freezer.c
index e211184c26c7..4fad0e6fca64 100644
--- a/kernel/freezer.c
+++ b/kernel/freezer.c
@@ -125,16 +125,8 @@ static int __set_task_frozen(struct task_struct *p, void *arg)
/*
* It's dangerous to freeze with locks held; there be dragons there.
*/
- if (!(state & __TASK_FREEZABLE_UNSAFE)) {
- static bool warned = false;
-
- if (!warned && debug_locks && p->lockdep_depth) {
- debug_show_held_locks(p);
- WARN(1, "%s/%d holding locks while freezing\n",
- p->comm, task_pid_nr(p));
- warned = true;
- }
- }
+ if (!(state & __TASK_FREEZABLE_UNSAFE))
+ WARN_ON_ONCE(debug_locks && p->lockdep_depth);
#endif
WRITE_ONCE(p->__state, TASK_FROZEN);
--
2.41.0
next prev parent reply other threads:[~2023-10-24 17:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 17:55 [Intel-gfx] [topic/core-for-CI][PATCH 0/2] Drop some unnecessary patches Ville Syrjala
2023-10-24 17:55 ` Ville Syrjala [this message]
2023-10-24 17:55 ` [Intel-gfx] [topic/core-for-CI][PATCH 2/2] Revert "iommu: Remove iova cpu hotplugging flushing" Ville Syrjala
2023-10-25 5:04 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Drop some unnecessary patches Patchwork
2023-10-25 5:04 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-10-25 5:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-10-25 11:41 ` [Intel-gfx] [topic/core-for-CI][PATCH 0/2] " Jani Nikula
2023-10-26 12:41 ` Ville Syrjälä
2023-10-25 20:58 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024175552.15503-2-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.