All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>,
	Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
	Christian Brauner <brauner@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Mimi Zohar <zohar@linux.ibm.com>
Subject: linux-next: manual merge of the integrity tree with the vfs-brauner tree
Date: Fri, 27 Oct 2023 13:11:37 +1100	[thread overview]
Message-ID: <20231027131137.3051da98@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1678 bytes --]

Hi all,

Today's linux-next merge of the integrity tree got a conflict in:

  fs/overlayfs/super.c

between commit:

  2bc5e5e8167f ("ovl: rely on SB_I_NOUMASK")

from the vfs-brauner tree and commit:

  bc4532e9cd3b ("ima: detect changes to the backing overlay file")

from the integrity tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc fs/overlayfs/super.c
index 1a95ee237fa9,c71d185980c0..000000000000
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@@ -1439,18 -1485,11 +1439,18 @@@ int ovl_fill_super(struct super_block *
  	cap_lower(cred->cap_effective, CAP_SYS_RESOURCE);
  
  	sb->s_magic = OVERLAYFS_SUPER_MAGIC;
 -	sb->s_xattr = ofs->config.userxattr ? ovl_user_xattr_handlers :
 -		ovl_trusted_xattr_handlers;
 +	sb->s_xattr = ovl_xattr_handlers(ofs);
  	sb->s_fs_info = ofs;
 +#ifdef CONFIG_FS_POSIX_ACL
  	sb->s_flags |= SB_POSIXACL;
 +#endif
- 	sb->s_iflags |= SB_I_SKIP_SYNC | SB_I_IMA_UNVERIFIABLE_SIGNATURE;
+ 	sb->s_iflags |= SB_I_SKIP_SYNC;
 +	/*
 +	 * Ensure that umask handling is done by the filesystems used
 +	 * for the the upper layer instead of overlayfs as that would
 +	 * lead to unexpected results.
 +	 */
 +	sb->s_iflags |= SB_I_NOUMASK;
  
  	err = -ENOMEM;
  	root_dentry = ovl_get_root(sb, ctx->upper.dentry, oe);

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

                 reply	other threads:[~2023-10-27  2:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231027131137.3051da98@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=brauner@kernel.org \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=zohar@linux.ibm.com \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.