From: "André Apitzsch" <git@apitzsch.eu>
To: Ricardo Ribalda <ribalda@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: "Kieran Bingham" <kieran.bingham@ideasonboard.com>,
"Jacopo Mondi" <jacopo.mondi@ideasonboard.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
"André Apitzsch" <git@apitzsch.eu>,
"Ricardo Ribalda" <ribalda@chromium.org>
Subject: [PATCH v2 3/5] media: i2c: imx214: Read orientation and rotation from system firmware
Date: Sat, 28 Oct 2023 09:17:46 +0200 [thread overview]
Message-ID: <20231028-imx214-v2-3-69a8fb730d6e@apitzsch.eu> (raw)
In-Reply-To: <20231028-imx214-v2-0-69a8fb730d6e@apitzsch.eu>
Obtain rotation and orientation information from system firmware and
register the appropriate controls. While at it, update number of
pre-allocated control slots.
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: André Apitzsch <git@apitzsch.eu>
---
drivers/media/i2c/imx214.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
index 4181127dba12..574878e8c97d 100644
--- a/drivers/media/i2c/imx214.c
+++ b/drivers/media/i2c/imx214.c
@@ -704,11 +704,16 @@ static int imx214_ctrls_init(struct imx214 *imx214)
.width = 1120,
.height = 1120,
};
+ struct v4l2_fwnode_device_properties props;
struct v4l2_ctrl_handler *ctrl_hdlr;
int ret;
+ ret = v4l2_fwnode_device_parse(imx214->dev, &props);
+ if (ret < 0)
+ return ret;
+
ctrl_hdlr = &imx214->ctrls;
- ret = v4l2_ctrl_handler_init(&imx214->ctrls, 3);
+ ret = v4l2_ctrl_handler_init(&imx214->ctrls, 6);
if (ret)
return ret;
@@ -746,6 +751,8 @@ static int imx214_ctrls_init(struct imx214 *imx214)
V4L2_CID_UNIT_CELL_SIZE,
v4l2_ctrl_ptr_create((void *)&unit_size));
+ v4l2_ctrl_new_fwnode_properties(ctrl_hdlr, &imx214_ctrl_ops, &props);
+
ret = ctrl_hdlr->error;
if (ret) {
v4l2_ctrl_handler_free(ctrl_hdlr);
--
2.42.0
next prev parent reply other threads:[~2023-10-28 7:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-28 7:17 [PATCH v2 0/5] media: i2c: imx214: Extend with sensor size and firmware information André Apitzsch
2023-10-28 7:17 ` [PATCH v2 1/5] media: i2c: imx214: Explain some magic numbers André Apitzsch
2023-10-28 7:17 ` [PATCH v2 2/5] media: i2c: imx214: Move controls init to separate function André Apitzsch
2023-10-28 7:17 ` André Apitzsch [this message]
2023-10-28 7:17 ` [PATCH v2 4/5] media: i2c: imx214: Add sensor's pixel matrix size André Apitzsch
2023-10-28 7:17 ` [PATCH v2 5/5] media: i2c: imx214: Fix cleanup after controls initialization error André Apitzsch
2023-10-28 7:30 ` Ricardo Ribalda Delgado
2023-10-28 7:51 ` André Apitzsch
2023-10-28 8:12 ` Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231028-imx214-v2-3-69a8fb730d6e@apitzsch.eu \
--to=git@apitzsch.eu \
--cc=jacopo.mondi@ideasonboard.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
--cc=ribalda@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.